Control: tags -1 + patch

Hi,

On Thu, Dec 19, 2019 at 09:19:19PM +0100, Salvatore Bonaccorso wrote:
> Source: cyrus-sasl2
> Version: 2.1.27+dfsg-1
> Severity: grave
> Tags: security upstream
> Forwarded: https://github.com/cyrusimap/cyrus-sasl/issues/587
> Control: found -1 2.1.27~101-g0780600+dfsg-3
> 
> Hi,
> 
> The following vulnerability was published for cyrus-sasl2.
> 
> CVE-2019-19906[0]:
> Off by one in _sasl_add_string function
> 
> If you fix the vulnerability please also make sure to include the
> CVE (Common Vulnerabilities & Exposures) id in your changelog entry.
> 
> For further information see:
> 
> [0] https://security-tracker.debian.org/tracker/CVE-2019-19906
>     https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-19906
> [1] https://github.com/cyrusimap/cyrus-sasl/issues/587

Attached patch for this issue.

Regards,
Salvatore
Description: CVE-2019-19906: Off-by-one in _sasl_add_string function
Origin: vendor
Bug: https://github.com/cyrusimap/cyrus-sasl/issues/587
Bug-Debian: https://bugs.debian.org/947043
Bug-Debian-Security: https://security-tracker.debian.org/tracker/CVE-2019-19906
Author: Stephan Zeisberg <step...@srlabs.de>
Reviewed-by: Salvatore Bonaccorso <car...@debian.org>
Last-Update: 2019-12-19

--- a/lib/common.c
+++ b/lib/common.c
@@ -190,7 +190,7 @@ int _sasl_add_string(char **out, size_t
 
   if (add==NULL) add = "(null)";
 
-  addlen=strlen(add); /* only compute once */
+  addlen=strlen(add)+1; /* only compute once */
   if (_buf_alloc(out, alloclen, (*outlen)+addlen)!=SASL_OK)
     return SASL_NOMEM;
 

Reply via email to