Bug#285086: marked as done (allegro4: FTBFS (amd64/gcc-4.0): invalid lvalue in increment)

[Debian Bug Tracking System]

Your message dated Sat, 13 May 2006 16:47:13 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#285086: fixed in allegro4 2:4.0.4-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---

Package: allegro4
Severity: normal
Tags: patch

When building 'allegro4' on amd64 with gcc-4.0,
I get the following error:

./src/fli.c:559: error: invalid lvalue in increment
./src/fli.c:568: error: invalid lvalue in increment
./src/fli.c:575: error: invalid lvalue in assignment
./src/fli.c:584: error: invalid lvalue in assignment
./src/fli.c:586: error: invalid lvalue in increment
./src/fli.c:586: error: invalid lvalue in increment
./src/fli.c:586: error: invalid lvalue in increment
./src/fli.c:586: error: invalid lvalue in increment
./src/fli.c:586: error: invalid lvalue in increment
./src/fli.c:596: error: invalid lvalue in increment
./src/fli.c:603: error: invalid lvalue in assignment
./src/fli.c:612: error: invalid lvalue in assignment
./src/fli.c:614: error: invalid lvalue in increment
./src/fli.c:614: error: invalid lvalue in increment
./src/fli.c:614: error: invalid lvalue in increment
./src/fli.c:614: error: invalid lvalue in increment
./src/fli.c:614: error: invalid lvalue in increment
make[1]: *** [obj/unix/alleg/fli.o] Error 1
make[1]: Leaving directory `/allegro4-4.0.3'
make: *** [build-stamp] Error 2

With the attached patch 'allegro4' can be compiled
on amd64 using gcc-4.0.

Regards
Andreas Jochens

diff -urN ../tmp-orig/allegro4-4.0.3/src/c/cstretch.c ./src/c/cstretch.c
--- ../tmp-orig/allegro4-4.0.3/src/c/cstretch.c 2003-04-19 09:06:47.000000000 
+0200
+++ ./src/c/cstretch.c  2004-12-10 15:21:02.000000000 +0100
@@ -37,10 +37,10 @@
 type *s = (type*) sptr;                                                   \
 unsigned long d = dptr;                                                   \
 unsigned long dend = d + _al_stretch.dw;                                  \
-for (; d < dend; d += (size), (unsigned char*) s += _al_stretch.sinc) {   \
+for (; d < dend; d += (size), s = (unsigned char*) s + _al_stretch.sinc) {\
    set(d, get(s));                                                        \
    if (dd >= 0)                                                           \
-      (unsigned char*) s += (size), dd += _al_stretch.i2;                 \
+      s = (unsigned char*) s + (size), dd += _al_stretch.i2;              \
    else                                                                   \
       dd += _al_stretch.i1;                                               \
 }
@@ -130,12 +130,12 @@
 type *s = (type*) sptr;                                                   \
 unsigned long d = dptr;                                                   \
 unsigned long dend = d + _al_stretch.dw;                                  \
-for (; d < dend; d += (size), (unsigned char*) s += _al_stretch.sinc) {   \
+for (; d < dend; d += (size), s = (unsigned char*) s + _al_stretch.sinc) {\
    unsigned long color = get(s);                                          \
    if (color != (mask))                                                   \
    set(d, color);                                                         \
    if (dd >= 0)                                                           \
-      (unsigned char*) s += (size), dd += _al_stretch.i2;                 \
+      s = (unsigned char*) s + (size), dd += _al_stretch.i2;              \
    else                                                                   \
       dd += _al_stretch.i1;                                               \
 }
diff -urN ../tmp-orig/allegro4-4.0.3/src/fli.c ./src/fli.c
--- ../tmp-orig/allegro4-4.0.3/src/fli.c        2003-04-19 09:06:47.000000000 
+0200
+++ ./src/fli.c 2004-12-10 15:17:12.000000000 +0100
@@ -184,8 +184,8 @@
 
 
 /* helpers for reading FLI chunk data */
-#define READ_BYTE_NC(p)    (*((unsigned char *)(p))++)
-#define READ_CHAR_NC(p)    (*((signed char *)(p))++)
+#define READ_BYTE_NC(p)    ((unsigned char)(*p++))
+#define READ_CHAR_NC(p)    ((char *)(*p++))
 
 #if (defined ALLEGRO_GCC) && (defined ALLEGRO_I386)
 
@@ -330,7 +330,7 @@
       if (end > PAL_SIZE)
         return;
       else if ((sz -= length * 3) < 0) {
-        FLI_KLUDGE((char *)p, sz, length * 3);
+        FLI_KLUDGE(p, sz, length * 3);
       }
 
       fli_pal_dirty_from = MIN(fli_pal_dirty_from, offset);
@@ -396,7 +396,7 @@
            if ((curr + size * 2) > bitmap_end)
               return;
            else if ((sz -= size * 2) < 0) {
-              FLI_KLUDGE((char *)p, sz, size * 2);
+              FLI_KLUDGE(p, sz, size * 2);
            }
            READ_BLOCK_NC(p, curr, size*2);
            curr += size*2;
@@ -406,7 +406,7 @@
            if ((curr + size * 2) > bitmap_end)
               return;
            else if ((sz -= 2) < 0) {
-              FLI_KLUDGE((char *)p, sz, 2);
+              FLI_KLUDGE(p, sz, 2);
            }
            READ_RLE_WORD_NC(p, curr, size);
            curr += size*2;
@@ -446,7 +446,7 @@
       if (end > PAL_SIZE)
         return;
       else if ((sz -= length * 3) < 0) {
-        FLI_KLUDGE((char *)p, sz, length * 3);
+        FLI_KLUDGE(p, sz, length * 3);
       }
 
       fli_pal_dirty_from = MIN(fli_pal_dirty_from, offset);
@@ -503,7 +503,7 @@
            if ((curr + size) > bitmap_end)
               return;
            else if ((sz -= size) < 0) {
-              FLI_KLUDGE((char *)p, sz, size);
+              FLI_KLUDGE(p, sz, size);
            }
            READ_BLOCK_NC(p, curr, size);
            curr += size;
@@ -513,7 +513,7 @@
            if ((curr + size) > bitmap_end)
               return;
            else if ((sz -= 1) < 0) {
-              FLI_KLUDGE((char *)p, sz, 1);
+              FLI_KLUDGE(p, sz, 1);
            }
            READ_RLE_BYTE_NC(p, curr, size);
            curr += size;
@@ -572,7 +572,7 @@
               if ((curr + size) > bitmap_end)
                  return;
               else if ((sz -= size) < 0) {
-                 FLI_KLUDGE((char *)p, sz, size);
+                 FLI_KLUDGE(p, sz, size);
               }
               READ_BLOCK_NC(p, curr, size);
               curr += size;
@@ -581,7 +581,7 @@
               if ((curr + size) > bitmap_end)
                  return;
               else if ((sz -= 1) < 0) {
-                 FLI_KLUDGE((char *)p, sz, 1);
+                 FLI_KLUDGE(p, sz, 1);
               }
               READ_RLE_BYTE_NC(p, curr, size);
               curr += size;
@@ -600,7 +600,7 @@
               if ((curr + size) > bitmap_end)
                  return;
               if ((sz -= size) < 0) {
-                 FLI_KLUDGE((char *)p, sz, size);
+                 FLI_KLUDGE(p, sz, size);
               }
               READ_BLOCK_NC(p, curr, size);
               curr += size;
@@ -609,7 +609,7 @@
               if ((curr + size) > bitmap_end)
                  return;
               if ((sz -= 1) < 0) {
-                 FLI_KLUDGE((char *)p, sz, 1);
+                 FLI_KLUDGE(p, sz, 1);
               }
               READ_RLE_BYTE_NC(p, curr, size);
               curr += size;
diff -urN ../tmp-orig/allegro4-4.0.3/src/sound.c ./src/sound.c
--- ../tmp-orig/allegro4-4.0.3/src/sound.c      2003-04-19 09:06:47.000000000 
+0200
+++ ./src/sound.c       2004-12-10 15:18:42.000000000 +0100
@@ -25,7 +25,7 @@
 
 
 
-extern DIGI_DRIVER digi_none;
+static DIGI_DRIVER digi_none;
 
 
 

--- End Message ---

--- Begin Message ---

Source: allegro4
Source-Version: 2:4.0.4-1

We believe that the bug you reported is fixed in the latest version of
allegro4, which is due to be installed in the Debian FTP archive:

allegro4_4.0.4-1.diff.gz
  to pool/main/a/allegro4/allegro4_4.0.4-1.diff.gz
allegro4_4.0.4-1.dsc
  to pool/main/a/allegro4/allegro4_4.0.4-1.dsc
allegro4_4.0.4.orig.tar.gz
  to pool/main/a/allegro4/allegro4_4.0.4.orig.tar.gz
liballegro4a-plugin-arts_4.0.4-1_all.deb
  to pool/main/a/allegro4/liballegro4a-plugin-arts_4.0.4-1_all.deb
liballegro4a-plugin-esd_4.0.4-1_all.deb
  to pool/main/a/allegro4/liballegro4a-plugin-esd_4.0.4-1_all.deb
liballegro4a_4.0.4-1_all.deb
  to pool/main/a/allegro4/liballegro4a_4.0.4-1_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sam Hocevar (Debian packages) <[EMAIL PROTECTED]> (supplier of updated allegro4 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sat, 13 May 2006 18:01:17 -0500
Source: allegro4
Binary: liballegro4a-plugin-svgalib liballegro4a-plugin-esd liballegro4a 
liballegro4a-plugin-arts
Architecture: source all
Version: 2:4.0.4-1
Distribution: unstable
Urgency: low
Maintainer: Sam Hocevar (Debian packages) <[EMAIL PROTECTED]>
Changed-By: Sam Hocevar (Debian packages) <[EMAIL PROTECTED]>
Description: 
 liballegro4a - dummy package
 liballegro4a-plugin-arts - dummy package
 liballegro4a-plugin-esd - dummy package
 liballegro4a-plugin-svgalib - dummy package
Closes: 285086
Changes: 
 allegro4 (2:4.0.4-1) unstable; urgency=low
 .
   * New non-upstream non-release.
   * Emptied soon-to-be-removed package.
   * No more files, no more bugs! Muahahaha. (Closes: #285086)
   * debian/control:
     + Build-depend on debhelper (>= 4.0) for better policy compliance.
     + Set policy to 3.7.2.
   * debian/compat:
     + Set version to 4.
Files: 
 78ccc35f17d2817fa585e1b111f09fbb 660 libs optional allegro4_4.0.4-1.dsc
 5f19bed5c1c618269dba8e2fa206e4a4 110 libs optional allegro4_4.0.4.orig.tar.gz
 d7a920a7e9a5f9752f0a5c17c7d0a42f 7019 libs optional allegro4_4.0.4-1.diff.gz
 aeaecbdb741f7cecd6dc3fa7764b936a 7698 libs optional 
liballegro4a_4.0.4-1_all.deb
 52280708a9d35424a223a0df088c86a2 7720 libs optional 
liballegro4a-plugin-esd_4.0.4-1_all.deb
 7376a5329c47133be84023e74e290a5e 7722 libs optional 
liballegro4a-plugin-arts_4.0.4-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQFEZmudfPP1rylJn2ERAs2lAJ9hEBxylpVLjdl87T6N4Oe7YXXY3wCdHJyS
f2XyabvlhWD+nd89VMoHT/s=
=O/0D
-----END PGP SIGNATURE-----

--- End Message ---