Your message dated Sat, 13 May 2006 16:50:38 +0200
with message-id <[EMAIL PROTECTED]>
and subject line fixed
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: magma
Severity: normal
Tags: patch

When building 'magma' on amd64 with gcc-4.0,
I get the following error:

Configuring Makefiles for your system...
Completed Makefile configuration

gcc -c -o localinfo.o localinfo.c -I. -I/magma-0.trunk20040913/debian/include 
-Wall -I. -g -Werror -Wstrict-prototypes -Wshadow -fPIC 
-DPLUGINDIR=\"/usr/lib/magma/plugins\" -D_GNU_SOURCE -D_CLUSTER_
cc1: warnings being treated as errors
localinfo.c: In function '_get_local_info':
localinfo.c:50: warning: pointer targets in passing argument 1 of 'ip_lookup' 
differ in signedness
localinfo.c:53: warning: pointer targets in passing argument 1 of 'strdup' 
differ in signedness
make[2]: *** [localinfo.o] Error 1
make[2]: Leaving directory `/magma-0.trunk20040913/lib'

With the attached patch 'magma' can be compiled
on amd64 using gcc-4.0.

Regards
Andreas Jochens

diff -urN ../tmp-orig/magma-0.trunk20040913/lib/localinfo.c ./lib/localinfo.c
--- ../tmp-orig/magma-0.trunk20040913/lib/localinfo.c   2004-09-13 
12:13:32.000000000 +0200
+++ ./lib/localinfo.c   2004-12-29 09:37:36.630086208 +0100
@@ -47,10 +47,10 @@
                return -1;
 
         for (x=0; x < members->cml_count; x++) {
-               if (ip_lookup(members->cml_members[x].cm_name, NULL) == 0) {
+               if (ip_lookup((char*)members->cml_members[x].cm_name, NULL) == 
0) {
                        _local_nodeid = members->cml_members[x].cm_id;
                        _local_nodename =
-                               strdup(members->cml_members[x].cm_name);
+                               strdup((char*)members->cml_members[x].cm_name);
                        break;
                }
        }
diff -urN ../tmp-orig/magma-0.trunk20040913/lib/memberlist.c ./lib/memberlist.c
--- ../tmp-orig/magma-0.trunk20040913/lib/memberlist.c  2004-09-13 
12:13:32.000000000 +0200
+++ ./lib/memberlist.c  2004-12-29 09:38:44.820719656 +0100
@@ -162,7 +162,7 @@
        for (x = 0; x < list->cml_count; x++) {
                if (list->cml_members[x].cm_id == nodeid &&
                    list->cml_members[x].cm_state == STATE_UP)
-                       return list->cml_members[x].cm_name;
+                       return (char*)list->cml_members[x].cm_name;
        }
 
        return NULL;
@@ -181,7 +181,7 @@
                return (uint64_t)-1;
 
        for (x = 0; x < list->cml_count; x++) {
-               if (!strcmp(list->cml_members[x].cm_name, nodename) &&
+               if (!strcmp((char*)list->cml_members[x].cm_name, nodename) &&
                    list->cml_members[x].cm_state == STATE_UP)
                        return list->cml_members[x].cm_id;
        }
@@ -223,7 +223,7 @@
                return NULL;
 
        for (x = 0; x < list->cml_count; x++) {
-               if (!strcmp(list->cml_members[x].cm_name, nodename) &&
+               if (!strcmp((char*)list->cml_members[x].cm_name, nodename) &&
                    list->cml_members[x].cm_state == STATE_UP)
                        return &list->cml_members[x];
        }
@@ -271,7 +271,7 @@
         */
        ai.ai_socktype = SOCK_STREAM;
 
-       if (getaddrinfo(member->cm_name, NULL, &ai, &member->cm_addrs) != 0) {
+       if (getaddrinfo((char*)member->cm_name, NULL, &ai, &member->cm_addrs) 
!= 0) {
                member->cm_addrs = NULL;
                return -1;
        }
@@ -358,7 +358,7 @@
                        if (om->cm_id != nm->cm_id)
                                continue;
 
-                       if (strcmp(om->cm_name, nm->cm_name))
+                       if (strcmp((char*)om->cm_name, (char*)nm->cm_name))
                                continue;
 
                        /* We have a match, but no old-address */
diff -urN ../tmp-orig/magma-0.trunk20040913/lib/message.c ./lib/message.c
--- ../tmp-orig/magma-0.trunk20040913/lib/message.c     2004-09-13 
12:13:32.000000000 +0200
+++ ./lib/message.c     2004-12-29 09:39:14.886149016 +0100
@@ -222,7 +222,8 @@
 static int
 connect_nb(int fd, struct sockaddr *dest, socklen_t len, int timeout)
 {
-       int ret, flags = 1, err, l;
+       int ret, flags = 1, err;
+       socklen_t l;
        fd_set rfds, wfds;
        struct timeval tv;
 


--- End Message ---
--- Begin Message ---
Version: 1.02.00-1

This bug was fixed upstream and is already in debian.

Bastian

-- 
You!  What PLANET is this!
                -- McCoy, "The City on the Edge of Forever", stardate 3134.0

--- End Message ---

Reply via email to