Your message dated Tue, 03 Dec 2019 05:19:47 +0000
with message-id <e1ic0bd-0001is...@fasolo.debian.org>
and subject line Bug#945345: fixed in therion 5.4.4ds1-3
has caused the Debian Bug report #945345,
regarding therion: Missing build-dep on python; build-depend on python3 instead
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
945345: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=945345
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: therion
Version: 5.4.4ds1-2
Severity: serious
Tags: patch
Justification: FTBFS
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu focal ubuntu-patch

Dear maintainers,

The therion package fails to build from source in Debian unstable in a clean
buildd environment, because the upstream makefile invokes python but therion
does not build-depend on it, so now that its various build-dependencies have
moved away from python to python3, this invocation fails:

[...]
# Compile the binaries
/usr/bin/make therion xtherion/xtherion loch/loch
make[2]: Entering directory '/<<PKGBUILDDIR>>'
python set_version.py
make[2]: python: Command not found
[...]

  
(https://launchpad.net/ubuntu/+source/therion/5.4.4ds1-2build1/+build/17978786)

Rather than adding a build-dependency on python, which is deprecated, I have
attached a patch which moves the invocation to python3 instead and added a
build-dependency on python3.

I have also uploaded this change to Ubuntu, where the problem was first
discovered.

Cheers,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slanga...@ubuntu.com                                     vor...@debian.org
diff -Nru therion-5.4.4ds1/debian/control therion-5.4.4ds1/debian/control
--- therion-5.4.4ds1/debian/control     2019-09-16 21:58:01.000000000 -0700
+++ therion-5.4.4ds1/debian/control     2019-11-22 22:13:29.000000000 -0800
@@ -5,7 +5,7 @@
 Uploaders: Olly Betts <o...@survex.com>
 Build-Depends: dpkg (>=1.16.2), debhelper (>= 10), perl (>= 5.5), tcl,
   libvtk6-dev, libwxgtk3.0-gtk3-dev, libfreetype6-dev, libjpeg-dev, libpng-dev,
-  pkg-config, texlive-base, libproj-dev, libsqlite3-tcl
+  pkg-config, texlive-base, libproj-dev, libsqlite3-tcl, python3
 Build-Depends-Indep: texlive-metapost, imagemagick, ghostscript
 Standards-Version: 4.4.0
 Homepage: https://therion.speleo.sk/
diff -Nru therion-5.4.4ds1/debian/patches/python3-not-python.patch 
therion-5.4.4ds1/debian/patches/python3-not-python.patch
--- therion-5.4.4ds1/debian/patches/python3-not-python.patch    1969-12-31 
16:00:00.000000000 -0800
+++ therion-5.4.4ds1/debian/patches/python3-not-python.patch    2019-11-22 
22:13:19.000000000 -0800
@@ -0,0 +1,18 @@
+Description: Use python3 at build time, not python.
+ This package previously built successfully because python happened to be
+ installed in the environment, but now that everything is moving to python3
+ it is not.  Invoke python3 instead of the deprecated python.
+Author: Steve Langasek <steve.langa...@ubuntu.com>
+Last-Update: 2019-11-23
+
+--- therion-5.4.4ds1.orig/Makefile
++++ therion-5.4.4ds1/Makefile
+@@ -175,7 +175,7 @@ outdirs:
+       mkdir -p $(OUTDIR)/thbook
+ 
+ version:
+-      python set_version.py
++      python3 set_version.py
+ 
+ 
+ $(OUTDIR)/therion: version $(OBJECTS)
diff -Nru therion-5.4.4ds1/debian/patches/series 
therion-5.4.4ds1/debian/patches/series
--- therion-5.4.4ds1/debian/patches/series      2019-07-07 16:52:56.000000000 
-0700
+++ therion-5.4.4ds1/debian/patches/series      2019-11-22 22:11:59.000000000 
-0800
@@ -1,3 +1,4 @@
 10doc-fixes.patch
 80debianise-makefiles.patch
 90debianise-loch-makefile.patch
+python3-not-python.patch

--- End Message ---
--- Begin Message ---
Source: therion
Source-Version: 5.4.4ds1-3

We believe that the bug you reported is fixed in the latest version of
therion, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 945...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Olly Betts <o...@survex.com> (supplier of updated therion package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 03 Dec 2019 17:43:25 +1300
Source: therion
Architecture: source
Version: 5.4.4ds1-3
Distribution: unstable
Urgency: medium
Maintainer: Wookey <woo...@debian.org>
Changed-By: Olly Betts <o...@survex.com>
Closes: 945345
Changes:
 therion (5.4.4ds1-3) unstable; urgency=medium
 .
   * Fix FTBFS due to python no longer being implicitly pulled in as an
     indirect dependency by applying changes from Steve Langasek to depend on
     python3 and use it to run upstream's set_version.py.  New patch:
     python3-not-python.patch (Closes: #945345)
Checksums-Sha1:
 7442b74f2a7a804034816e12eea104675b662856 2178 therion_5.4.4ds1-3.dsc
 e34e91e4fe68ed9d132e3b6f6630404a69f3b6c3 19140 therion_5.4.4ds1-3.debian.tar.xz
 d30ed4f2eadbc290cf4b520ffe146bdad12f5558 20661 
therion_5.4.4ds1-3_amd64.buildinfo
Checksums-Sha256:
 d940f3cb0f6b185f034820bad9a24458c0f9df28721cf4d2745077004095cdc9 2178 
therion_5.4.4ds1-3.dsc
 1816d1eb06452149aa178fca7bff54ebf8444ec82a3d6817176db22ad43b1a4d 19140 
therion_5.4.4ds1-3.debian.tar.xz
 52e065dab4b330097537f6ad80617463bf8a26e9163cdec7f4a3c25dcff848fd 20661 
therion_5.4.4ds1-3_amd64.buildinfo
Files:
 8812ea150acf150f6bab091a07dac5a3 2178 science optional therion_5.4.4ds1-3.dsc
 c8c6aefc1abc9bc3a2da7115f587511a 19140 science optional 
therion_5.4.4ds1-3.debian.tar.xz
 1f946fe801224160d7fccca2778c4479 20661 science optional 
therion_5.4.4ds1-3_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEECOJAD/f+j+3jrLUoGBR7BzutKwcFAl3l6xwACgkQGBR7Bzut
Kwdvqg//XmTh5p65rxMizvggQbA53msTejI0HvM4xLE7B1QtcaGDSUwrmkdyZzLG
zunoPDuycC3FLQVX1TEUh7QjtfU3DEt9ShCnLHt5GJVgb4ExonCSrbpUp1ehAuJm
q+gdoiZxsrxplt+No/aQFfmKyIorFjwyM2tZlJ+VNN3/va2efzMlQ9LH9lSgBc2T
e85UhhtfwSfNRWuDH2yVhC3N9tD3uyLuVPZgj77EPqfhty/kohG1aniYsByvccxV
Vqe4i3Fh6x7YD2BWPv7/39exGqUtyE/VYr0SkF/+wsQeQW6vCAw1HlbptByi0cn1
5Dx6Mfrum/To6aXz4PmEVUc+37iwQdRClASlF/MtfZ6yorD6fpkWclM+CTFQ2+CG
INzedb1WfhKtem6Crd8stQFMmNWHPqsE9n7MXyMFICikp6hn1UTGlGSJf810KUX2
bItqjI4U7y0xQS7yJKGrKt3jNZzBs1xNB0i4pJ5BPqJFxQBXfRKlQjzfeRzuAFmc
81eQNHFuE0Pqs2oh/BKP64b7zRR/PBt8WSMSwHqQmkgA43CvwhbdfRWNde0+MTYA
ZbQ0ILHVrU2mVYaagqHfxXmFZvpS1QuI9pVhZ1eATEbWN7xhYiJvyr8nsJkzXb0N
G/7Ot8njPGCpbxiuV95ZeJYyUTlxIDye6/gjLwCdlVtljy/Bkto=
=MFwB
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to