Package: git-buildpackage
Version: 0.9.14
Severity: serious
Tags: ftbfs
Justification: fails to build from source

During test-builds to evaluate whether the new version of gtk-doc-tools is
ready for upload to unstable, git-buildpackage failed to build. I can
reproduce the build failure in a pure unstable sbuild environment:

>    debian/rules override_dh_auto_test
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> make
> make[2]: Entering directory '/<<PKGBUILDDIR>>'
> flake8
> ./gbp/patch_series.py:148:17: E117 over-indented
> ./gbp/scripts/buildpackage.py:333:13: E117 over-indented
> ./gbp/scripts/import_orig.py:82:17: E117 over-indented
> ./gbp/scripts/common/import_orig.py:71:13: E117 over-indented
> ./.pybuild/cpython3_3.7/build/gbp/patch_series.py:148:17: E117 over-indented
> ./.pybuild/cpython3_3.7/build/gbp/scripts/buildpackage.py:333:13: E117 
> over-indented
> ./.pybuild/cpython3_3.7/build/gbp/scripts/import_orig.py:82:17: E117 
> over-indented
> ./.pybuild/cpython3_3.7/build/gbp/scripts/common/import_orig.py:71:13: E117 
> over-indented
> make[2]: *** [Makefile:20: syntax-check] Error 1

Full build log attached.

I would recommend skipping stylistic/non-functional checks like this one,
or making them only produce warnings, when "official" packages are built
in a Debian environment (the style checks can still be fatal when run as
part of `make check` during development, of course). Perhaps something
like this:

    # in debian/rules
    export IGNORE_STYLE_CHECKS = 1

    # in the tests, replacing the flake8 invocation
    flake8 || [ -n "$IGNORE_STYLE_CHECKS" ]

Regards,
    smcv

Attachment: git-buildpackage_0.9.14_all_20190907t091327.build.xz
Description: application/xz

Reply via email to