Your message dated Fri, 09 Aug 2019 10:22:17 +0000 with message-id <e1hw22l-000590...@fasolo.debian.org> and subject line Bug#930935: fixed in webkit2gtk 2.25.4-1 has caused the Debian Bug report #930935, regarding webkit2gtk: Baseline violation on i386 to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 930935: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=930935 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Source: webkit2gtk Version: 2.24.1-2 Severity: serious Tags: patch webkit2gtk violates the baseline on i386 by using SSE. While keeping floating point values consistent between 32bit and 64bit is nice in general, it is bad if this makes the code crash on large parts of the supported i386 hardware - most hardware with SSE2 runs the amd64 port, and at least one non-SSE i386 CPU is still in production for embedded systems (AMD Geode). Fix is attached.diff -Nru webkit2gtk-2.24.2/debian/NEWS webkit2gtk-2.24.2/debian/NEWS --- webkit2gtk-2.24.2/debian/NEWS 2019-05-17 17:40:52.000000000 +0300 +++ webkit2gtk-2.24.2/debian/NEWS 2019-05-17 17:40:52.000000000 +0300 @@ -1,12 +1,3 @@ -webkit2gtk (2.24.1-2) unstable; urgency=high - - Since version 2.24.0, i386 builds of WebKitGTK require an SSE2-capable - CPU. This instruction set was first introduced with the Pentium 4 in - year 2000. Support for older processors was dropped in WebKitGTK - upstream and is unfortunately not expected to come back. - - -- Alberto Garcia <be...@igalia.com> Fri, 10 May 2019 15:40:28 +0300 - webkit2gtk (2.20.0-2) unstable; urgency=medium webkit2gtk 2.20.0 contains a security feature named Gigacage that diff -Nru webkit2gtk-2.24.2/debian/patches/i386-no-sse.patch webkit2gtk-2.24.2/debian/patches/i386-no-sse.patch --- webkit2gtk-2.24.2/debian/patches/i386-no-sse.patch 1970-01-01 02:00:00.000000000 +0200 +++ webkit2gtk-2.24.2/debian/patches/i386-no-sse.patch 2019-05-17 17:40:52.000000000 +0300 @@ -0,0 +1,21 @@ +Description: SSE is a baseline violation on i386 +Author: Adrian Bunk <b...@debian.org> + +--- webkit2gtk-2.24.2.orig/Source/cmake/WebKitCompilerFlags.cmake ++++ webkit2gtk-2.24.2/Source/cmake/WebKitCompilerFlags.cmake +@@ -144,15 +144,6 @@ if (COMPILER_IS_GCC_OR_CLANG) + if (CMAKE_COMPILER_IS_GNUCXX) + WEBKIT_PREPEND_GLOBAL_COMPILER_FLAGS(-Wno-expansion-to-defined) + endif () +- +- # Force SSE2 fp on x86 builds. +- if (WTF_CPU_X86 AND NOT CMAKE_CROSSCOMPILING) +- WEBKIT_PREPEND_GLOBAL_COMPILER_FLAGS(-msse2 -mfpmath=sse) +- include(DetectSSE2) +- if (NOT SSE2_SUPPORT_FOUND) +- message(FATAL_ERROR "SSE2 support is required to compile WebKit") +- endif () +- endif () + endif () + + if (COMPILER_IS_GCC_OR_CLANG AND NOT MSVC) diff -Nru webkit2gtk-2.24.2/debian/patches/series webkit2gtk-2.24.2/debian/patches/series --- webkit2gtk-2.24.2/debian/patches/series 2019-05-17 17:40:52.000000000 +0300 +++ webkit2gtk-2.24.2/debian/patches/series 2019-05-17 17:40:52.000000000 +0300 @@ -7,3 +7,4 @@ detect-woff.patch user-agent-branding.patch prefer-pthread.patch +i386-no-sse.patch diff -Nru webkit2gtk-2.24.2/debian/rules webkit2gtk-2.24.2/debian/rules --- webkit2gtk-2.24.2/debian/rules 2019-05-17 17:40:52.000000000 +0300 +++ webkit2gtk-2.24.2/debian/rules 2019-05-17 17:40:52.000000000 +0300 @@ -23,11 +23,6 @@ CFLAGS := $(CFLAGS:-g=-g1) endif -# The 32-bit x86 build requires SSE2 -ifneq (,$(filter $(DEB_HOST_ARCH),i386)) - CFLAGS += -msse2 -mfpmath=sse -endif - # See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81426 ifneq (,$(filter $(DEB_HOST_ARCH),armhf sh3 sh4 powerpc)) CFLAGS := $(CFLAGS:-O2=-O1)
--- End Message ---
--- Begin Message ---Source: webkit2gtk Source-Version: 2.25.4-1 We believe that the bug you reported is fixed in the latest version of webkit2gtk, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 930...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Alberto Garcia <be...@igalia.com> (supplier of updated webkit2gtk package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Fri, 09 Aug 2019 11:52:26 +0200 Source: webkit2gtk Architecture: source Version: 2.25.4-1 Distribution: experimental Urgency: medium Maintainer: Debian WebKit Maintainers <pkg-webkit-maintain...@lists.alioth.debian.org> Changed-By: Alberto Garcia <be...@igalia.com> Closes: 870814 930935 Changes: webkit2gtk (2.25.4-1) experimental; urgency=medium . * New upstream development release. * Refresh all patches. * debian/source/lintian-overrides: + Update source-is-missing override. * Use the CLoop Javascript interpreter in i386 and stop telling gcc to use SSE2 instructions (Closes: #930935). + debian/rules: - Build with -DENABLE_JIT=OFF -DENABLE_C_LOOP=ON and stop using -msse2 -mfpmath=sse. + debian/patches/dont-detect-sse2.patch: - Don't check for SSE2 support. + debian/NEWS: - Remove item about the requirement to have an SSE2-capable CPU. * WebKitGTK 2.25.3 no longer ships the GTK 2 plugin process: + debian/control: - Drop build dependency on libgtk2.0-dev. - Remove the libwebkit2gtk-4.0-37-gtk2 package. + debian/NEWS: - Add item explaining the removal of the GTK 2 plugin process. + debian/libwebkit2gtk-4.0-37-gtk2.install: - Drop this file. * debian/control: + Recommend gstreamer1.0-libav. This package allows the user to play most internet videos (Closes: #870814). + Update Standards-Version to 4.4.0 (no changes). * debian/libwebkit2gtk-4.0-37.symbols: + Update symbols. Checksums-Sha1: 1d113ece7cb125ebb40bd5de5f7adfc89754de48 4087 webkit2gtk_2.25.4-1.dsc 422848e5e4e07ba7b72fd31890dff926d25b5dc1 19288348 webkit2gtk_2.25.4.orig.tar.xz 4a79d04d7f29d97dd7dc5a23a5ed78b30b38d6b7 195 webkit2gtk_2.25.4.orig.tar.xz.asc 81a3fd5e8b0ead5e812b2395b79c94478386e75e 61392 webkit2gtk_2.25.4-1.debian.tar.xz 9204ff1b93a727b3e29371660756f6ba10e50500 15980 webkit2gtk_2.25.4-1_source.buildinfo Checksums-Sha256: 1e1a584d0759f85ddcdafe6817dac87d9fe09a4e3d73ec2b67ca56f22b67acb2 4087 webkit2gtk_2.25.4-1.dsc 9361058c059402117995c779906f4a25232185ce7735663428fda9cf3c79f101 19288348 webkit2gtk_2.25.4.orig.tar.xz a6497dff1c071634805491d10e5a8c3af646f24dc5382e830e8a66da601a77fa 195 webkit2gtk_2.25.4.orig.tar.xz.asc 862a33ef40f6384aea4e779f58be4d1fc11828bd01c706531725249f9f8b97a1 61392 webkit2gtk_2.25.4-1.debian.tar.xz 75b00ae3542bae241452a70fb874139bbff02a15317cff4cfc824fd08d67c47e 15980 webkit2gtk_2.25.4-1_source.buildinfo Files: f86afeebda3f051965734cffa95bcccb 4087 web optional webkit2gtk_2.25.4-1.dsc a38e60ab1b1fc555daf863837f2cfd43 19288348 web optional webkit2gtk_2.25.4.orig.tar.xz 882ac43343c226da945b07bb711cb9f2 195 web optional webkit2gtk_2.25.4.orig.tar.xz.asc 81cb643933ef87a073781916a7d70966 61392 web optional webkit2gtk_2.25.4-1.debian.tar.xz 0aac6deb3f1dee4675d79ade8e94b247 15980 web optional webkit2gtk_2.25.4-1_source.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEYrwugQBKzlHMYFizAAyEYu0C2AIFAl1NQsYACgkQAAyEYu0C 2AIPlRAAnbkmtoRbk9oV70iUBb+QTetE6nzyY9hWm2bHHSXFzcvfih3pMEABdTcY GMY30yxE3cG9bmUcYOx54lu6eNJuO4d+Snz8kQQhzUHZx2ybIAmtLKWx1L4bUpTW FOI6a1IGiXBq29PCbBDq2K66Wo3Z4Q/3bCv8q2MDGe8vCQk986HWrBjVbmSfGqWp yd1BOhjdOeWDrHU9DIhvMwFI+B7DsLK2t1MX4hb/2qzWynub2R7zL7miikclJLkb UI8oN1IJ43Dzzt9JlEaV+Cd6gTWiQtk+HI2cAg1jgegcyLOROgAr+ggLitZvUcbZ w49SazHvsHUycgdkBoWa+8uiqNZVXbIhGZYW+7kY2wluogAIY234tWiCz9usJNkQ FX8oBGvqpeRIUHrHh+pW2S56+5hcQbab6C+vRxXUq/NqQ/zUSaLF1jHz7i1aVYR3 QXvwStCR1xW2f6kO5CEUjgLkOW1+OPeO3/jKlC4F5wyHxfGuNCyNKcizJxGJlOr1 MUa1C1aRsdEjM1aE7NCwKKVGcSgTC+0wOkHPYdvNIcdcPJO1kLUz4GBZ8DgBlRBa Qw0G4MSfSEEzSBNR6heNY0mHIC4T48X0LEvZ46pEisg7oc5Y1eLfhpINPcclkAzQ Obzc7aX/jc3Wmjj0Uwu77xWg68R7e8ACrRNuxwiwRV+CMcXV484= =Khfb -----END PGP SIGNATURE-----
--- End Message ---
