Your message dated Fri, 26 Jul 2019 22:34:26 +0000
with message-id <e1hr8nc-000coe...@fasolo.debian.org>
and subject line Bug#825381: fixed in makejail 0.0.5-10.1
has caused the Debian Bug report #825381,
regarding makejail fails on updating symbolic links
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
825381: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=825381
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: makejail
Version: 0.0.5-10
Severity: critical
Tags: patch
Justification: breaks unrelated software

Dear Maintainer,

when updating an existing chroot jail, then makejail fails on updating
symbolic links, e.g. for updated libraries.
makejails aborts and leaves the jail in an inconsistent stage.
Reason is that it doesn't recognize existing but broken symbol links.
As a fix I use the attached patch.

-- My error case:
   Checking Depends
        Executing : dpkg -p base-passwd
        Executing : dpkg -l libc6
      Installing the package libc6
         Copying the files from the dpkg information
            ...
            Checking path '/usr/lib/x86_64-linux-gnu/gconv/ASMO_449.so'
               File /usr/lib/x86_64-linux-gnu/gconv/ASMO_449.so is newer
than the /home/maddes/usr/lib/x86_64-linux-gnu/gconv/ASMO_449.so,
overwriting
                 Executing : file
/usr/lib/x86_64-linux-gnu/gconv/ASMO_449.so
                  shared object, checking the required libraries with ldd
                    Executing : ldd
/usr/lib/x86_64-linux-gnu/gconv/ASMO_449.so
                  Checking path '/lib/x86_64-linux-gnu/libc.so.6'
                     File /home/maddes/lib/x86_64-linux-gnu/libc.so.6
already exists
                  Checking path '/lib64/ld-linux-x86-64.so.2'
                     '/lib64/ld-linux-x86-64.so.2' is a symlink to
'/lib/x86_64-linux-gnu/ld-2.19.so'
                     Checking path '/lib/x86_64-linux-gnu/ld-2.19.so'
                        File
/home/maddes/lib/x86_64-linux-gnu/ld-2.19.so already exists
                        Creating 'lib64/ld-linux-x86-64.so.2' as a
symlink to '/lib/x86_64-linux-gnu/ld-2.19.so' (pwd=/home/maddes/lib64)
Traceback (most recent call last):
  File "/usr/sbin/makejail", line 1060, in <module>
    makeChroot()
  File "/usr/sbin/makejail", line 888, in makeChroot
    addPackageToJail(package)
  File "/usr/sbin/makejail", line 585, in addPackageToJail
    addPackageToJail(depend)
  File "/usr/sbin/makejail", line 576, in addPackageToJail
    addFileToJail(file)
  File "/usr/sbin/makejail", line 448, in addFileToJail
    checkRequirements(fileName)
  File "/usr/sbin/makejail", line 553, in checkRequirements
    addFileToJail(lib)
  File "/usr/sbin/makejail", line 395, in addFileToJail
    os.symlink(linkTarget,os.path.split(fileName)[1])
OSError: [Errno 17] File exists

-- Reason for my error case:
lib64/ld-linux-x86-64.so.2 pointed to the older installed library, which
was not existent anymore.

-- Patch:
--- /usr/sbin/makejail  2012-03-05 19:17:34.000000000 +0100
+++ /usr/sbin/makejail  2016-05-26 16:00:50.000000000 +0200
@@ -385,6 +385,9 @@
                newWorkingDir="%s/%s" % 
(config.chroot,os.path.realpath(fileDir)[1:])
                os.chdir(newWorkingDir)
                debug("   Creating '%s' as a symlink to '%s' (pwd=%s)" %
(fileName[1:],linkTarget,newWorkingDir))
+               # https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=...
+               if os.path.lexists(os.path.split(fileName)[1]):
+                       os.remove(os.path.split(fileName)[1])
                os.symlink(linkTarget,os.path.split(fileName)[1])
                os.chdir("/")
                missingFiles.append(fileName)


Kind regards
Matthias


-- System Information:
Debian Release: 8.4
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'stable-updates')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages makejail depends on:
ii  binstats  1.08-8
ii  debconf   1.5.56
ii  psmisc    22.21-2
ii  python    2.7.9-1
ii  strace    4.9-2

makejail recommends no packages.

makejail suggests no packages.

-- no debconf information

--- /usr/sbin/makejail  2012-03-05 19:17:34.000000000 +0100
+++ /usr/sbin/makejail  2016-05-26 16:00:50.000000000 +0200
@@ -385,6 +385,9 @@
                newWorkingDir="%s/%s" % 
(config.chroot,os.path.realpath(fileDir)[1:])
                os.chdir(newWorkingDir)
                debug("   Creating '%s' as a symlink to '%s' (pwd=%s)" % 
(fileName[1:],linkTarget,newWorkingDir))
+               # https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=...
+               if os.path.lexists(os.path.split(fileName)[1]):
+                       os.remove(os.path.split(fileName)[1])
                os.symlink(linkTarget,os.path.split(fileName)[1])
                os.chdir("/")
                missingFiles.append(fileName)

--- End Message ---
--- Begin Message ---
Source: makejail
Source-Version: 0.0.5-10.1

We believe that the bug you reported is fixed in the latest version of
makejail, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 825...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Diego Sarzi <diegosa...@gmail.com> (supplier of updated makejail package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 24 Jul 2019 14:47:35 -0300
Source: makejail
Architecture: source
Version: 0.0.5-10.1
Distribution: unstable
Urgency: medium
Maintainer: Javier Fernandez-Sanguino Pen~a <j...@computer.org>
Changed-By: Diego Sarzi <diegosa...@gmail.com>
Closes: 825381
Changes:
 makejail (0.0.5-10.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Fixed updating symbolic links, thanks to
     M. Buecher/Germany <maddes+deb...@maddes.net>. (Closes: #825381)
   * Using new DH level format. Consequently:
        - debian/compat: removed.
        - debian/control: changed from 'debhelper' to 'debhelper-compat' in
          Build-Depends field and bumped level to 12.
   * debian/control: bumped Standards-Version to 4.4.0.
   * debian/rules: removed obsolete option in dh_clean "-k".
Checksums-Sha1:
 6a5bd3e125a3d59a1073f1096b084b4802fdeafe 1777 makejail_0.0.5-10.1.dsc
 793144243f8d3b9305758d1f7f9d3c12df9757c5 15537 makejail_0.0.5-10.1.diff.gz
 8c46461fda8aac5d510ae9b76cca3c1f8415337a 5071 
makejail_0.0.5-10.1_source.buildinfo
Checksums-Sha256:
 6f3d1e05890c22b42a72de1203e0bbd275d940647c90b20bab1bf658f076daf8 1777 
makejail_0.0.5-10.1.dsc
 3a9226dae6f10ae3e75677483475941eba2c4a82111c05a256bbdfc774f17355 15537 
makejail_0.0.5-10.1.diff.gz
 89b6a6fe54d069165f3625a45a6ce097eaecbc15d2905b56e516b88d6b6fc392 5071 
makejail_0.0.5-10.1_source.buildinfo
Files:
 9574f6fb21b0e7ec222acdb8e850706f 1777 admin optional makejail_0.0.5-10.1.dsc
 192750df778e84e0688894eb3d069c1e 15537 admin optional 
makejail_0.0.5-10.1.diff.gz
 38e21980ee2199e73f9a2e3ad50b0669 5071 admin optional 
makejail_0.0.5-10.1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEENX3LDuyVoBrrofDS3mO5xwTr6e8FAl041dgACgkQ3mO5xwTr
6e9+ig/+K95x3wVvFkvR5BFgqAY9Re1wz5Ry8GrApUgdYdBAf7ZB3fdsJKY9k7Is
yJupox+8hjFFvpuTwd4SMuiSps44SsQXzyz7leD2AQnNwETtWqeexHPFd3AFpuxW
D64l5BVZOTDsU594z62h5Qz4rk6VsNMUb7UzZAj6cBp9uu/HDhM7thmJzuc3IFMP
DLGlVtJ9oJVohQkD/18MTQMMiE+WcTLp8M1V0Oqh0Nu0/kP2faqN6fYY0l6nHvDY
zJ3TWF8P1q6umoMWy/hUHN2yJSISiAW2RYAwXTDTlCwvJR2nmGjq+SmccCVi1AI6
TYkVCLCFTaU4p2cPVFCIb2FCdWd6NHa20l7rHY8JfgV4z77b8N1pDetZ2vdV+9Zj
36m9EfOwYb9xRUOTno7Z+UBJ4/BHpQbeWCQjpmkASwYv/tDS4gFwA6BI+oMqooAU
FkxuGpDv9alQqZiiGQWLodzxJZWPmQ/5T8FmTF6finFoC+EyZI50G7xf1mkvyEzN
P4l1CxbxrM1nd7WOzn1OBu8GldIPBBrbgVzV9d5amIFs3/J0VQMVQENei1Qw5cmn
u6SQS45litKG77bPXCtnOMVqJn933OSJ6FA3XWK2b38ZBLI5c0+OhZ2DRR9ZLQWR
/HYIceGgMrWe4kek8thx8yyrTyw8TkZaTfC12bhbBCZu8wG+FwA=
=gvj5
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to