Your message dated Mon, 06 May 2019 11:48:47 +0000
with message-id <e1hnc6x-0004xr...@fasolo.debian.org>
and subject line Bug#928505: fixed in ruby-pygments.rb 1.2.0-4
has caused the Debian Bug report #928505,
regarding ruby-pygments.rb: FTBFS if system is fast enough
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
928505: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=928505
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: src:ruby-pygments.rb
Version: 1.2.0-3
Severity: serious
Tags: ftbfs patch

Dear maintainer:

After fixing #923986 we have now the opposite problem: There is a test
which expects a timeout!

This is how it fails now in some of my autobuilders:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --buildsystem=ruby --with ruby
   dh_update_autotools_config -i -O--buildsystem=ruby
   dh_autoreconf -i -O--buildsystem=ruby
   dh_auto_configure -i -O--buildsystem=ruby
        dh_ruby --configure
   debian/rules override_dh_auto_build
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_auto_build
        dh_ruby --build
   dh_ruby --build
# build documention
rdoc lib
Parsing sources...
 20% [ 1/ 5]  lib/pygments.rb
 40% [ 2/ 5]  lib/pygments/lexer.rb
 60% [ 3/ 5]  lib/pygments/mentos.py
 80% [ 4/ 5]  lib/pygments/popen.rb
100% [ 5/ 5]  lib/pygments/version.rb

Generating Darkfish format into /<<PKGBUILDDIR>>/doc...


  Files:       5

  Classes:     3 (2 undocumented)
  Modules:     1 (0 undocumented)
  Constants:   1 (1 undocumented)
  Attributes:  0 (0 undocumented)
  Methods:    27 (5 undocumented)

  Total:      32 (8 undocumented)
   75.00% documented

  Elapsed: 0.1s

make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_auto_test -i -O--buildsystem=ruby
        dh_ruby --test
   create-stamp debian/debhelper-build-stamp
 fakeroot debian/rules binary-indep
dh binary-indep --buildsystem=ruby --with ruby
   dh_testroot -i -O--buildsystem=ruby
   dh_prep -i -O--buildsystem=ruby
   debian/rules override_dh_auto_install
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_auto_install
        dh_ruby --install /<<PKGBUILDDIR>>/debian/ruby-pygments.rb
   dh_ruby --install

┌──────────────────────────────────────────────────────────────────────────────┐
│ Install files                                                               
 │
└──────────────────────────────────────────────────────────────────────────────┘

install -d /<<PKGBUILDDIR>>/debian/ruby-pygments.rb/usr/lib/ruby/vendor_ruby
install -D -m644 /<<PKGBUILDDIR>>/lib/pygments.rb 
/<<PKGBUILDDIR>>/debian/ruby-pygments.rb/usr/lib/ruby/vendor_ruby/pygments.rb
install -D -m644 /<<PKGBUILDDIR>>/lib/pygments/version.rb 
/<<PKGBUILDDIR>>/debian/ruby-pygments.rb/usr/lib/ruby/vendor_ruby/pygments/version.rb
install -D -m644 /<<PKGBUILDDIR>>/lib/pygments/mentos.py 
/<<PKGBUILDDIR>>/debian/ruby-pygments.rb/usr/lib/ruby/vendor_ruby/pygments/mentos.py
install -D -m644 /<<PKGBUILDDIR>>/lib/pygments/lexer.rb 
/<<PKGBUILDDIR>>/debian/ruby-pygments.rb/usr/lib/ruby/vendor_ruby/pygments/lexer.rb
install -D -m644 /<<PKGBUILDDIR>>/lib/pygments/popen.rb 
/<<PKGBUILDDIR>>/debian/ruby-pygments.rb/usr/lib/ruby/vendor_ruby/pygments/popen.rb
dh_installchangelogs -pruby-pygments.rb /<<PKGBUILDDIR>>/CHANGELOG.md upstream

┌──────────────────────────────────────────────────────────────────────────────┐
│ Install Rubygems integration metadata                                       
 │
└──────────────────────────────────────────────────────────────────────────────┘

generating gemspec at 
/<<PKGBUILDDIR>>/debian/ruby-pygments.rb/usr/share/rubygems-integration/all/specifications/pygments.rb-1.2.0.gemspec
/usr/bin/ruby2.5 /usr/bin/gem2deb-test-runner

┌──────────────────────────────────────────────────────────────────────────────┐
│ Checking Rubygems dependency resolution on ruby2.5                          
 │
└──────────────────────────────────────────────────────────────────────────────┘

GEM_PATH=debian/ruby-pygments.rb/usr/share/rubygems-integration/all:/var/lib/gems/2.5.0:/usr/lib/x86_64-linux-gnu/rubygems-integration/2.5.0:/usr/share/rubygems-integration/2.5.0:/usr/share/rubygems-integration/all
 ruby2.5 -e gem\ \"pygments.rb\"

┌──────────────────────────────────────────────────────────────────────────────┐
│ Run tests for ruby2.5 from debian/ruby-tests.rb                             
 │
└──────────────────────────────────────────────────────────────────────────────┘

RUBYLIB=/<<PKGBUILDDIR>>/debian/ruby-pygments.rb/usr/lib/ruby/vendor_ruby:. 
GEM_PATH=debian/ruby-pygments.rb/usr/share/rubygems-integration/all:/var/lib/gems/2.5.0:/usr/lib/x86_64-linux-gnu/rubygems-integration/2.5.0:/usr/share/rubygems-integration/2.5.0:/usr/share/rubygems-integration/all
 ruby2.5 debian/ruby-tests.rb
Loaded suite /usr/lib/ruby/vendor_ruby/rake/rake_test_loader
Started
../<<PKGBUILDDIR>>/lib/pygments/popen.rb:156: warning: File.exists? is a 
deprecated name, use File.exist? instead
...........................F
===============================================================================
Failure: test_returns_nil_on_timeout(PygmentsHighlightTest)
/<<PKGBUILDDIR>>/test/test_pygments.rb:44:in `test_returns_nil_on_timeout'
     41:   def test_returns_nil_on_timeout
     42:     large_code = REDIS_CODE * 300
     43:     code = P.highlight(large_code) # a 30 mb highlight request will 
timeout
  => 44:     assert_equal nil, code
     45:   end
     46: 
     47:   def test_highlight_works_with_null_bytes
<nil> expected but was
<"<div class=\"highlight\"><pre><span></span><span class=\"cm\">/*</span>\n" +
"<span class=\"cm\"> * Copyright (c) 2009-2010, Salvatore Sanfilippo 
&lt;antirez at gmail dot com&gt;</span>\n" +
"<span class=\"cm\"> * All rights reserved.</span>\n" +
"<span class=\"cm\"> *</span>\n" +
"<span class=\"cm\"> * Redistribution and use in source and binary forms, with 
or without</span>\n" +
"<span class=\"cm\"> * modification, are permitted provided that the following 
conditions are met:</span>\n" +
[...]

"    <span class=\"nf\">aeMain</span><span class=\"p\">(</span><span class=\"s 
s-Atom\">server</span><span class=\"p\">.</span><span class=\"s 
s-Atom\">el</span><span class=\"p\">);</span>\n" +
"    <span class=\"nf\">aeDeleteEventLoop</span><span class=\"p\">(</span><span 
class=\"s s-Atom\">server</span><span class=\"p\">.</span><span class=\"s 
s-Atom\">el</span><span class=\"p\">);</span>\n" +
"    <span class=\"s s-Atom\">return</span> <span class=\"mi\">0</span><span 
class=\"p\">;</span>\n" +
"<span class=\"p\">}</span>\n" +
"\n" +
"<span class=\"cm\">/* The End */</span>\n" +
"</pre></div>">
===============================================================================/<<PKGBUILDDIR>>/lib/pygments/popen.rb:156:
 warning: File.exists? is a deprecated name, use File.exist? instead

...................
Finished in 93.134140353 seconds.
-------------------------------------------------------------------------------
49 tests, 95 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 
notifications
97.9592% passed
-------------------------------------------------------------------------------
0.53 tests/s, 1.02 assertions/s
rake aborted!
Command failed with status (1)

Tasks: TOP => default => test
(See full trace by running task with --trace)
ERROR: Test "ruby2.5" failed. Exiting.
dh_auto_install: dh_ruby --install /<<PKGBUILDDIR>>/debian/ruby-pygments.rb 
returned exit code 1
make[1]: *** [debian/rules:22: override_dh_auto_install] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:10: binary-indep] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary-indep subprocess 
returned exit status 2
--------------------------------------------------------------------------------

I've put a bunch of failed build logs here:

https://people.debian.org/~sanvila/build-logs/ruby-pygments.rb/

We increased the timeout in debian/rules so that the unit test that
failed before did not timeout anymore, but if we also had to make this
new test to timeout deliberately, we would end up targeting a specific
CPU speed to build the package, which is precisely what we don't want
to do and the reason we increased the timeout in the first place.

I would just disable the test expecting a timeout, as in the patch below.
Sorry for not noticing this before.

Thanks.

--- a/test/test_pygments.rb
+++ b/test/test_pygments.rb
@@ -38,12 +38,6 @@ class PygmentsHighlightTest < Test::Unit::TestCase
     assert_equal 458511, code.bytesize.to_i
   end
 
-  def test_returns_nil_on_timeout
-    large_code = REDIS_CODE * 300
-    code = P.highlight(large_code) # a 30 mb highlight request will timeout
-    assert_equal nil, code
-  end
-
   def test_highlight_works_with_null_bytes
     code = P.highlight("\0hello", :lexer => 'rb')
     assert_match "hello", code

--- End Message ---
--- Begin Message ---
Source: ruby-pygments.rb
Source-Version: 1.2.0-4

We believe that the bug you reported is fixed in the latest version of
ruby-pygments.rb, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 928...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
HIGUCHI Daisuke (VDR dai) <d...@debian.org> (supplier of updated 
ruby-pygments.rb package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 06 May 2019 20:27:24 +0900
Source: ruby-pygments.rb
Binary: ruby-pygments.rb
Architecture: source all
Version: 1.2.0-4
Distribution: unstable
Urgency: high
Maintainer: Debian Ruby Extras Maintainers 
<pkg-ruby-extras-maintain...@lists.alioth.debian.org>
Changed-By: HIGUCHI Daisuke (VDR dai) <d...@debian.org>
Description:
 ruby-pygments.rb - pygments wrapper for Ruby
Closes: 928505
Changes:
 ruby-pygments.rb (1.2.0-4) unstable; urgency=high
 .
   * Team upload.
 .
   [ HIGUCHI Daisuke (VDR dai) ]
   * Disable the test expecting a timeout (Closes: #928505)
   - Thanks to Santiago Vila <sanv...@debian.org>
   * set urgency=high due to fix RC bug.
Checksums-Sha1:
 ce2c7f6b2a4f1cbc9c6034b52887d6886b3ab480 2318 ruby-pygments.rb_1.2.0-4.dsc
 6ddabec44344934ddf48cff29056b30c73916e72 8296 
ruby-pygments.rb_1.2.0-4.debian.tar.xz
 4a295578bcdd1e6b0c1bcd9e6ac2c7ef9f53ddc6 135928 
ruby-pygments.rb_1.2.0-4_all.deb
 a0fbe1060b9adefba38607c5e5be38e4aa3273cb 9279 
ruby-pygments.rb_1.2.0-4_amd64.buildinfo
Checksums-Sha256:
 e31faebd99963a07cc010919168dd54ce69e93db142eb72f87e1bc186d4a2225 2318 
ruby-pygments.rb_1.2.0-4.dsc
 57805bad4c3f08a7129c713a35365ddf5794a686e0d47aede888faae09a37f7e 8296 
ruby-pygments.rb_1.2.0-4.debian.tar.xz
 03c2e5f5175a8e1a7f42996e7328e3ac9cec5b79f41b66674e4cd5ce6813c360 135928 
ruby-pygments.rb_1.2.0-4_all.deb
 f22ac320fc6ec4877972c5e099262b87cf07094459e67e5323c4a68ff10c6263 9279 
ruby-pygments.rb_1.2.0-4_amd64.buildinfo
Files:
 4b776515473b35783a52ee73ee1f3a32 2318 ruby optional 
ruby-pygments.rb_1.2.0-4.dsc
 2492d1346b2f9e356be84d6b3358cfcf 8296 ruby optional 
ruby-pygments.rb_1.2.0-4.debian.tar.xz
 e045f94fe7e5b9bdb307ab410818ea48 135928 ruby optional 
ruby-pygments.rb_1.2.0-4_all.deb
 2e0372262aeedf8e4da69417f2c4e9b8 9279 ruby optional 
ruby-pygments.rb_1.2.0-4_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEECynYjkLmt2W42OpQeDlhndQ5Zo4FAlzQGyoACgkQeDlhndQ5
Zo7pJBAAnTHs0hUUqa9ZvqAPAey5BmwHd7ZBPx+7HVb78tZvB2Ka7MmEAICGmDAv
8e8zpZwVg5GcBlzNrbcSv+2rajrbuUaw4okQITPHaNsWCle2E/kA2vtdv9ojQIoJ
0oehJ64OtkzsJ6KeUXq5L90JgsqIlLz8bDs/jB3XylbxSXgslfitPDZZ5ldxHcYw
Z6owsj/oyXr1tT6xu9zFFVGAoMVZpcgEQb710M8Ms+4t4LS25Hyt9Ej8wTAkdsAT
wfcGDDFqtVbAZLsTSL2pJP9pbgxGO90skAy5OSgwvB/QF7+W4ILPYvbkkX1mjy7B
EDwRotK8QxCRagFpMKlOEB8keYTSR/cxfpCuk0WH6FjpeqcjPAtO81BpxXa7OWNb
kuUE6FP5wAgWfmbtF/oJKRwmT0POciwrAhDY1EWThQ/ueKdXvGi6FgYXX56bxywV
XsnDBnH3tu0aBmcpjLEVMk/kYVq7c86co6Fq0GD4pdpxmseAmCYlSuBtwpDdkX7P
4zHKXrtMKM14bvkZ2GfJiPJs1RHraQeEw4ARX7UoAmVh+aX1m1vmxcu5zyDulPYJ
vMgO3Ah02z7la+YmKz1Tc9MjADfP0kxHMl8/8jDTKcLZpn89UHEAoaWDeklLTSOT
mrcItwqf7BVruP2W5nYuBygu8u4be8XKubHvnmT/1IT50JOK0LI=
=mLKR
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to