Your message dated Wed, 10 Apr 2019 16:37:30 +0000
with message-id <e1hege6-000f3i...@fasolo.debian.org>
and subject line Bug#924291: fixed in netrek-client-cow 3.3.1-4
has caused the Debian Bug report #924291,
regarding netrek-client-cow: build can loop indefinitely on failure
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
924291: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=924291
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: netrek-client-cow
Version: 3.3.1-1
Severity: serious
Justification: breaks build infrastructure
When mkkey fails to run, netrek-client-cow has a very bad failure mode.
It loops until mkkey succeeds:
| until ./mkkey key.cow.linux "Client Of Win" "automatic packaged key"
"qu...@us.netrek.org" "netrek.org/files/COW/" "inl,standard2"; do sleep 1; done
When mkkey fails reliably and produces output, this causes the build to
run indefinitely as sbuild only abort a build that has no output for a
prologned time. This behaviour can make buildds and QA infrastructure
hang.
I suggest using a bounded loop and failing hard after a number of
attempts. That's a very simple solution to the problem at hand. For
instance:
| attempts=32; until ./mkkey ...; do attempts=$((attempts - 1)); test $attempts
-le 0 && exit 1; sleep 1; done
Furthermore I question why a key should be created at build time and
then be distributed to consumers of the package. That seems to run
counter to the concept of a "key". If the key is to protect anything, it
must not be public. Maybe the best course of action would be not
creating this key at all during build.
Helmut
--- End Message ---
--- Begin Message ---
Source: netrek-client-cow
Source-Version: 3.3.1-4
We believe that the bug you reported is fixed in the latest version of
netrek-client-cow, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 924...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Stephen Kitt <sk...@debian.org> (supplier of updated netrek-client-cow package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 10 Apr 2019 17:34:14 +0200
Source: netrek-client-cow
Binary: netrek-client-cow
Architecture: source
Version: 3.3.1-4
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <pkg-games-de...@lists.alioth.debian.org>
Changed-By: Stephen Kitt <sk...@debian.org>
Description:
netrek-client-cow - client for netrek online game
Closes: 924291
Changes:
netrek-client-cow (3.3.1-4) unstable; urgency=medium
.
* Team upload.
* Build mkkey using the build CC when cross-compiling. Closes: #924291.
Checksums-Sha1:
0246fde0be09b4c84eaebd7f977c3fc51f2fed0f 2112 netrek-client-cow_3.3.1-4.dsc
bfc53e8661c3e0ae3737ce1d55c6b7a70827ed44 7496
netrek-client-cow_3.3.1-4.debian.tar.xz
6963be60c860de472db14218f3c90ca84bce0d92 11747
netrek-client-cow_3.3.1-4_source.buildinfo
Checksums-Sha256:
4372e86724f21646c755d30775e8686b3906ef841833a8b3cac3ad4d6ad95971 2112
netrek-client-cow_3.3.1-4.dsc
41a96e0763e8fb4699bfdcd04ff8ebfdc0e70bda3c172c68b9585b45d0a30f54 7496
netrek-client-cow_3.3.1-4.debian.tar.xz
88769fcfcdba0b6be3012aa0461256a625a5e2068654158f7d85d027404aabec 11747
netrek-client-cow_3.3.1-4_source.buildinfo
Files:
d0777f5a18e44c019e0d5c071e9fb6f6 2112 games optional
netrek-client-cow_3.3.1-4.dsc
ecdda3be547b41cc362fe327509383db 7496 games optional
netrek-client-cow_3.3.1-4.debian.tar.xz
976680f4352e312c5b55068a26bd3227 11747 games optional
netrek-client-cow_3.3.1-4_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEnPVX/hPLkMoq7x0ggNMC9Yhtg5wFAlyuFMEACgkQgNMC9Yht
g5yDJA//a7YRxpW6CAVrrsaD0yq6MJiUA+dkhkaoR9mRntKtaus9T6Y4ceyj+859
qgh7DMfs/5BHOgnhII9Liosm91MObjBGndLD4fmIj5bN4Rw+xYMkHsIgBVV2Aq4a
lScUfMyr0Rj6NbYVXk98pfFin719FFwsPfSCYDSUtaq5rO6la+fxw/LqHzjotyC+
wMP3/b4Qz+dA8Nr19CmQzeGCgvR6F1AjaQVrQ4mC699DG9VrLFwuvxvz00w0Eu/s
Xv3uR8wkL1hcyNfddoE/U6cyoBs87jrkbNls5hWucgScj1bAWBPY6w2w+oIxjuO0
2eZdH1hBSt/KPuP601+55vvfCFNTYngS8YE6ObAbcJigjPHuelqHzgguS9Cigagc
HSxG7Ocq+jm4qmoyJKqmTCSGHJfc8uZ7YXNB/oGXKp2STuMAuUoVd9NZfQUdPoNU
THOCrTLnqtxQCrAEpFmOhYAK+4tgpYXg22XiYZ0A2OjsYmIlcR9SqrRLhX2IhVjE
/94/Dh4J4yidpm+2fybGFsEaEqEBHyB/zt+qhO8UTHv5vCWwZ9hLjFBh+epVLJuP
4tamNUFuivxXvzIOUshgZD1zogSpZIX8x4+UNLlHzPjIqN/hgcYNU2OcQv449xYI
aFqaGnB6ykuijLHFGI3Dsygy2DYi5r46O+6TFvxuA5+NEro/j8w=
=UDhJ
-----END PGP SIGNATURE-----
--- End Message ---
