Your message dated Tue, 09 Apr 2019 17:19:53 +0000 with message-id <e1hdupz-0005kp...@fasolo.debian.org> and subject line Bug#926720: fixed in node-miller-rabin 4.0.1-5 has caused the Debian Bug report #926720, regarding node-miller-rabin: FTBFS randomly (uses a non-prime to test the test) to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 926720: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=926720 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: src:node-miller-rabin Version: 4.0.1-4 Severity: serious Tags: ftbfs patch Dear maintainer: I tried to build this package in buster but it failed: -------------------------------------------------------------------------------- [...] debian/rules build-indep dh build-indep --with nodejs dh_update_autotools_config -i dh_autoreconf -i dh_auto_test --buildsystem=nodejs -i /bin/sh -e debian/tests/pkg-js/test Miller-Rabin 1) should test number for primality 0 passing (93ms) 1 failing 1) Miller-Rabin should test number for primality: AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value: assert(!mr.test(new bn(221))) + expected - actual -false +true at Context.<anonymous> (test/api-test.js:8:5) at callFn (/usr/lib/nodejs/mocha/lib/runnable.js:354:21) at Test.Runnable.run (/usr/lib/nodejs/mocha/lib/runnable.js:346:7) at Runner.runTest (/usr/lib/nodejs/mocha/lib/runner.js:442:10) at /usr/lib/nodejs/mocha/lib/runner.js:560:12 at next (/usr/lib/nodejs/mocha/lib/runner.js:356:14) at /usr/lib/nodejs/mocha/lib/runner.js:366:7 at next (/usr/lib/nodejs/mocha/lib/runner.js:290:14) at Immediate._onImmediate (/usr/lib/nodejs/mocha/lib/runner.js:334:5) dh_auto_test: /bin/sh -e debian/tests/pkg-js/test returned exit code 1 make: *** [debian/rules:8: build-indep] Error 1 dpkg-buildpackage: error: debian/rules build-indep subprocess returned exit status 2 -------------------------------------------------------------------------------- The failure happens randomly. Sometimes it happens, sometimes it does not, so the only recipe to reproduce it is to try many times. I've put two build logs here: https://people.debian.org/~sanvila/build-logs/node-miller-rabin/ AFAIK, this being a primality test, I assume the outcome is either "not prime" or "maybe prime", so the only way to test the test is by giving a known prime and expect "maybe prime" as output. So: Why is the test calling mr.test with 221, which is not prime? (221 = 13 x 17) And why this fails randomly? Does the test perform random calculations internally and it's therefore not deterministic? Even in such case I don't see how a non-prime like 221 may help to catch obvious errors in a test suite for a primality test. Proposed patch below. Thanks. --- a/test/api-test.js +++ b/test/api-test.js @@ -5,7 +5,6 @@ var bn = require('bn.js'); describe('Miller-Rabin', function() { it('should test number for primality', function() { this.timeout(8000); - assert(!mr.test(new bn(221))); assert(mr.test(new bn(257))); var p = new bn('dba8191813fe8f51eaae1de70213aafede8f323f95f32cff' +
--- End Message ---
--- Begin Message ---Source: node-miller-rabin Source-Version: 4.0.1-5 We believe that the bug you reported is fixed in the latest version of node-miller-rabin, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 926...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Xavier Guimard <y...@debian.org> (supplier of updated node-miller-rabin package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Tue, 09 Apr 2019 18:54:43 +0200 Source: node-miller-rabin Architecture: source Version: 4.0.1-5 Distribution: unstable Urgency: medium Maintainer: Xavier Guimard <y...@debian.org> Changed-By: Xavier Guimard <y...@debian.org> Closes: 926720 Changes: node-miller-rabin (4.0.1-5) unstable; urgency=medium . * Team upload * Update increase-timeout.patch for armhf (fixes debci) * Add patch to fix FTBFS (Closes: #926720). Thanks to Santiago Vila Checksums-Sha1: 0f2f94549aadee11c6a619a74312dc8f4abc1fd1 2182 node-miller-rabin_4.0.1-5.dsc 463baba5fb29935470371616bce673d9b1b9d037 3488 node-miller-rabin_4.0.1-5.debian.tar.xz Checksums-Sha256: 034d38271a6ce8042aacdc2bebd61b46e65779fd12ae14d3da1bd5da65d223c7 2182 node-miller-rabin_4.0.1-5.dsc 6df4e660edb4c31e6b3e7a36d803b3fd0f13cf3cac78d95821465cc9d33b421e 3488 node-miller-rabin_4.0.1-5.debian.tar.xz Files: 23b2abe5d74ae07d743add1f8a05433c 2182 javascript optional node-miller-rabin_4.0.1-5.dsc 2d2867fcf6d497979a1497579c466062 3488 javascript optional node-miller-rabin_4.0.1-5.debian.tar.xz -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEAN/li4tVV3nRAF7J9tdMp8mZ7ukFAlyszxQACgkQ9tdMp8mZ 7ulCwBAAiD2+atBwu0B7sUSxzD4VXt3t605JEtAZpB7hAeFX6KKjy3DUBqz95JXh BJ96aSTatK4wGkeSdOIZORc1sKH5hfgBC+/xhPy1/1KWNPuamvjY03+UuMBPwt96 xr60eCDtlKIRLy+zFlwNuoFNaLrXwogZNuefknLpv+/rVhbS1eHhjxorqk0SdZhJ N0vEGAu9awNm8CI18iUjAYoEtDj5sUs4W2tgf+3Kwoxvtt5k2wO/sOaiU4LqSPOx gQo9kKaj8AIkb9D2kAQrncIc0C+Kk+yLlG3riyEv9wGv6RdX0/zzEULX6BFBZFf3 9aYZ2vsZRigSSoVF4UOOTTt+4F25SZZK36FHXDsviAYLyR1xll0UhIpEB1hchyRR /kyBbSam7inTQFSgEcN+nQFDLcKIVgaLOkpNEm8nWSfK2RtawmGOJGL/JeJrlmhn RSmCyU8Fbysck49avyjmgRhY3SXn9PISkiNuU2wrG/V5uwLeRMrmemj6OLwITWlQ xkP11mriryR3cyYie9RP9fFsUd1vrfglQdUOaT9dxrfPxhk6m2tnVAyYDyOnlpi1 x3yBqAmmpZ4swjZS61RRqSQXn/SoGLxDgYf9YXoTFVjWSIuIIeqqcJYhMzeuVsvZ f9tY1M29jvt41Aqseqjdn+8VB1f8nWNdblJvi1lVLnS9kqEAysc= =TYe6 -----END PGP SIGNATURE-----
--- End Message ---
