Reply In Between Shengjing Zhu writes:
> On Tue, Mar 12, 2019 at 11:25 PM rajudev <raju...@disroot.org> wrote: >> >> >> Shengjing Zhu writes: >> >> > Hi Raju, >> >> Ni Hao :) >> > >> > This package seems problematic in other perspective, >> Indeed it is confusing. >> > >> > golang-github-data-dog-go-sqlmock-dev is already in archive, and can >> > be imported as gopkg.in/DATA-DOG/go-sqlmock.v1 or >> > github.com/DATA-DOG/go-sqlmock. >> > >> > So this package is duplicated. >> >> I think no. >> >> > >> > gopkg.in/DATA-DOG/go-sqlmock.v1 is not in >> > src:golang-github-data-dog-go-sqlmock's Go-Import-Path field, this >> > should be fixed in golang-github-data-dog-go-sqlmock. I think that's >> > why you were not aware, and upload a new one. >> I did looked at the other package and I was aware. >> >> then I looked at https://gopkg.in/DATA-DOG/go-sqlmock.v1 >> >> The upstream maintains three different versions of the same package. >> And authors of other golang packages use different versions in there code. > > the current version > + golang-gopkg-data-dog-go-sqlmock.v1-dev is 1.3.0-1 > + golang-github-data-dog-go-sqlmock-dev is 1.3.0-1 > > They are the same version, and same code. So it's duplicated. > > And as I said before, golang-github-data-dog-go-sqlmock-dev can be > used for package which imports gopkg.in/DATA-DOG/go-sqlmock.v1. > Please just think why it installs a symlink named > /usr/share/gocode/src/gopkg.in/DATA-DOG/go-sqlmock.v1. > And take prometheus-mysqld-exporter package as example, it imports > gopkg.in/DATA-DOG/go-sqlmock.v1 and build fine with > golang-github-data-dog-go-sqlmock-dev. > >> >> The efforts behind this package were made as it is a dependency for >> micro text editor, which is now in upload queue. >> >> https://ftp-master.debian.org/new/micro_1.4.1-1.html >> > > I don't see golang-gopkg-data-dog-go-sqlmock.v1-dev is in micro's > Build-Depends. Initially I got this package done as it was shown as a estimated dependency of go-colorful[1], which is a dependency of multiple packages including micro. [1] https://salsa.debian.org/libregeekingkid-guest/micro/wikis/Dependency-Tree-of-Micro so I packaged it as required. I have now checked that go-colorful builds fine with golang-github-data-dog-go-sqlmock-dev as you suggested. Hence now I agree that golang-github-data-dog-go-sqlmock.v1 should be removed instead. Thanks for pointing this out. I'll file the removal bug. > > >> >> > >> > I think file a RM request for ftp-master is the solution here. >> >> If we file an RM request for this one, it will break micro. >> >> I am open to any suggestions, or comments on the situation. >> >> ----- >> rajudev
