Package: git-daemon-run
Version: 1:2.20.1-2
Followup-For: Bug #919296

Hi!

>Severity: grave
>Justification: renders package unusable

Jonathan wrote:
>adding a Depends by git-daemon-run on
>'runit-init | runit-systemd | runit-sysv' should do the trick.

This should allow to lower the severity to non-RC: I have the same error
as the bug title but with runit-init installed git-daemon is far from being
unusable. In fact it's running as it's supposed to be despite the error. 

> Celejar wrote:
>Okay, I've installed runit-systemd:
>
>~# dpkg-reconfigure git-daemon-run
>Service git-daemon already added.
>warning: git-daemon: unable to open supervise/ok: file does not exist

disregard the warning, please test with
# sv status git-daemon
to check if git-daemon it's really not running

>Bogatov wrote:
>Dear git maintainer, you could plug this bug by adding
>`/var/lib/supervise/git-daemon' into `debian/git-daemon-run.dirs'.

Dmitry, are you sure? runsv can create the 'git-daemon' directory if 
it's not there, and a dangling symlink won't stop it.
You can do a test:
# update-service --remove /etc/sv/git-daemon
# rm -r /var/lib/supervise/git-daemon
# update-service --add /etc/sv/git-daemon
wait at least 5 seconds, than do
# sv term git-daemon

> Jonathan Nieder wrote:
> Unfortunately, this doesn't work.  /var/lib/supervise/git-daemon ought
> to contain a definition of a supervise service, whereas this produces
> an empty directory so it still fails.

Yes, as you enable a service, you have to wait at least 5 seconds before
safely sending signals with sv. See runsvdir(8), it pools every 5 seconds.
It's a flaw in runit design. 

Lorenzo


-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.20.3-van (SMP w/4 CPU cores; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: runit (via /run/runit.stopit)

Versions of packages git-daemon-run depends on:
ii  adduser  3.118
ii  git      1:2.20.1-2
ii  runit    2.1.2-25helpers1

git-daemon-run recommends no packages.

git-daemon-run suggests no packages.

-- no debconf information

Reply via email to