Your message dated Mon, 11 Mar 2019 23:22:23 +0000 with message-id <20190311232223.ga19...@espresso.pseudorandom.co.uk> and subject line Re: Bug#924356: google-authenticator: FTBFS has caused the Debian Bug report #924356, regarding google-authenticator: FTBFS to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 924356: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=924356 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Source: google-authenticator Version: 20170702-2 Severity: serious Tags: ftbfs Justification: fails to build from source (but built successfully in the past) Dear Maintainer, I do: apt-get source google-authenticator cd google-authenticator-20170702 fakeroot make -f debian/rules binary and see ... make[3]: Entering directory '/home/peterc/src/work/oauth/google-authenticator-20170702/libpam' FAIL: tests/pam_google_authenticator_unittest ================================================= google-authenticator 1.03: ./test-suite.log ================================================= # TOTAL: 1 # PASS: 0 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 .. contents:: :depth: 2 FAIL: tests/pam_google_authenticator_unittest ============================================= pam_google_authenticator_unittest: tests/pam_google_authenticator_unittest.c:335: main: Assertion `num_prompts_shown == (expected_bad_prompts_shown)' failed. Secret file "/tmp/.google_authenticator_GjoQkr" must be owned by "peterc" FAIL tests/pam_google_authenticator_unittest (exit status: 1) ============================================================================ Testsuite summary for google-authenticator 1.03 ============================================================================ # TOTAL: 1 # PASS: 0 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 ============================================================================ See ./test-suite.log Please report to hab...@google.com ============================================================================ make[3]: *** [Makefile:1283: test-suite.log] Error 1 It turns out you can't build the whole thing in one step I needed to do: make -f debian/rules binary .... create-stamp debian/debhelper-build-stamp dh_testroot -O--sourcedirectory=libpam dh_testroot: You must run this as root (or use fakeroot). make: *** [debian/rules:13: binary] Error 255 then repeat with fakeroot make -f debian/rules binary Peter C -- System Information: Debian Release: buster/sid APT prefers unstable APT policy: (990, 'unstable'), (500, 'testing'), (500, 'stable'), (500, 'oldstable') Architecture: amd64 (x86_64) Foreign Architectures: armhf, armel, i386, powerpc, arm64, riscv64 Kernel: Linux 5.0.0-rc4-00001-g4aa9fc2a435a (SMP w/8 CPU cores) Locale: LANG=en_AU.utf8, LC_CTYPE=en_AU.utf8 (charmap=UTF-8), LANGUAGE=en_AU:en (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system)
--- End Message ---
--- Begin Message ---On Tue, 12 Mar 2019 at 09:14:11 +1100, peterc wrote: > I do: > apt-get source google-authenticator > cd google-authenticator-20170702 > fakeroot make -f debian/rules binary This is not the official way to build a Debian package. It happens to work for some packages, but is not something that can be relied on. Instead of the last step, please use: dpkg-buildpackage -us -uc This will do the build step (which includes build-time tests) without pretending to be root, and then the binary step either under fakeroot or not (it depends on the package's metadata, and this particular package does need fakeroot). (Or use debuild, from the devscripts package, or sbuild, pbuilder or cowbuilder, from the packages of the same name.) I've confirmed that this package can be built successfully in current unstable by using dpkg-buildpackage (via sbuild, in my case). > pam_google_authenticator_unittest: > tests/pam_google_authenticator_unittest.c:335: main: Assertion > `num_prompts_shown == (expected_bad_prompts_shown)' failed. > Secret file "/tmp/.google_authenticator_GjoQkr" must be owned by "peterc" Files appearing to have the wrong ownership during build-time tests is a likely symptom of doing the build step as fakeroot, which is unnecessary and sometimes (as in this case) harmful. > It turns out you can't build the whole thing in one step > > I needed to do: > make -f debian/rules binary > .... > create-stamp debian/debhelper-build-stamp > dh_testroot -O--sourcedirectory=libpam > dh_testroot: You must run this as root (or use fakeroot). > make: *** [debian/rules:13: binary] Error 255 > > then repeat with > fakeroot make -f debian/rules binary This is a more complicated way to get the same practical result as building the package with dpkg-buildpackage: do the build step (including build-time tests) without using fakeroot, then do the binary step under fakeroot. Please use dpkg-buildpackage, which will do the right thing. smcv
--- End Message ---
