Your message dated Sat, 09 Mar 2019 20:41:58 +0000 with message-id <e1h2in8-000ieg...@fasolo.debian.org> and subject line Bug#924044: fixed in smcroute 2.4.2-4 has caused the Debian Bug report #924044, regarding init script does not stop the daemon to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 924044: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=924044 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: smcroute Version: 2.4.2-3 Severity: serious Tags: patch upstream Control: forwarded -1 https://github.com/troglobit/smcroute/pull/108 I am filing this bug on behalf of the current maintainer and upstream author of smcroute, Joachim Nilsson, to create the necessary visibility for an issue considered worth to be fixed for the Debian buster release. It was initially filed by Hajo Noerenberg on upstream's Github repository as pull request 108. > I'm using SMCRoute v2.4.2 (debian testing). > > The init script does not stop the daemon, an error is reported instead: > > # /etc/init.d/smcroute stop > Stopping static multicast router daemon: smcrouted /usr/sbin/smcrouted: > invalid option -- 'k' > > I think one should use smcroutectl to stop the daemon. The pull request is merged already, so the change is already part of the upstream release 2.4.4. Michacommit 6f4e2c1ce8e0f6821e5254000ed43a4fd7744782 Author: hn <h...@users.noreply.github.com> Date: Mon Jan 28 09:56:33 2019 +0100 fix init script 'stop' command diff --git a/smcroute.init b/smcroute.init old mode 100644 new mode 100755 index 00411b8..d0c7752 --- a/smcroute.init +++ b/smcroute.init @@ -18,6 +18,7 @@ PATH=/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin DAEMON=/usr/sbin/smcrouted +DAEMONCTL=/usr/sbin/smcroutectl DAEMON_OPTS= NAME=smcrouted DESC="static multicast router daemon" @@ -50,7 +51,7 @@ stop() { local error local result log_begin_msg "Stopping $DESC: $NAME" - error=$($DAEMON -k 2>&1) + error=$($DAEMONCTL kill 2>&1) result=$? log_progress_msg ${error#ERRO: } log_end_msg $result
--- End Message ---
--- Begin Message ---Source: smcroute Source-Version: 2.4.2-4 We believe that the bug you reported is fixed in the latest version of smcroute, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 924...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Joachim Nilsson <troglo...@gmail.com> (supplier of updated smcroute package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Thu, 07 Mar 2019 06:40:19 +0100 Source: smcroute Architecture: source Version: 2.4.2-4 Distribution: unstable Urgency: medium Maintainer: Joachim Nilsson <troglo...@gmail.com> Changed-By: Joachim Nilsson <troglo...@gmail.com> Closes: 921577 924044 Changes: smcroute (2.4.2-4) unstable; urgency=medium . * Import upstream fix for malfunctioning 'stop' command to init script, closes: #924044 * Import upstream fix to allow same outbound interface as inbound when routing. This is slightly hairy, but previous releases of SMCRoute supported this and the unit tests rely on this to work * Fix unit tests, with upstream and test setup fixes, closes: #921577 * Bump Standards-Version to 4.3.0, no changes needed * Use debhelper maintscript to relocate old /etc/startup.sh script to /etc/smcroute. Fixes an outstanding lintian warning Checksums-Sha1: f83f4779755ad02795a6ddebf8a6f66ae5d3ffcc 1928 smcroute_2.4.2-4.dsc d75cfa43d6f44bc03b17303638590fc29a26a35b 11256 smcroute_2.4.2-4.debian.tar.xz 8989ff4d153cc4927704fc2faedd1dec6a40916c 5597 smcroute_2.4.2-4_source.buildinfo Checksums-Sha256: 05dace57c40cbfa5078feb3d32f08bf5a115f99857075f815848db88b762701e 1928 smcroute_2.4.2-4.dsc 76da2be3e1bae8209411836a0a4f6647382acd38662e713d67d45d7d8c509d0b 11256 smcroute_2.4.2-4.debian.tar.xz 5968b4ebeb4024ac16a3a3251ffc6eb6cb40cf174c1ed988d392c38db9575a28 5597 smcroute_2.4.2-4_source.buildinfo Files: 6ed892ae7c43177b309e6e4f44f6eb25 1928 net optional smcroute_2.4.2-4.dsc 313ebb450a47359f522e8c327ce7d686 11256 net optional smcroute_2.4.2-4.debian.tar.xz 0bbbbd4c70e2454104c01d2a216704c1 5597 net optional smcroute_2.4.2-4_source.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEo+u0H8Wr1nXO5BxF6mymuVG4UTkFAlyEGWgACgkQ6mymuVG4 UTnj8A/+MFIS9aKucY5UoKD5CeBFJ+C61/mxBi8OkAeYaX8hvoAu8Fn6HnyBN6Eu fX51kWuKfNolit2LQN/ekFEv8nuY9/E94kaiyIhWXvogCChAHx2xKeGKxbyeqYOm OpiiaRhUftCOYdxCiC5SPlpNK27o0mCUIepMAdm3Xe5vDryv+GFtem7U9V6d9AFb 6dCwwE8lqLAigzWRMML3I37KhionWyLMt8Po6jV3Hb2KqPrldK9tqT7qH5UK1UG2 xyslpazFbr879xl/CZvmG44A6USEoGqEO6rb5QOI6lRa7dYpOaKsvNeGaz3mF5d3 Lu04rslXaw10w5TsdHN6zD1M9XLXsehjLachjnC64EspgmolrZ3zobw6oTAS7MLD NG+KKNTzLGC+IlbM55FAG26CTNhkXqSHPUTQoURtwAW/v9PEpbbkPQyK/BIn9ntC b+F84QQRnYry7ic4WATLQtxLsPmdpVO7tbdolSRO4ak6j26S+vImJRYBBfyTV5zp w0GQcqU1cY7bsF8XFk+9C2AQwUVI2XkYtGcG9ezKv5u3tnfQmaRaLrYy2eyeUlBE tjP0RP+xYEIjvweOdgbIxk2GxJZAv7kJp9Lzi/nxaGSsNm0gZ+FRTuTJd4rm6hHu 1Z01Z7fVlW09HEP1tcp042U5Su6ZrXhj8gf+KBDAyCOyEUSGRts= =j/PO -----END PGP SIGNATURE-----
--- End Message ---
