Your message dated Thu, 14 Feb 2019 15:19:43 +0000 with message-id <e1guinf-0003ep...@fasolo.debian.org> and subject line Bug#884721: fixed in rsyncrypto 1.14-1.1 has caused the Debian Bug report #884721, regarding rsyncrypto: Segmentation fault with --delete to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 884721: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=884721 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: rsyncrypto Version: 1.13-1 Severity: serious Tags: patch upstream Justification: crash on basic functionality Dear maintainer, I have recently been exposed to rsyncrypto through a client of my work's, and have encountered a crash when using rsyncrypto to refresh an encrypted directory tree with --delete enabled. This happens because of an infinite recursion in autofd::unlink(): https://sources.debian.org/src/rsyncrypto/1.13-1/autofd.h/#L217 static int unlink(const char *pathname) { bool success=unlink( pathname )==0; [...] } I came up with the following patch which simply calls unlink() in the top scope. This seems to fix the problem for me: --- rsyncrypto-1.14.orig/autofd.h +++ rsyncrypto-1.14/autofd.h @@ -216,7 +216,7 @@ public: // unless it failed with ENOENT - the file already doesn't exist static int unlink(const char *pathname) { - bool success=unlink( pathname )==0; + bool success=::unlink( pathname )==0; if( !success && errno!=ENOENT ) throw rscerror("Erasing file", errno, pathname ); This affects 1.13-1 and 1.14-1 in Debian in the same way. Please let me know if you would like any further information. Best regards, Chris -- System Information: Debian Release: buster/sid APT prefers unstable-debug APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'testing'), (100, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 4.13.0-1-amd64 (SMP w/8 CPU cores) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages rsyncrypto depends on: ii gzip 1.6-5+b1 pn libargtable2-0 <none> ii libc6 2.25-3 ii libgcc1 1:7.2.0-17 ii libssl1.1 1.1.0g-2 ii libstdc++6 7.2.0-17 Versions of packages rsyncrypto recommends: ii rsync 3.1.2-2 rsyncrypto suggests no packages.
--- End Message ---
--- Begin Message ---Source: rsyncrypto Source-Version: 1.14-1.1 We believe that the bug you reported is fixed in the latest version of rsyncrypto, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 884...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Sascha Steinbiss <sa...@debian.org> (supplier of updated rsyncrypto package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Sat, 09 Feb 2019 15:11:50 +0100 Source: rsyncrypto Binary: rsyncrypto rsyncrypto-dbgsym Architecture: source amd64 Version: 1.14-1.1 Distribution: unstable Urgency: medium Maintainer: Shachar Shemesh <shac...@debian.org> Changed-By: Sascha Steinbiss <sa...@debian.org> Description: rsyncrypto - rsync friendly encryption Closes: 884721 912051 Changes: rsyncrypto (1.14-1.1) unstable; urgency=medium . * Non-maintainer upload. * Add explicit build dependency on automake-1.15. Closes: #912051 * Fix segfault with --delete. Thanks to Chris Boot for the patch. Closes: #884721 Checksums-Sha1: 8fa473d52a2309d8670bc6b982cded2898601a3c 2054 rsyncrypto_1.14-1.1.dsc 34f34b27f9e5165b79e32cc83def402069f905ff 29764 rsyncrypto_1.14-1.1.debian.tar.xz 9c7113d1dc11f9760110c9bb5cb7de5cfbadd9fc 620380 rsyncrypto-dbgsym_1.14-1.1_amd64.deb 8d8ea8343ea0e173f0d298cbaa141c9419cbb6b3 5673 rsyncrypto_1.14-1.1_amd64.buildinfo 70b6a087d4977575060ae7fa746ed4d9f47e4c29 302816 rsyncrypto_1.14-1.1_amd64.deb Checksums-Sha256: 50a9d944502b85abe3d508c6d922ddb713d5eccedf3b5e497d1c593c2cc123bc 2054 rsyncrypto_1.14-1.1.dsc 6feb6becf8000347dcb2aff2663c11a9037b897a3cff53ca9109ecadfaae3fb4 29764 rsyncrypto_1.14-1.1.debian.tar.xz 4e6ca49d6611832a64d983b135a4d8f99021d134191df0dad4224c17653b65fa 620380 rsyncrypto-dbgsym_1.14-1.1_amd64.deb 5d43962096683b3d26b7be6d243de99c46c19b616c37e994c0113e451c47abd9 5673 rsyncrypto_1.14-1.1_amd64.buildinfo df1cf1874756655da67a7d2228e9129cfb842211c2733024a629f819c8517e2b 302816 rsyncrypto_1.14-1.1_amd64.deb Files: e3002957caa7ad1f29abbd64b4e1a4bd 2054 utils optional rsyncrypto_1.14-1.1.dsc eef5de5e8a8187c5888914a24568c45f 29764 utils optional rsyncrypto_1.14-1.1.debian.tar.xz 3f73eb7eb8fc1dfb26b2ac1fb2eb8b02 620380 debug optional rsyncrypto-dbgsym_1.14-1.1_amd64.deb 880c51b8be643938ef9b89b504ddc045 5673 utils optional rsyncrypto_1.14-1.1_amd64.buildinfo c25995c55f2e62255aa5576c8e20eecd 302816 utils optional rsyncrypto_1.14-1.1_amd64.deb -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEWzS6WqtVB+kDQm6F6NN64vCfSHIFAlxe5ysACgkQ6NN64vCf SHL1EQ//SLzJiTthSGLszTWHkqf5vuvgoVVQSG+dIDelqD07PrZ+KbBVVsgrw7gJ NpP8smwxUKmMQkRWRUYbGl3W9aP0LsRgrXWCxdNc7RBVWHEAWP2xBrPjKmwwdi2E +EnldyiEz8BD94xQ+UvMmE1/6Sw0ot6kiPrbiXLwYmbxUUnITO9jpAvWV4jCTTCI oBePV5ws3xy/cN9DW2gw3zFTHUuI1Dm9Viwrdee41liykaVrFZebv+l2emi7Oc1k vdA1p8mPZEy2Ur5s4oUDEY6Tdf4G3X/2nsXP1mhxqw2A018ZWv0Rsj1VTjQSfsP1 bEQ4S68FRN9wUyH6Wt/qs+BiO4RXhsR73m542UKmsChDzCMcwqQpNV+G+htKG6+n ybrrlNG1fdBPsA15ysS6lAjSgKhCyHSg/75WP/nFcEH3F+ToXXvqTJ6opYg8/Q4A YNDSAvMqpOx77W5epG627holL2qRSLBWv3AnNti0LO/b6vSUiMA2aXdS3DtGpgej jTL0D6AEqyphDOWTcPYVGI2UJ33D7QyEfR56jgHEz8WD0KfL6ilQKXCZh3F8rwef +KiTnShkyDTWtiocWNIc31LTdg/ulscn1MyU3doTLUicPGNMzMcKPTDpEp3Af8Mg Jm69fGXxZ12Y2rQaMuj9QDN49PpT7JCvpjhHinIqx7RwUwNDhl0= =MpIt -----END PGP SIGNATURE-----
--- End Message ---
