Package: ntopng
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu disco ubuntu-patch
Version: 3.8+dfsg1-2
Severity: serious
Tags: patch
Hello, I'm filing this bug as serious, even if the build failure is not
experienced in Debian builds, just by luck.
Problem is that the embedded mongoose library, directly uses ssl features, but
the package lacks of a libssl-dev dependency
For some luck, mariadb-default pulls libssl-dev and this is why you are not
experiencing the build failure, but this is a bug
since mariadb might drop that dependency in the future, or people might have a
default, different sql implementation on their system.
Trivial patch:
diff -Nru ntopng-3.8+dfsg1/debian/changelog ntopng-3.8+dfsg1/debian/changelog
--- ntopng-3.8+dfsg1/debian/changelog 2019-01-26 08:36:22.000000000 +0000
+++ ntopng-3.8+dfsg1/debian/changelog 2019-01-27 19:36:30.000000000 +0000
@@ -1,3 +1,9 @@
+ntopng (3.8+dfsg1-2ubuntu1) disco; urgency=medium
+
+ * Build depend on libssl-dev too, used in the build process (Closes: #-1)
+
+ -- Gianfranco Costamagna <locutusofb...@debian.org> Sun, 27 Jan 2019
20:36:30 +0100
+
ntopng (3.8+dfsg1-2) unstable; urgency=medium
* Fix missing space in postinst migration script (Closes: #920281).
diff -Nru ntopng-3.8+dfsg1/debian/control ntopng-3.8+dfsg1/debian/control
--- ntopng-3.8+dfsg1/debian/control 2019-01-22 01:55:35.000000000 +0000
+++ ntopng-3.8+dfsg1/debian/control 2019-01-27 19:36:28.000000000 +0000
@@ -20,6 +20,7 @@
libpcap-dev,
librrd-dev,
libsqlite3-dev,
+ libssl-dev,
libzmq3-dev,
node-source-map,
node-uglify,
Example of build failure:
https://launchpadlibrarian.net/408670618/buildlog_ubuntu-disco-amd64.ntopng_3.8+dfsg1-2_BUILDING.txt.gz
g++ -g -Wall -I/<<BUILDDIR>>/ntopng-3.8+dfsg1
-I/<<BUILDDIR>>/ntopng-3.8+dfsg1/include -I/usr/local/include
-D_FILE_OFFSET_BITS=64 -I/usr/include/hiredis -I/usr/include/hiredis
-I/<<BUILDDIR>>/ntopng-3.8+dfsg1/third-party/mongoose -I/usr/include/json-c
-I/usr/include/ndpi -I/usr/include/lua5.3 -I/usr/include/mysql -Wdate-time
-D_FORTIFY_SOURCE=2 -I/<<BUILDDIR>>/ntopng-3.8+dfsg1
-I/<<BUILDDIR>>/ntopng-3.8+dfsg1/include -I/usr/local/include
-I/<<BUILDDIR>>/ntopng-3.8+dfsg1/third-party/http-client-c/src/
-I/usr/include/openssl -DDATA_DIR='"/usr/share"'
-I/<<BUILDDIR>>/ntopng-3.8+dfsg1/third-party/libgeohash
-I/<<BUILDDIR>>/ntopng-3.8+dfsg1/third-party/patricia -g -O2
-fdebug-prefix-map=/<<BUILDDIR>>/ntopng-3.8+dfsg1=. -fstack-protector-strong
-Wformat -Werror=format-security -c src/HTTPserver.cpp -o src/HTTPserver.o
In file included from src/HTTPserver.cpp:25:
src/../third-party/mongoose/mongoose.c:362:10: fatal error: openssl/ssl.h: No
such file or directory
#include <openssl/ssl.h>
^~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [Makefile:145: src/HTTPserver.o] Error 1
make[2]: Leaving directory '/<<BUILDDIR>>/ntopng-3.8+dfsg1'
dh_auto_build: make -j1 returned exit code 2
make[1]: *** [debian/rules:21: override_dh_auto_build] Error 2
make[1]: Leaving directory '/<<BUILDDIR>>/ntopng-3.8+dfsg1'
make: *** [debian/rules:11: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
--------------------------------------------------------------------------------
thanks for caring,
Gianfranco
