Your message dated Sat, 22 Apr 2006 14:18:06 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#339469: fixed in helix-player 1.0.7-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: helix-player
Version: 1.0.6-2
Severity: serious
Justification: no longer builds from source
Tags: patch

Hi,

I just had a look at the helix-player package and noticed that it failed
to build on all architectures. Each time it seems to be a different
error. Btw, in Bug #330337 you list amd64 as supported, but not ia64. Is
there a reason for that? 
For the sparc and powerpc the errors are listed below. sparc seems to be
on a par with other architectures, while powerpc seems to be special
since it crashed due to a python crash. A patch for this issue is
attached and the package builds fine with the patch applied here.

sparc:
> entering directory audio/device
> UNIXCompile(audio/device): generating makefiles
> Warning: Missing BIF source dep 'client_audiosvc' (include path 
> ../../client/audiosvc/pub)
> UNIXCompile(audio/device): making depend
> UNIXCompile(audio/device): making copy
> ERROR: UNIXCompile(audio/device) ERROR: Make failed.
> 
> --- Build System Error ------------------------------------
> Make failed.
> -----------------------------------------------------------
> 
> leaving directory /build/buildd/helix-player-1.0.6/./audio/device
> [...]
> entering directory video/site
> UNIXCompile(video/site): generating makefiles
> UNIXCompile(video/site): making depend
> UNIXCompile(video/site): making copy
> ERROR: UNIXCompile(video/site) ERROR: Make failed.
> 
> --- Build System Error ------------------------------------
> Make failed.
> -----------------------------------------------------------
> 
> leaving directory /build/buildd/helix-player-1.0.6/./video/site

Then there are similar messages for client/core, player/app/gtk, and
player/installer/archive. Eventually the build fails with 

> g++-3.4 --permissive -pipe -fsigned-char -O2   -I../../common/runtime/pub 
> -I/usr/X11R6/include -Ipub/platform/unix -I../../common/system/pub/platform 
> -I../../client/audiosvc/pub
> -I../../common/include -I../../common/container/pub -I../../common/util/pub 
> -I../../common/system/pub -I../../common/dbgtool/pub -I../include -I./pub -I. 
> -include rel/audio_device_ribodefs.h -fPIC
> -DPIC -o rel/obj/platform/unix/audlinux_oss.o -c 
> platform/unix/audlinux_oss.cpp
> In file included from platform/unix/audlinux_oss.cpp:64:
> pub/platform/unix/audlinux_oss.h:63:31: machine/soundcard.h: No such file or 
> directory
> platform/unix/audlinux_oss.cpp: In member function `virtual HX_RESULT 
> CAudioOutLinux::_SetDeviceConfig(const HXAudioFormat*)':
> platform/unix/audlinux_oss.cpp:142: error: `SNDCTL_DSP_SETFRAGMENT' 
> undeclared (first use this function)
> platform/unix/audlinux_oss.cpp:142: error: (Each undeclared identifier is 
> reported only once for each function it appears in.)
> platform/unix/audlinux_oss.cpp:156: error: `AFMT_S16_NE' undeclared (first 
> use this function)
> platform/unix/audlinux_oss.cpp:160: error: `AFMT_U8' undeclared (first use 
> this function)
> platform/unix/audlinux_oss.cpp:163: error: `SNDCTL_DSP_SETFMT' undeclared 
> (first use this function)
> platform/unix/audlinux_oss.cpp:205: error: `SOUND_PCM_WRITE_CHANNELS' 
> undeclared (first use this function)
> platform/unix/audlinux_oss.cpp:216: error: `SOUND_PCM_WRITE_RATE' undeclared 
> (first use this function)
> platform/unix/audlinux_oss.cpp:263: error: `audio_buf_info' undeclared (first 
> use this function)
> platform/unix/audlinux_oss.cpp:263: error: expected `;' before 
> "getYourInfoHere"
> platform/unix/audlinux_oss.cpp:269: error: `SNDCTL_DSP_GETOSPACE' undeclared 
> (first use this function)
> platform/unix/audlinux_oss.cpp:269: error: `getYourInfoHere' undeclared 
> (first use this function)
> platform/unix/audlinux_oss.cpp: In member function `void 
> CAudioOutLinux::_SyncUpTimeStamps(ULONG32)':
> platform/unix/audlinux_oss.cpp:306: error: `SNDCTL_DSP_GETODELAY' undeclared 
> (first use this function)
> platform/unix/audlinux_oss.cpp: In member function `virtual HX_RESULT 
> CAudioOutLinux::_Reset()':
> platform/unix/audlinux_oss.cpp:491: error: `SOUND_PCM_RESET' undeclared 
> (first use this function)
> platform/unix/audlinux_oss.cpp: In member function `virtual UINT16 
> CAudioOutLinux::_GetVolume() const':
> platform/unix/audlinux_oss.cpp:508: error: `SOUND_MIXER_PCM' undeclared 
> (first use this function)
> platform/unix/audlinux_oss.cpp:508: error: `MIXER_READ' undeclared (first use 
> this function)
> platform/unix/audlinux_oss.cpp: In member function `virtual HX_RESULT 
> CAudioOutLinux::_SetVolume(UINT16)':
> platform/unix/audlinux_oss.cpp:530: error: `SOUND_MIXER_PCM' undeclared 
> (first use this function)
> platform/unix/audlinux_oss.cpp:530: error: `MIXER_WRITE' undeclared (first 
> use this function)
> platform/unix/audlinux_oss.cpp: In member function `virtual HX_RESULT 
> CAudioOutLinux::_Drain()':
> platform/unix/audlinux_oss.cpp:549: error: `SNDCTL_DSP_SYNC' undeclared 
> (first use this function)
> platform/unix/audlinux_oss.cpp: In member function `virtual HX_RESULT 
> CAudioOutLinux::_GetRoomOnDevice(ULONG32&) const':
> platform/unix/audlinux_oss.cpp:610: error: `audio_buf_info' undeclared (first 
> use this function)
> platform/unix/audlinux_oss.cpp:610: error: expected `;' before "stBuffInfo"
> platform/unix/audlinux_oss.cpp:620: error: `SNDCTL_DSP_GETOSPACE' undeclared 
> (first use this function)
> platform/unix/audlinux_oss.cpp:620: error: `stBuffInfo' undeclared (first use 
> this function)
> platform/unix/audlinux_oss.cpp: In member function `virtual HX_RESULT 
> CAudioOutLinux::_CheckFormat(const HXAudioFormat*)':
> platform/unix/audlinux_oss.cpp:655: error: `SOUND_PCM_WRITE_RATE' undeclared 
> (first use this function)
> platform/unix/audlinux_oss.cpp:689: error: `SOUND_PCM_WRITE_CHANNELS' 
> undeclared (first use this function)
> platform/unix/audlinux_oss.cpp:701: error: `SNDCTL_DSP_SETFMT' undeclared 
> (first use this function)
> platform/unix/audlinux_oss.cpp: In member function `virtual HX_RESULT 
> CAudioOutLinux::_CheckSampleRate(ULONG32)':
> platform/unix/audlinux_oss.cpp:734: error: `SOUND_PCM_WRITE_RATE' undeclared 
> (first use this function)
> make[2]: *** [rel/obj/platform/unix/audlinux_oss.o] Error 1
> make[2]: Leaving directory `/build/buildd/helix-player-1.0.6/audio/device'
> make[1]: *** [all] Error 2
> make[1]: Leaving directory `/build/buildd/helix-player-1.0.6'
> make: *** [build-stamp] Error 2


powerpc:

> gcc version 3.4.5 20051015 (prerelease) (Debian 3.4.4-9)
> 
> Recompling mkdepend: gcc-3.4 -O2 -o
> /build/buildd/helix-player-1.0.6/build/bin/mkdepend.bin
> /build/buildd/helix-player-1.0.6/build/lib/mkdepend.c
> 
> 
> --- Build System Error ------------------------------------
> EEK!  You've found a build system bug!
> -----------------------------------------------------------
> --- Python Traceback --------------------------------------
> ------------------------------------
> Traceback (most recent call last):
>   File "/build/buildd/helix-player-1.0.6/build/lib/buildui.py", line 62, in 
> run
>     buildmenu.run(force_menu_mode)
>   File "/build/buildd/helix-player-1.0.6/build/lib/buildmenu.py", line 894, 
> in run
>     command_line_args()
>   File "/build/buildd/helix-player-1.0.6/build/lib/buildmenu.py", line 155, 
> in command_line_args
>     invoke_buildsystem(arg_list)
>   File "/build/buildd/helix-player-1.0.6/build/lib/buildmenu.py", line 105, 
> in invoke_buildsystem
>     app = buildapp.RunBuild(arg_list)
>   File "/build/buildd/helix-player-1.0.6/build/lib/buildapp.py", line 90, in 
> RunBuild
>     app.main()
>   File "/build/buildd/helix-player-1.0.6/build/lib/buildapp.py", line 160, in 
> main
>     self.run()
>   File "/build/buildd/helix-player-1.0.6/build/lib/buildapp.py", line 341, in 
> run
>     self.build_info()
>   File "/build/buildd/helix-player-1.0.6/build/lib/buildapp.py", line 1392, 
> in build_info
>     umake.Umake( ["__print_version_and_exit__"] )
>   File "/build/buildd/helix-player-1.0.6/build/umake/umake.py", line 2761, in 
> Umake
>     RunUmake(um_opts)
>   File "/build/buildd/helix-player-1.0.6/build/umake/umake.py", line 2693, in 
> RunUmake
>     apply(func, args)
>   File "linux-2.2-libc6-gcc32-powerpc.cf", line 118, in verify_gcc_callback
> NameError: global name 'cxxmajor' is not defined
> -----------------------------------------------------------

>From a short look I get the impression that you have a hell of code
duplication in the .cf files files and there happened some Cut'n'Paste errors.
The attached patch fixes them for ppc and makes the package build here
on my PowerBook.
The version detection for gcc doesn't really work that way:
 **WARNING**
gcc version is 3.4.5, not >= 3.* as expected.
g++ version is 3.4.5, not >= 3.* as expected.
But you can easily use the code from sysinfo.py for proper detection. To
avoid confusion like that you should really clean up the tons of code
duplication.

Thanks,

Wolfi

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: powerpc (ppc)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.13-wjq
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL 
set to en_US.UTF-8)
--- build/umakecf/linux-2.2-libc6-gcc32-powerpc.cf.orig 2005-11-16 
14:39:32.000000000 +0100
+++ build/umakecf/linux-2.2-libc6-gcc32-powerpc.cf      2005-11-16 
14:41:12.000000000 +0100
@@ -107,9 +107,9 @@
         ccmajor=0
 
     try:
-        ccxmajor=int(string.split(ccxver,".",1))
+        cxxmajor=int(string.split(cxxver,".",1))
     except:
-        ccxmajor=0
+        cxxmajor=0
         
     w=[]
     if ccmajor < 3:

--- End Message ---
--- Begin Message ---
Source: helix-player
Source-Version: 1.0.7-1

We believe that the bug you reported is fixed in the latest version of
helix-player, which is due to be installed in the Debian FTP archive:

helix-player_1.0.7-1.diff.gz
  to pool/main/h/helix-player/helix-player_1.0.7-1.diff.gz
helix-player_1.0.7-1.dsc
  to pool/main/h/helix-player/helix-player_1.0.7-1.dsc
helix-player_1.0.7-1_i386.deb
  to pool/main/h/helix-player/helix-player_1.0.7-1_i386.deb
helix-player_1.0.7.orig.tar.gz
  to pool/main/h/helix-player/helix-player_1.0.7.orig.tar.gz
mozilla-helix-player_1.0.7-1_i386.deb
  to pool/main/h/helix-player/mozilla-helix-player_1.0.7-1_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Daniel Baumann <[EMAIL PROTECTED]> (supplier of updated helix-player package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Wed, 19 Apr 2006 07:47:00 +0100
Source: helix-player
Binary: mozilla-helix-player helix-player
Architecture: source i386
Version: 1.0.7-1
Distribution: unstable
Urgency: high
Maintainer: Daniel Baumann <[EMAIL PROTECTED]>
Changed-By: Daniel Baumann <[EMAIL PROTECTED]>
Description: 
 helix-player - the helix audio and video player
 mozilla-helix-player - the helix audio and video player (browser plugin)
Closes: 339469 358754
Changes: 
 helix-player (1.0.7-1) unstable; urgency=high
 .
   * New upstream release:
     - fixes multiple heap-based buffer overflows adressed in CVE 2005-2922
       (Closes: #358754).
     - some buildsystem fixes (Closes: #339469).
Files: 
 d79bdd12a6320f064b9ed3c164488233 864 graphics optional helix-player_1.0.7-1.dsc
 a10168bf83e6edbbc8bc51923554fd60 18584434 graphics optional 
helix-player_1.0.7.orig.tar.gz
 893f8e96caf8a2c7c474b257ecfda880 11350 graphics optional 
helix-player_1.0.7-1.diff.gz
 840f2d83136124626dbffb931ac509b2 4170220 graphics optional 
helix-player_1.0.7-1_i386.deb
 6a89e9144999f92058baf642a77cdf07 48852 web optional 
mozilla-helix-player_1.0.7-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQFESnbAxa93SlhRC1oRAlXwAJ9dWxVSh9FMW3eReP5pf27GRA2E5QCeKF7s
jDEED5Zj2rKXx/Ax4dsHkJM=
=MYRg
-----END PGP SIGNATURE-----


--- End Message ---

Reply via email to