Your message dated Sat, 19 Jan 2019 22:49:46 +0000
with message-id <e1gkzqw-000epl...@fasolo.debian.org>
and subject line Bug#865955: fixed in odin 2.0.3-1
has caused the Debian Bug report #865955,
regarding odin: FTBFS with dcmtk 3.6.1~20170228-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
865955: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=865955
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: odin
Version: 2.0.3-0.1
Severity: serious
Tags: patch
Justification: FTBFS
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu artful ubuntu-patch

The odin package FTBFS in unstable with the new dcmtk:

/usr/bin/make  check-TESTS
make[4]: Entering directory '/tmp/odin-2.0.3'
make[5]: Entering directory '/tmp/odin-2.0.3'
FAIL: cmdline-utils/odintestsuite
============================================================================
Testsuite summary for odin 2.0.3
============================================================================
# TOTAL: 1
# PASS:  0
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0
============================================================================
See ./test-suite.log
============================================================================
Makefile:711: recipe for target 'test-suite.log' failed
make[5]: *** [test-suite.log] Error 1

And test-suite.log shows:

E: DcmDataDictionary: Cannot open file: /usr/share/libdcmtk8/dicom.dic
FileIO    |ERROR: DicomFormat.DicomFormat::write : No data dictionary loaded, 
check environment variable DCMDICTPATH
UnitTest  |ERROR: FileIO dcm.check : simple autowrite failed
UnitTest  |ERROR: check_all : Test of FileIO dcm failed

Unfortunately, the path to the dictionary changes for each upstream ABI
change; where it was previously in /usr/share/libdcmtk8, it's now in
/usr/share/libdcmtk11.  

I've applied the attached patch to odin in Ubuntu, which, provided dcmtk
continues to follow the same convention for its dictionary paths, should be
future proof against further changes.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slanga...@ubuntu.com                                     vor...@debian.org
diff -Nru odin-2.0.3/debian/rules odin-2.0.3/debian/rules
--- odin-2.0.3/debian/rules     2016-07-04 09:40:03.000000000 -0700
+++ odin-2.0.3/debian/rules     2017-06-25 19:27:02.000000000 -0700
@@ -3,6 +3,8 @@
 DPKG_EXPORT_BUILDFLAGS = 1
 include /usr/share/dpkg/buildflags.mk
 
+DCMMAJOR := $(shell readlink -f /usr/lib/libdcmimgle.so | cut -f3 -d.)
+
 # one ring to rule them all ...
 %:
        dh $@ --with autoreconf
@@ -28,7 +30,7 @@
 
 # there is also a 'test' target that doesn't do the right thing
 override_dh_auto_test:
-       DCMDICTPATH=/usr/share/libdcmtk8/dicom.dic $(MAKE) check
+       DCMDICTPATH=/usr/share/libdcmtk$(DCMMAJOR)/dicom.dic $(MAKE) check
 
 # shared libs in odin package a only for private use
 override_dh_makeshlibs:

--- End Message ---
--- Begin Message ---
Source: odin
Source-Version: 2.0.3-1

We believe that the bug you reported is fixed in the latest version of
odin, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 865...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Tille <ti...@debian.org> (supplier of updated odin package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 19 Jan 2019 18:18:18 +0100
Source: odin
Binary: odin mitools libodin-dev
Architecture: source
Version: 2.0.3-1
Distribution: unstable
Urgency: medium
Maintainer: NeuroDebian Team <t...@neuro.debian.net>
Changed-By: Andreas Tille <ti...@debian.org>
Description:
 libodin-dev - static libraries and header for ODIN sequences
 mitools    - view, convert and perform basic maths with medical image datasets
 odin       - develop, simulate and run magnetic resonance sequences
Closes: 865955 909363
Changes:
 odin (2.0.3-1) unstable; urgency=medium
 .
   * Team upload.
   * debhelper 9
   * Point Vcs fields to salsa.debian.org
   * Standards-Version: 4.3.0
   * Respect DEB_BUILD_OPTIONS in override_dh_auto_test target
   * Remove trailing whitespace in debian/changelog
   * Remove duplicated file debian/menu
   * Build-Depends: help2man (since this is used as test)
   * Re-activate patch to skip some tests that are failing for some
     unknown reason in a pbuilder chroot
   * Fix FTBFS with dcmtk >= 3.6.1~20170228-2 (thanks for the patch
     to Steve Langasek <steve.langa...@canonical.com>)
     Closes: #865955
   * libodin-dev: Depends: sensible-utils
   * hardening=+all
   * Build-Depends: s/libqwt5-qt4-dev/libqwt-dev/
     Closes: #909363
Checksums-Sha1:
 f14c3a914a79df2fec5fd46d61768a832d1fd1e0 2222 odin_2.0.3-1.dsc
 d3dda1882c47deab67d4760aacbcf0417118c990 6960 odin_2.0.3-1.debian.tar.xz
 1c81a9252c1b3e161adee6722099a9aa3d03c48c 22073 odin_2.0.3-1_amd64.buildinfo
Checksums-Sha256:
 a82b180ca726bfa57914c37af69263d9c0445b5269edacf8541fa8b7f4ae7ba9 2222 
odin_2.0.3-1.dsc
 c47acdfe2f62606c63dfc4c84c701ae2fe245e14ebd776502fc92eea48a278ea 6960 
odin_2.0.3-1.debian.tar.xz
 7c8364f4e88d3d07cd8cb3aa273b7def80f339bcd7c2cbdf6af0867b2c014ea5 22073 
odin_2.0.3-1_amd64.buildinfo
Files:
 cbd03db1a46b1b1881b2542fc882183e 2222 science optional odin_2.0.3-1.dsc
 e7f1295d9df870ad5881acd334c95b69 6960 science optional 
odin_2.0.3-1.debian.tar.xz
 a8eaaa1597927f95fddf3b356c390e93 22073 science optional 
odin_2.0.3-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEE8fAHMgoDVUHwpmPKV4oElNHGRtEFAlxDpD4RHHRpbGxlQGRl
Ymlhbi5vcmcACgkQV4oElNHGRtFxTA//dyEtOaftdhK/P8q39EwxuJ+71MXsbPeW
n+S3zT3Pv+plEUKFQ7nFhAMW+AhQgMZsFTeoJ6Pr162/8gDIujPsk23+mQVFMCil
+T+LyV6OLbEZ6BsSoss8BOhOiRz+yEobjbf+AJIruTbY1VhLcHa0gYKEEUNU8HQZ
+sk/IJCTVsRsrdc6uNwSACQJcc7eeehtTpgbMRPr5YuUNPf5iksftOonowY6DIX8
Dv94IqbQQJqSV2YRwUShV7u87LdLseF32xr+uysh+BdjCi2PpyzlfWVopN813zXj
rpRL7pUVa+IQzhkKAsWxbBAm+VSDQ3KvdiznY6JV0nPZyZ2B4S358U/Ajo4Ev5pL
jb4vh3DmwTsbZuvw/X8o4aFvrrt4IaJwo0NrOT7tjijYFlcwwP4UUWj4h8rsZ4oz
yO77H9TnthM51MpFcMrEIzEwUrKhiWDuf/YA/3b6hKO5najb6qyLIOnnn1KW0/J/
5UTE3crq/fL2OuwuWcT+UlIMv708cVvOi+dag1vlh/VScI4bzpztAGd2eqInmGmH
8HIT46AnvHekJatCCuxdNJvBoWTHI93Z237AOsgEn6hYKPq322zts/Em22g40ncH
jJn0Mc+qLfaHwTL8jjaDX/QrYpW3Y9QvgFhxK7q+CcguZYcCBocLoWFnlbiJ22ve
magJnl1GX24=
=iHZP
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to