Source: ball
Version: 1.5.0+git20180813.37fc53c-1
Severity: serious
Tags: patch ftbfs
https://buildd.debian.org/status/package.php?p=ball&suite=sid
...
[ 9%] Building CXX object CMakeFiles/BALL.dir/source/DATATYPE/hashGrid.C.o
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
};
^
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
/<<BUILDDIR>>/ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C:23:3:
error: narrowing conversion of '-1' from 'int' to 'char' inside { }
[-Wnarrowing]
make[5]: *** [CMakeFiles/BALL.dir/build.make:522:
CMakeFiles/BALL.dir/source/DATATYPE/hashGrid.C.o] Error 1
Fix is attached.
Description: Fix FTBFS on architectures where char is unsigned
Author: Adrian Bunk <b...@debian.org>
--- ball-1.5.0+git20180813.37fc53c.orig/include/BALL/DATATYPE/hashGrid.h
+++ ball-1.5.0+git20180813.37fc53c/include/BALL/DATATYPE/hashGrid.h
@@ -32,7 +32,7 @@ namespace BALL
{
namespace __private
{
- extern const char BALL_EXPORT neighbour_table_[27][3];
+ extern const signed char BALL_EXPORT neighbour_table_[27][3];
}
template <typename Item> class HashGrid3;
--- ball-1.5.0+git20180813.37fc53c.orig/source/DATATYPE/hashGrid.C
+++ ball-1.5.0+git20180813.37fc53c/source/DATATYPE/hashGrid.C
@@ -9,7 +9,7 @@ namespace BALL
{
namespace __private
{
- const char neighbour_table_[27][3] =
+ const signed char neighbour_table_[27][3] =
{
{ 0, 0, 0 }, { 0, 0, -1 }, { 0, 0, 1 },
{ 0, -1, -1 }, { 0, -1, 0 }, { 0, -1, 1 },
