Hi Bastien, On Fri, Jan 4, 2019 at 8:41 PM Balint Reczey <balint.rec...@canonical.com> wrote: > > Hi, > > On Thu, Dec 20, 2018 at 6:46 AM Bastien ROUCARIES > <roucaries.bastien+imagemag...@gmail.com> wrote: > > > > On Wed, Dec 19, 2018 at 12:09 PM Balint Reczey > > <balint.rec...@canonical.com> wrote: > > > > > > Package: imagemagick > > > Version: 8:6.9.10.14+dfsg-1 > > > Severity: grave > > > Control: forwareded -1 > > > https://github.com/ImageMagick/ImageMagick6/issues/31 > > > Control: tags -1 upstream fixed-upstream > > > Control: affects -1 ruby-rmagick > > > > > > Hi, > > > > > > The ABI broke in 6.9.10-11 due to changing MagickDoubleType to double > > > from long double. > > > This breaks ruby-rmagick and possibly other reverse dependencies, thus > > > after fixing imagemagick please check if some reverse dependencies > > > need to be rebuilt. The fix will be available in the .18 upstream > > > release. > > > > Exact, this will need a so bump I suppose... > > Since the ABI broke only in unstable and testing and only affected > i386 and possibly a few rare arches not in Ubuntu I'd say a few > rebuilds would suffice. Upstream did not do a major ABI bump either > and released the fix.
I have uploaded an NMU to DELAYED/5 with the attached fix, which is already included in Ubuntu. This will enter the archive before the transition freeze thus Buster will be fixed even if no upload is made to imagemagick in the next week, but feel free to override it an upload a better fix like a full new upstream release. Cheers, Balint > > Cheers, > Balint > > > > > Bastien > > > > > > > > > > > > Cheers, > > > Balint > > > > > > -- > > > Balint Reczey > > > Ubuntu & Debian Developer > > > > > > > -- > Balint Reczey > Ubuntu & Debian Developer -- Balint Reczey Ubuntu & Debian Developer
diff -Nru imagemagick-6.9.10.14+dfsg/debian/changelog imagemagick-6.9.10.14+dfsg/debian/changelog --- imagemagick-6.9.10.14+dfsg/debian/changelog 2018-11-05 03:09:08.000000000 +0700 +++ imagemagick-6.9.10.14+dfsg/debian/changelog 2019-01-05 15:40:40.000000000 +0700 @@ -1,3 +1,11 @@ +imagemagick (8:6.9.10.14+dfsg-7.1) unstable; urgency=medium + + * Non-maintainer upload. + * Revert hidden ABI break by changing MagickFloatType's size on i386 + (Closes: #916839) + + -- Balint Reczey <rbal...@ubuntu.com> Sat, 05 Jan 2019 15:40:40 +0700 + imagemagick (8:6.9.10.14+dfsg-7) unstable; urgency=medium * Bug fix: "wrong Provides: libmagickcore-6.defaultquantum-dev, diff -Nru imagemagick-6.9.10.14+dfsg/debian/patches/0023-Revert-hidden-ABI-break-by-changing-MagickFloatType-.patch imagemagick-6.9.10.14+dfsg/debian/patches/0023-Revert-hidden-ABI-break-by-changing-MagickFloatType-.patch --- imagemagick-6.9.10.14+dfsg/debian/patches/0023-Revert-hidden-ABI-break-by-changing-MagickFloatType-.patch 1970-01-01 07:00:00.000000000 +0700 +++ imagemagick-6.9.10.14+dfsg/debian/patches/0023-Revert-hidden-ABI-break-by-changing-MagickFloatType-.patch 2019-01-05 15:40:40.000000000 +0700 @@ -0,0 +1,31 @@ +From: Balint Reczey <balint.rec...@canonical.com> +Date: Tue, 18 Dec 2018 20:04:57 +0100 +Subject: Revert hidden ABI break by changing MagickFloatType's size on i386 + +This reverts commit 94a86b3324bed28b4ed4a80ff0be05dc58c0023e. +--- + magick/magick-type.h | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/magick/magick-type.h b/magick/magick-type.h +index 0fc437c..2f5e38f 100644 +--- a/magick/magick-type.h ++++ b/magick/magick-type.h +@@ -46,7 +46,7 @@ typedef float MagickFloatType; + #elif (MAGICKCORE_SIZEOF_FLOAT_T == MAGICKCORE_SIZEOF_DOUBLE) + typedef double MagickFloatType; + #elif (MAGICKCORE_SIZEOF_FLOAT_T == MAGICKCORE_SIZEOF_LONG_DOUBLE) +-typedef double MagickFloatType; ++typedef long double MagickFloatType; + #else + #error Your MagickFloatType type is neither a float, nor a double, nor a long double + #endif +@@ -55,7 +55,7 @@ typedef double MagickDoubleType; + #elif (MAGICKCORE_SIZEOF_DOUBLE_T == MAGICKCORE_SIZEOF_DOUBLE) + typedef double MagickDoubleType; + #elif (MAGICKCORE_SIZEOF_DOUBLE_T == MAGICKCORE_SIZEOF_LONG_DOUBLE) +-typedef double MagickDoubleType; ++typedef long double MagickDoubleType; + #else + #error Your MagickDoubleType type is neither a float, nor a double, nor a long double + #endif diff -Nru imagemagick-6.9.10.14+dfsg/debian/patches/series imagemagick-6.9.10.14+dfsg/debian/patches/series --- imagemagick-6.9.10.14+dfsg/debian/patches/series 2018-10-29 23:17:35.000000000 +0700 +++ imagemagick-6.9.10.14+dfsg/debian/patches/series 2019-01-05 15:40:40.000000000 +0700 @@ -20,3 +20,4 @@ 0020-Fix-end-tags.patch 0021-Fix-remaining-error-in-documentation.patch 0022-Fix-privacy-breach.patch +0023-Revert-hidden-ABI-break-by-changing-MagickFloatType-.patch
