Your message dated Fri, 04 Jan 2019 17:35:11 +0000
with message-id <e1gftnh-0005fk...@fasolo.debian.org>
and subject line Bug#918128: fixed in gazebo 9.6.0-1
has caused the Debian Bug report #918128,
regarding gazebo: autopkgtest fails due to invalid gazebo.pc
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
918128: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=918128
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: gazebo
Version: 9.4.1+dfsg-1
Severity: serious
Tags: patch
Justification: makes the package in question unusable or mostly so
Control: block 917323 by -1

Dear Maintainer,

The autopkgtest for gazebo is failing due to an invalid gazebo.pc:

 autopkgtest [12:48:58]: test build: [-----------------------
 /usr/bin/ld: cannot find -l-lpthread
 collect2: error: ld returned 1 exit status
 autopkgtest [12:48:59]: test build: -----------------------]
 autopkgtest [12:48:59]: test build:  - - - - - - - - - - results - - - - - - - 
- - -
 build                FAIL non-zero exit status 1
 autopkgtest [12:49:00]: test build:  - - - - - - - - - - stderr - - - - - - - 
- - -
 /usr/bin/ld: cannot find -l-lpthread
 collect2: error: ld returned 1 exit status
 autopkgtest [12:49:00]: @@@@@@@@@@@@@@@@@@@@ summary
 build                FAIL non-zero exit status 1

See: 
https://ci.debian.net/data/packages/unstable/amd64/g/gazebo/latest-autopkgtest/log.gz

This is caused by ${Boost_LIBRARIES} containing:

 
/usr/lib/x86_64-linux-gnu/libboost_thread.so;-lpthread;/usr/lib/x86_64-linux-gnu/libboost_signals.so;[...]

Which results in:

 [...]-L/usr/lib/x86_64-linux-gnu -lboost_thread -l-lpthread 
-lboost_signals[...]

The attached patch fixes the issue by prefixing -l only when it is not
already present.

Kind Regards,

Bas
Description: Don't prefix -l if already present.
 An invalid gazebo.pc is generated when ${Boost_LIBRARIES} contains:
 .
 
/usr/lib/x86_64-linux-gnu/libboost_thread.so;-lpthread;/usr/lib/x86_64-linux-gnu/libboost_signals.so;[...]
 .
 This resulted in gazebo.pc containing:
 .
 [...]-L/usr/lib/x86_64-linux-gnu -lboost_thread -l-lpthread 
-lboost_signals[...]
 .
 Which in turn caused the autopkgtests to fail:
 .
 /usr/bin/ld: cannot find -l-lpthread
Author: Bas Couwenberg <sebas...@debian.org>

Index: gazebo-9.4.1+dfsg/CMakeLists.txt
===================================================================
--- gazebo-9.4.1+dfsg.orig/CMakeLists.txt
+++ gazebo-9.4.1+dfsg/CMakeLists.txt
@@ -371,8 +371,10 @@ else (build_errors)
 
   foreach (b ${Boost_LIBRARIES})
     get_filename_component(bname ${b} NAME_WE)
-    # Prefix always -l
-    set (bname "-l${bname}")
+    # Prefix -l if not already present
+    if(NOT ${bname} MATCHES "^-l")
+      set (bname "-l${bname}")
+    endif()
     # Remove the prefix lib (not always present, like in pthread)
     string (REPLACE "lib" "" bname "${bname}")
     set (Boost_PKGCONFIG_LIBS "${Boost_PKGCONFIG_LIBS} ${bname}")

--- End Message ---
--- Begin Message ---
Source: gazebo
Source-Version: 9.6.0-1

We believe that the bug you reported is fixed in the latest version of
gazebo, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 918...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jose Luis Rivero <jriv...@osrfoundation.org> (supplier of updated gazebo 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 04 Jan 2019 16:25:21 +0000
Source: gazebo
Binary: gazebo9-common gazebo9 libgazebo9 libgazebo9-dev gazebo9-plugin-base 
gazebo9-doc
Architecture: source
Version: 9.6.0-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Maintainers 
<debian-science-maintain...@lists.alioth.debian.org>
Changed-By: Jose Luis Rivero <jriv...@osrfoundation.org>
Description:
 gazebo9    - Open Source Robotics Simulator - Binaries
 gazebo9-common - Open Source Robotics Simulator - Shared files
 gazebo9-doc - Open Source Robotics Simulator - Documentation
 gazebo9-plugin-base - Open Source Robotics Simulator - base plug-ins
 libgazebo9 - Open Source Robotics Simulator - shared library
 libgazebo9-dev - Open Source Robotics Simulator - Development Files
Closes: 918128
Changes:
 gazebo (9.6.0-1) unstable; urgency=medium
 .
   * New upstream version 9.6.0
   * Remove patches merged upstream
   * Patch to avoid extra -l in pkgconfig provided flags.
     Closes: #918128. Thanks to Bas Couwenberg.
Checksums-Sha1:
 2cb38548d8de43a4d01ebc34b8a94c4d6ba51878 2964 gazebo_9.6.0-1.dsc
 b134b8ceaa82ce71c8e5cd98384d71df3c53a46c 52310428 gazebo_9.6.0.orig.tar.gz
 656eda11c7db48ead869f8622fc183ba634f73c3 14268 gazebo_9.6.0-1.debian.tar.xz
 46ed5afaee1ca1210beed65aac15ee52e18a64b5 24768 gazebo_9.6.0-1_source.buildinfo
Checksums-Sha256:
 89093d05294075c51af2505363bfbdda7bd1369b535680610e5d77985f6c5659 2964 
gazebo_9.6.0-1.dsc
 267bf6d0f88b6eda507816d79be5e3109928c911800db6d94de5c770ccff0992 52310428 
gazebo_9.6.0.orig.tar.gz
 5b8de4c6131b30b7157ac197de4bf1b442e5882dc7d523c74d4ed8715388d3b6 14268 
gazebo_9.6.0-1.debian.tar.xz
 fe9ea4b09f2ee4558af81776e7fa39880f468b81097c11399a5142b483f962d5 24768 
gazebo_9.6.0-1_source.buildinfo
Files:
 9c3de6a7c39916b5ebd1c994aaed00be 2964 science optional gazebo_9.6.0-1.dsc
 2cb1206d3a0aef91c31ad67d9140455b 52310428 science optional 
gazebo_9.6.0.orig.tar.gz
 c60ba3504c96841203ac2d34b4c0298b 14268 science optional 
gazebo_9.6.0-1.debian.tar.xz
 03e89b222addab57f035cf614fa92f8a 24768 science optional 
gazebo_9.6.0-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQFOBAEBCgA4FiEEoIFhu+wcwGOWFFkDXpRsCQr/BCcFAlwvlY4aHGpyaXZlcm9A
b3NyZm91bmRhdGlvbi5vcmcACgkQXpRsCQr/BCeyRggAp3E75UAJv2vYsmR6mQpH
q2wwEWdlbcnrUQJkprPfvbAkOICr1BKFKKaTLHOkep5AIV7pHSCPLKlbs7+hbTPt
BIGYQBBhODIaJKP22EiYn3VYj9mA+jE6h5QRhjP008w6nS6CfePdvy4QV6TBJgm6
xtsHIE+gbVUs/VZVDcsCwdBd/1OVkdF2yYE1inyA8AHacKk85zr2zKr4X0uX3jq6
4Q+qss2eA4HGprmvTEACv2hbF5en66XK2I7Jrk/cQFAMdm8FDZDBt/HmkLnfzJT4
+XPAkSBDdx2nbJs4KDxH6I6Z1AzjznBZsgPFyuRxNyMzdqLfh2+pclZHUj5DeCI5
dg==
=c1Be
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to