Your message dated Mon, 31 Dec 2018 18:32:38 -0500
with message-id <20181231183238.0f6fc...@216-moncure.alexandria.va.us>
and subject line comedilib: FTBFS with glibc 2.28, upstream cherrypick fix 
attached
has caused the Debian Bug report #913106,
regarding comedilib: FTBFS with glibc 2.28, upstream cherrypick fix attached
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
913106: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=913106
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: comedilib
Version: 0.10.2-4
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu disco ubuntu-patch



In Ubuntu, the attached patch was applied to achieve the following:

  * 04_glibc2.28_fix.patch: Cherrypick fix to define minor() with new glibc.

This should be pretty self-explanatory.

... Adam


-- System Information:
Debian Release: buster/sid
  APT prefers disco
  APT policy: (500, 'disco')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.18.0-10-lowlatency (SMP w/4 CPU cores; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_CA:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru comedilib-0.10.2/debian/control comedilib-0.10.2/debian/control
--- comedilib-0.10.2/debian/control     2016-11-01 10:14:34.000000000 -0600
+++ comedilib-0.10.2/debian/control     2018-11-06 10:54:06.000000000 -0700
@@ -1,8 +1,7 @@
 Source: comedilib
 Section: devel
 Priority: optional
-Maintainer: Ubuntu Developers <ubuntu-devel-disc...@lists.ubuntu.com>
-XSBC-Original-Maintainer: Gudjon I. Gudjonsson <gud...@gudjon.org>
+Maintainer: Gudjon I. Gudjonsson <gud...@gudjon.org>
 Build-Depends: debhelper (>= 9), dpkg-dev (>= 1.16.1~), autotools-dev,
  swig, docbook-utils, dblatex, bison, flex, libtool, xmlto, imagemagick, fop,
  libboost-program-options-dev, libgsl-dev,
diff -Nru comedilib-0.10.2/debian/patches/04_glibc2.28_fix.patch 
comedilib-0.10.2/debian/patches/04_glibc2.28_fix.patch
--- comedilib-0.10.2/debian/patches/04_glibc2.28_fix.patch      1969-12-31 
17:00:00.000000000 -0700
+++ comedilib-0.10.2/debian/patches/04_glibc2.28_fix.patch      2018-11-06 
10:53:34.000000000 -0700
@@ -0,0 +1,30 @@
+From 3f8514739a2d799d2e6dbb6cd43a7f6bb624a319 Mon Sep 17 00:00:00 2001
+From: Ian Abbott <abbo...@mev.co.uk>
+Date: Mon, 10 Apr 2017 19:02:55 +0100
+Subject: [PATCH] lib/calib.c: Include <sys/sysmacros.h> for fstat()
+
+Relying on <sys/types.h> to define major(), minor() and makedev() is
+deprecated, so include <sys/sysmacros.h> to define them.
+
+Als include <sys/types.h> and <unistd.h> as the Linux man page for
+fstat() has them in the synopsys.
+---
+ lib/calib.c | 4 ++++
+ 1 file changed, 4 insertions(+)
+
+diff --git a/lib/calib.c b/lib/calib.c
+index ee823bc..d60bf2c 100644
+--- a/lib/calib.c
++++ b/lib/calib.c
+@@ -27,7 +27,11 @@
+ #include <stdlib.h>
+ #include <stdio.h>
+ #include <string.h>
++#include <sys/types.h>
+ #include <sys/stat.h>
++#include <sys/sysmacros.h>
++#include <unistd.h>
++
+ #include "libinternal.h"
+ 
+ static int set_calibration( comedi_t *dev, const comedi_calibration_t 
*parsed_file,
diff -Nru comedilib-0.10.2/debian/patches/series 
comedilib-0.10.2/debian/patches/series
--- comedilib-0.10.2/debian/patches/series      2015-08-02 22:33:18.000000000 
-0600
+++ comedilib-0.10.2/debian/patches/series      2018-11-06 10:54:00.000000000 
-0700
@@ -1,3 +1,4 @@
 01_fix_spelling.patch
 02_configure.patch
 03_manpages.patch
+04_glibc2.28_fix.patch

--- End Message ---
--- Begin Message ---
abi-compliance-checker shows that the newer version is ABI compatible.

For Debian packages built with libcomedi-dev, neither gnuradio nor
xoscope made reference to the removed constants.

New version includes cherrypicked patch.

Already successfully building with glibc 2.28.

Happy New Year!
-Maitland
Title: comedi: 0.10 to 0.11 compatibility report

API compatibility report for the comedi library between 0.10 and 0.11 versions on x86_64


Test Info


Library Namecomedi
Version #10.10
Version #20.11
CPU Typex86_64
GCC Version6.3.0
SubjectBinary Compatibility

Test Results


Total Header Files7
Total Shared Libraries1
Total Symbols / Types82 / 50
Compatibility 100%

Problem Summary


SeverityCount
Added Symbols-13
Removed SymbolsHigh0
Problems with
Data Types
High0
Medium0
Low0
Problems with
Symbols
High0
Medium0
Low0
Problems with
Constants
Low13
Other Changes
in Constants
-7

Added Symbols  13 


comedilib.h, libcomedi.so.0.11.0
comedi_arm_channel ( comedi_t* device, unsigned int subdevice, unsigned int channel, unsigned int source ) @@ v0.11.0
comedi_digital_trigger_disable ( comedi_t* device, unsigned int subdevice, unsigned int trigger_id ) @@ v0.11.0
comedi_digital_trigger_enable_edges ( comedi_t* device, unsigned int subdevice, unsigned int trigger_id, unsigned int base_input, unsigned int rising_edge_inputs, unsigned int falling_edge_inputs ) @@ v0.11.0
comedi_digital_trigger_enable_levels ( comedi_t* device, unsigned int subdevice, unsigned int trigger_id, unsigned int base_input, unsigned int high_level_inputs, unsigned int low_level_inputs ) @@ v0.11.0
comedi_disarm ( comedi_t* device, unsigned int subdevice ) @@ v0.11.0
comedi_disarm_channel ( comedi_t* device, unsigned int subdevice, unsigned int channel ) @@ v0.11.0
comedi_get_buffer_read_count comedi_t* it, unsigned int subdev, unsigned int* read_count ) @@ v0.11.0
comedi_get_buffer_read_offset comedi_t* it, unsigned int subdev ) @@ v0.11.0
comedi_get_buffer_write_count comedi_t* it, unsigned int subdev, unsigned int* write_count ) @@ v0.11.0
comedi_get_buffer_write_offset comedi_t* it, unsigned int subdev ) @@ v0.11.0
comedi_reset_channel ( comedi_t* device, unsigned int subdevice, unsigned int channel ) @@ v0.11.0
comedi_set_read_subdevice comedi_t* it, unsigned int subdevice ) @@ v0.11.0
comedi_set_write_subdevice comedi_t* it, unsigned int subdevice ) @@ v0.11.0

to the top

Problems with Constants, Low Severity  13 


comedi.h
[+] COMEDI_CB_BLOCK
[+] COMEDI_CB_EOA
[+] COMEDI_CB_EOBUF
[+] COMEDI_CB_EOS
[+] COMEDI_CB_ERROR
[+] COMEDI_CB_OVERFLOW
[+] CR_ALT_FILTER
[+] CR_ALT_SOURCE
[+] CR_DEGLITCH
[+] CR_DITHER
[+] CR_EDGE
[+] CR_INVERT
[+] RF_EXTERNAL

to the top

Other Changes in Constants  7 


comedi.h
[+] CMDF_BOGUS
[+] CMDF_ROUND_DOWN
[+] CMDF_ROUND_MASK
[+] CMDF_ROUND_NEAREST
[+] CMDF_ROUND_UP
[+] CMDF_ROUND_UP_NEXT
[+] CMDF_WAKE_EOS

to the top

Header Files  7 


comedi.h
comedi_errno.h
comedi_iostream.hpp
comedilib.h
comedilib.hpp
comedilib_scxi.h
comedilib_version.h

to the top

Shared Libraries  1 


libcomedi.so.0.10.2

to the top



Test Info


Library Namecomedi
Version #10.10
Version #20.11
CPU Typex86_64
GCC Version6.3.0
SubjectSource Compatibility

Test Results


Total Header Files7
Total Shared Libraries1
Total Symbols / Types192 / 100
Compatibility 90.1%

Problem Summary


SeverityCount
Added Symbols-46
Removed SymbolsHigh19
Problems with
Data Types
High0
Medium0
Low0
Problems with
Symbols
High0
Medium0
Low0
Problems with
Constants
Low16
Other Changes
in Symbols
-9
Other Changes
in Constants
-9

Added Symbols  46 


comedilib.h
comedi_arm_channel ( comedi_t* device, unsigned int subdevice, unsigned int channel, unsigned int source )
comedi_digital_trigger_disable ( comedi_t* device, unsigned int subdevice, unsigned int trigger_id )
comedi_digital_trigger_enable_edges ( comedi_t* device, unsigned int subdevice, unsigned int trigger_id, unsigned int base_input, unsigned int rising_edge_inputs, unsigned int falling_edge_inputs )
comedi_digital_trigger_enable_levels ( comedi_t* device, unsigned int subdevice, unsigned int trigger_id, unsigned int base_input, unsigned int high_level_inputs, unsigned int low_level_inputs )
comedi_disarm ( comedi_t* device, unsigned int subdevice )
comedi_disarm_channel ( comedi_t* device, unsigned int subdevice, unsigned int channel )
comedi_get_buffer_read_count comedi_t* it, unsigned int subdev, unsigned int* read_count )
comedi_get_buffer_read_offset comedi_t* it, unsigned int subdev )
comedi_get_buffer_write_count comedi_t* it, unsigned int subdev, unsigned int* write_count )
comedi_get_buffer_write_offset comedi_t* it, unsigned int subdev )
comedi_reset_channel ( comedi_t* device, unsigned int subdevice, unsigned int channel )
comedi_set_read_subdevice comedi_t* it, unsigned int subdevice )
comedi_set_write_subdevice comedi_t* it, unsigned int subdevice )

comedilib.hpp
namespace comedi
device::do_insnlist comedi_insnlist* insnlist ) const
device::get_read_subdevice ( ) const
device::get_write_subdevice ( ) const
subdevice::arm unsigned int source ) const
subdevice::arm_channel ( unsigned int channel, unsigned int source ) const
subdevice::data_read_delayed ( unsigned int channel, unsigned int range, unsigned int aref, unsigned int nano_sec ) const
subdevice::digital_trigger_disable unsigned int trigger_id ) const
subdevice::digital_trigger_enable_edges ( unsigned int trigger_id, unsigned int base_input, unsigned int rising_edge_inputs, unsigned int falling_edge_inputs ) const
subdevice::digital_trigger_enable_levels ( unsigned int trigger_id, unsigned int base_input, unsigned int high_level_inputs, unsigned int low_level_inputs ) const
subdevice::dio_bitfield ( unsigned int write_mask, unsigned int* bits ) const
subdevice::dio_get_config unsigned int channel ) const
subdevice::dio_read unsigned int channel ) const
subdevice::dio_write ( unsigned int channel, unsigned int bit ) const
subdevice::disarm ( ) const
subdevice::disarm_channel unsigned int channel ) const
subdevice::get_buffer_read_count ( ) const
subdevice::get_buffer_read_offset ( ) const
subdevice::get_buffer_write_count ( ) const
subdevice::get_buffer_write_offset ( ) const
subdevice::get_cmd_generic_timed comedi_cmd* cmd, unsigned int chanlist_len, unsigned int scan_period ) const
subdevice::get_cmd_src_mask comedi_cmd* cmd ) const
subdevice::lock ( ) const
subdevice::mark_buffer_read unsigned int bytes ) const
subdevice::mark_buffer_written unsigned int bytes ) const
subdevice::max_data_is_chan_specific ( ) const
subdevice::poll ( ) const
subdevice::range_is_chan_specific ( ) const
subdevice::reset_channel unsigned int channel ) const
subdevice::set_as_read_subdevice ( ) const
subdevice::set_as_write_subdevice ( ) const
subdevice::set_filter ( unsigned int channel, unsigned int filter ) const
subdevice::set_other_source ( unsigned int channel, unsigned int other, unsigned int source ) const
subdevice::unlock ( ) const

to the top

Removed Symbols  19 


comedi.h
NI_AO_SCAN_BEGIN_SRC_PFI unsigned int pfi_channel )
NI_AO_SCAN_BEGIN_SRC_RTSI unsigned int rtsi_channel )
NI_CDIO_SCAN_BEGIN_SRC_PFI unsigned int pfi_channel )
NI_CDIO_SCAN_BEGIN_SRC_RTSI unsigned int rtsi_channel )
NI_EXT_PFI unsigned int pfi_channel )
NI_EXT_RTSI unsigned int rtsi_channel )
NI_GPCT_GATE_PIN_GATE_SELECT unsigned int n )
NI_GPCT_PFI_CLOCK_SRC_BITS unsigned int n )
NI_GPCT_PFI_GATE_SELECT unsigned int n )
NI_GPCT_PFI_OTHER_SELECT unsigned int n )
NI_GPCT_RTSI_CLOCK_SRC_BITS unsigned int n )
NI_GPCT_RTSI_GATE_SELECT unsigned int n )
NI_GPCT_SOURCE_PIN_CLOCK_SRC_BITS unsigned int n )
NI_GPCT_UP_DOWN_PIN_GATE_SELECT unsigned int n )
NI_MIO_PLL_RTSI_CLOCK unsigned int rtsi_channel )
NI_PFI_OUTPUT_RTSI unsigned int rtsi_channel )
NI_RTSI_OUTPUT_RTSI_BRD unsigned int n )
NI_USUAL_PFI_SELECT unsigned int pfi_channel )
NI_USUAL_RTSI_SELECT unsigned int rtsi_channel )

to the top

Problems with Constants, Low Severity  16 


comedi.h
[+] COMEDI_CB_BLOCK
[+] COMEDI_CB_EOA
[+] COMEDI_CB_EOBUF
[+] COMEDI_CB_EOS
[+] COMEDI_CB_ERROR
[+] COMEDI_CB_OVERFLOW
[+] COMEDI_MIN_SPEED
[+] CR_ALT_FILTER
[+] CR_ALT_SOURCE
[+] CR_DEGLITCH
[+] CR_DITHER
[+] CR_EDGE
[+] CR_INVERT
[+] RF_EXTERNAL

comedilib_version.h
[+] COMEDILIB_VERSION_MICRO
[+] COMEDILIB_VERSION_MINOR

to the top

Other Changes in Symbols  9 


comedilib.hpp
namespace comedi
[+] subdevice::cancel ( )  1 
[+] subdevice::dio_bitfield2 ( unsigned int write_mask, unsigned int* bits, unsigned int base_channel )  1 
[+] subdevice::dio_config ( unsigned int channel, enum comedi_io_direction direction )  1 
[+] subdevice::find_range ( unsigned int channel, unsigned int unit, double min, double max )  1 
[+] subdevice::get_gate_source ( unsigned int channel, unsigned int gate_index, unsigned int* gate_source )  1 
[+] subdevice::set_clock_source ( unsigned int channel, unsigned int clock, unsigned int period_ns )  1 
[+] subdevice::set_counter_mode ( unsigned int channel, unsigned int mode_bits )  1 
[+] subdevice::set_gate_source ( unsigned int channel, unsigned int gate_index, unsigned int gate_source )  1 
[+] subdevice::set_routing ( unsigned int channel, unsigned int routing )  1 

to the top

Other Changes in Constants  9 


comedi.h
[+] CMDF_BOGUS
[+] CMDF_ROUND_DOWN
[+] CMDF_ROUND_MASK
[+] CMDF_ROUND_NEAREST
[+] CMDF_ROUND_UP
[+] CMDF_ROUND_UP_NEXT
[+] CMDF_WAKE_EOS
[+] COMEDI_SETRSUBD
[+] COMEDI_SETWSUBD

to the top

Header Files  7 


comedi.h
comedi_errno.h
comedi_iostream.hpp
comedilib.h
comedilib.hpp
comedilib_scxi.h
comedilib_version.h

to the top

Shared Libraries  1 


libcomedi.so.0.10.2

to the top






--- End Message ---

Reply via email to