Your message dated Mon, 17 Dec 2018 00:49:21 +0000
with message-id <e1gyh61-0008mr...@fasolo.debian.org>
and subject line Bug#908160: fixed in open-iscsi 2.0.874-7.1
has caused the Debian Bug report #908160,
regarding FTBFS: build from source fails with undefined reference to `minor'
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
908160: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=908160
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: open-iscsi
Version: 2.0.874-5ubuntu7
Severity: serious
Tags: patch
Justification: fails to build from source (but built successfully in the past)
Current build of open-iscsi (2.0.874-5ubuntu7) will fail to build from
source.
Build fails with:
./iscsiuio/src/unix/libs/bnx2x.c:754: undefined reference to `minor'
collect2: error: ld returned 1 exit status
This is reported to Ubuntu in bug 1791154
https://bugs.launchpad.net/bugs/1791154
Attached is the fix I am uploading to Ubuntu.
-- System Information:
Debian Release: buster/sid
APT prefers cosmic
APT policy: (500, 'cosmic')
Architecture: amd64 (x86_64)
Kernel: Linux 4.17.0-9-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages open-iscsi depends on:
ii debconf [debconf-2.0] 1.5.69
ii libc6 2.28-0ubuntu1
ii libisns0 0.97-2build1
ii libmount1 2.32-0.1ubuntu1
ii lsb-base 9.20170808ubuntu1
ii udev 239-7ubuntu7
Versions of packages open-iscsi recommends:
ii busybox-initramfs 1:1.27.2-2ubuntu4
ii finalrd 3
open-iscsi suggests no packages.
-- debconf information excluded
commit e8ddf2765525522924a03f668220ba8f256a58d8
Author: Scott Moser <smo...@brickies.net>
Date: Thu Sep 6 15:38:20 2018 -0400
Include <sys/sysmacros.h> to properly define minor()
LP: #1791154
diff --git
a/debian/patches/bugfixes/include-sys-sysmacros.h-to-properly-define-minor.patch
b/debian/patches/bugfixes/include-sys-sysmacros.h-to-properly-define-minor.patch
new file mode 100644
index 00000000..ba92af5f
--- /dev/null
+++
b/debian/patches/bugfixes/include-sys-sysmacros.h-to-properly-define-minor.patch
@@ -0,0 +1,28 @@
+Description: Include <sys/sysmacros.h> to properly define minor()
+Author: Scott Moser <smo...@ubuntu.com>
+Bug-Debian: https://bugs.launchpad.net/bugs/1791154
+Last-Update: 2018-09-06
+Origin: upstream,
https://github.com/open-iscsi/open-iscsi/commit/6d68ef5871c94c6ebbbe6e6b1fe0bc2dce711052
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+
+--- a/iscsiuio/src/unix/libs/bnx2x.c
++++ b/iscsiuio/src/unix/libs/bnx2x.c
+@@ -50,6 +50,7 @@
+ #include <sys/user.h>
+ #include <fcntl.h>
+ #include <unistd.h>
++#include <sys/sysmacros.h>
+
+ #include "config.h"
+
+--- a/iscsiuio/src/unix/libs/bnx2.c
++++ b/iscsiuio/src/unix/libs/bnx2.c
+@@ -46,6 +46,7 @@
+ #include <sys/user.h>
+ #include <fcntl.h>
+ #include <unistd.h>
++#include <sys/sysmacros.h>
+
+ #include "config.h"
+
diff --git a/debian/patches/series b/debian/patches/series
index 34608a68..d98a5c63 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -13,3 +13,4 @@ security/Ensure-strings-from-peer-are-copied-correctly.patch
security/Skip-useless-strcopy-and-validate-CIDR-length.patch
security/Check-iscsiuio-ping-data-length-for-validity.patch
iscid-conf-use-systemd.socket-patch
+bugfixes/include-sys-sysmacros.h-to-properly-define-minor.patch
--- End Message ---
--- Begin Message ---
Source: open-iscsi
Source-Version: 2.0.874-7.1
We believe that the bug you reported is fixed in the latest version of
open-iscsi, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 908...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Hilko Bengen <ben...@debian.org> (supplier of updated open-iscsi package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 12 Dec 2018 01:05:19 +0100
Source: open-iscsi
Binary: open-iscsi iscsiuio open-iscsi-udeb
Architecture: source
Version: 2.0.874-7.1
Distribution: unstable
Urgency: medium
Maintainer: Debian iSCSI Maintainers <open-is...@packages.debian.org>
Changed-By: Hilko Bengen <ben...@debian.org>
Description:
iscsiuio - iSCSI offloading daemon for QLogic devices
open-iscsi - iSCSI initiator tools
open-iscsi-udeb - Configure iSCSI (udeb)
Closes: 908160
Changes:
open-iscsi (2.0.874-7.1) unstable; urgency=medium
.
* Non-maintainer upload
* [38db62d] Update patch for missing macro (Closes: #908160)
Checksums-Sha1:
432a00251ffe16caaa3764adaf511369eba47384 2482 open-iscsi_2.0.874-7.1.dsc
fe84ef1bd934064e08ec0ac6bb46b61346d45f58 60052
open-iscsi_2.0.874-7.1.debian.tar.xz
f2494f7c5ed9a7c454c5f3f66ac784e245cbe650 5619
open-iscsi_2.0.874-7.1_source.buildinfo
Checksums-Sha256:
5c199b1eee9d4aca3f2f5d671efd3665e997b0c475844e020d3258efbba87b39 2482
open-iscsi_2.0.874-7.1.dsc
4fee27876e8626feb58a1d979a5d08d431ff931ede1eb85a03de85bdfdf41f93 60052
open-iscsi_2.0.874-7.1.debian.tar.xz
5a6087dad377dd334f448470a9e1db38e8304b654cbd1a2ef0341454ba5a6742 5619
open-iscsi_2.0.874-7.1_source.buildinfo
Files:
368615911480baa0df2f984ddef9f893 2482 net optional open-iscsi_2.0.874-7.1.dsc
d716dc85cba80c841f43ffa2897eed19 60052 net optional
open-iscsi_2.0.874-7.1.debian.tar.xz
fae4fa0c411b6323a01079301900d502 5619 net optional
open-iscsi_2.0.874-7.1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJGBAEBCAAwFiEErnMQVUQqHZbPTUx4dbcQY1whOn4FAlwQUjUSHGJlbmdlbkBk
ZWJpYW4ub3JnAAoJEHW3EGNcITp+4YUQALdbZMHLKtXRrYO3C2YujjFmtfhNUGpz
PsKJ4wXU10kDHXGLIK3C1jKnHwPAeUdGT3Az2c0laYWZnKmagDam1LTM8HUF9kMy
9A6S7FcNzM94dReS1rG+Dk7+jIPhG+zjit/kegIUlBUl9t0ySzDecP1JC/W62eGX
UjnaLom1bYILVLwlLMd4Vi3fqGYkFgzRwqbDy56Tnd9CUMYjD8v7DSsC8yxUbZb7
igLfGtjVd/0yKVbEX4HM2jc6JYl0WJSeVgnlBWyqKuPDUNpBkonOHtQxclEaFFfK
yQBuERlhKIUW2on8RWcHWGh/wl+fCNy+rNZo6hcGVDU2Iyfr9X9tpEegwNHK54mT
FJ8phCOD3Kz7qz7nZXmZyugByEVFvXL2rwDb1lp1Of0+KKsEOPMEqrZ05S8hI+H/
vwONGwJC5yI0WtAN3OnwvJaCa6K0fu3YnvYBBWBk+wODO7N1DevD1rqgaRbOTSyf
rCGhmm9STKpxKBF8S+74qN2/vcSPLTN1/qlLeT8h6XeA07cOcOe2K5ibUR4ffe+m
m692KCT2Ds6Qegf+RupCwrI1PTuT4+gCCaFMmb9QDx75GNhdmaG0kOiX2IoCTii3
6BjQPGPw/NKNvALKOIElapBF+Y6iZQT3R3YXdOoRI7Au/cLU/F1adnRJh2Ntpbui
QeLv2NiZaVrw
=cTtn
-----END PGP SIGNATURE-----
--- End Message ---
