Your message dated Tue, 23 Oct 2018 13:20:56 +0000 with message-id <e1gewcc-0003yd...@fasolo.debian.org> and subject line Bug#905811: fixed in moria 5.7.10+20181022-1 has caused the Debian Bug report #905811, regarding moria does not trap errors from make to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 905811: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=905811 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Source: moria Version: 5.6.debian.1-2 Severity: serious Justification: debian policy 4.6 The Debian policy requires that a build aborts on errors rather than continuing. The moria package is interesting in this regard: ( cd build ; $(MAKE) ) It tries to cd to build and then runs make wherever it lands. As it happens, the clean target removes the build folder. So the cd fails and it runs the build directly in the source directory. That's actually the correct thing to do as the upstream Makefile's default target insists on setting up the build directory. The cd call can only succeed after setting up the build directory and nothing else in debian/rules takes care of that. I therefore think that that this chaining (that happens in more places) is in violation of the Debian policy section 4.6. It also is grossly misleading and makes contributing to the package unnecessarily difficult. Helmut
--- End Message ---
--- Begin Message ---Source: moria Source-Version: 5.7.10+20181022-1 We believe that the bug you reported is fixed in the latest version of moria, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 905...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Phil Brooke <p...@debian.org> (supplier of updated moria package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Mon, 22 Oct 2018 20:35:10 +0100 Source: moria Binary: moria Architecture: source amd64 Version: 5.7.10+20181022-1 Distribution: unstable Urgency: medium Maintainer: Phil Brooke <p...@debian.org> Changed-By: Phil Brooke <p...@debian.org> Description: moria - Rogue-like game with an infinite dungeon, also known as umoria Closes: 898531 905811 Changes: moria (5.7.10+20181022-1) unstable; urgency=medium . * New upstream release from https://github.com/dungeons-of-moria/umoria. It's slightly ahead of the upstream git tag 5.7.10, hence the version field. One additional commit adds fixes for building with GCC 8. * Since the last Debian upload, there have been major changes to upstream source. * Add cmake as a dependency. * Remove README.debian-build. * Bump debhelper to 11 and standards-version to 4.2.1. * Switch to dpkg-source 3.0 (quilt) format. * Switch to dh variant of debian/rules and remove (now redundant) Makefile, closes: #905811. * Add homepage field to control, closes: #898531. Add aka umoria to description field. * Restore moria.man from previous Debian version, but it will need updating. * Change src/config.cpp to show scores file in /var/games/moria (patch set-scores-path.patch). * Change src/config.cpp to show data files in /usr/lib/games/moria (patch set-data-path.patch). * "Hours" file has gone, so no longer need /etc. * Don't reopen the scores file when recording as we've already dropped permissions (dont-reopen-scores-file.patch). Checksums-Sha1: abe557c30b594ca6e6a007bac447529a9b0515b8 1769 moria_5.7.10+20181022-1.dsc 1a8a318f9beb3eee0b7d1046dbb6c4a128dd8192 397293 moria_5.7.10+20181022.orig.tar.gz 4c2609f54fa3087e46c14fc0a3b570a66fe06a77 49512 moria_5.7.10+20181022-1.debian.tar.xz acbe593a3cbe6e38241a2da2af44144b9337b4c7 1676640 moria-dbgsym_5.7.10+20181022-1_amd64.deb 8ee3c0fd3e38793ef0f5db6f48e6e6a6e1c01ff9 6954 moria_5.7.10+20181022-1_amd64.buildinfo 32e2d7e9a8019a2e3a3cc4c8d951b9b4eff25d78 365296 moria_5.7.10+20181022-1_amd64.deb Checksums-Sha256: f554f784db429b40d63b9f58d8090bcbb02a7fc8388dbbbf6677e4decc556835 1769 moria_5.7.10+20181022-1.dsc 6d06744d34de572a358c11588371348afa5aa081bda5860d7ec3284bcac3cd38 397293 moria_5.7.10+20181022.orig.tar.gz 1018206193a1cf54aadc66c9ff837ddffe2e75db74919bd5d56b0a130da44d0e 49512 moria_5.7.10+20181022-1.debian.tar.xz 458aa22f63ffd4c2a6fc4a554354b8945406128aaf84ac1e56ff4cf7cab469db 1676640 moria-dbgsym_5.7.10+20181022-1_amd64.deb 750140516de5982c4dd0b5ec35ab1fa7c9345f19fce11a4a0cfc44109824c6f5 6954 moria_5.7.10+20181022-1_amd64.buildinfo 8035a9db180d76a626c695ce93f65b9f7a7736c228a86dad8acf3314df035f24 365296 moria_5.7.10+20181022-1_amd64.deb Files: 57e6603cd7e1bbeb355301c27c140901 1769 games optional moria_5.7.10+20181022-1.dsc 89e59f86ea2bb6ceb3def2a2ec48d7e6 397293 games optional moria_5.7.10+20181022.orig.tar.gz 1d4ee236f065cfc125b4ff3c2d0500db 49512 games optional moria_5.7.10+20181022-1.debian.tar.xz 11a5a1afbd59f21f3c4cd6ccf2248e93 1676640 debug optional moria-dbgsym_5.7.10+20181022-1_amd64.deb 1c54614fb8e0eae68685edc5506e0275 6954 games optional moria_5.7.10+20181022-1_amd64.buildinfo 2552dd43fb74e408862fb32b2841f865 365296 games optional moria_5.7.10+20181022-1_amd64.deb -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKCMADj+pj/jrfBAKgZ0nig5vmSoFAlvPGJ0ACgkQgZ0nig5v mSqtCA//Q+ciXpGFI2EUjH40wXQREsZok/DqbXXJb5cs0z6VbGxftYYlYvR1Xzca /BlwAc+VoCSZ5T+MjDLzVNjRA+S27SEa06/FfbC8E7w1p15VaOJj7UipKQGr02FH f6VCdqFmzEVQ1SMu3StrRmcMYXKXFdH95zWPadDp4TOYGO14zsO5ZjA/fBNX8vJF xA5JcBA8Hq0opan2g99niPEljx6h6NJ7QIjMR8MMRsKeM9uwMPNHHNewl7GpZcmV S4ToxFICoVURQi3JqEqY3tTinFq1uFp5sR224CohfxTSH+yz06fB3zAqN6Io59PP y/2ERRdzZkYnS8b5vuOGPIY9Om6LckTv0J9WGyUWsZV3/MOwZfQehIOo7VGaFmcb GjwZt92pWlLy7MnSIdqRxl4b3VjGt+j9xNUVWZp0xebirwW/afbPjGGelO/0OGPb DE482GfQKEAxhOwAJiiGBBmfuK9GF2BQXyjhT43hLMuagDm8dA7lik58+VS387bE hvVAYSGKlHKw4BByH7RG82wp1zmz5W1kk8VxklNe69vqjVKCMBIPtYflOZbNKXqn 6bExVCNxZX1ZDoTjnTZ2e+u8ulnmvghN0eQn1j0+zTDPUwglyM9WBuwRzSXUY5uw 2rAj772C8HEIwrWTrREvww4ak8uFjfB+tYHwteLP7M6ORVrHb+o= =2WrC -----END PGP SIGNATURE-----
--- End Message ---
