Control: retitle -1 prometheus: FTBFS flaky shutdown test
On Sat, Oct 20, 2018 at 2:33 PM Shengjing Zhu <z...@debian.org> wrote: > I'm not sure how this test is related to golang-google-grpc. > And upstream has a similar issue, "Flaky shutdown test" > https://github.com/prometheus/prometheus/issues/4587 > It's not related to golang-google-grpc. After inserting a time.Sleep in the test, I can build it successfully. --- cmd/prometheus/main_test.go.orig 2018-10-20 15:47:14.599840120 +0000 +++ cmd/prometheus/main_test.go 2018-10-20 15:41:37.667943206 +0000 @@ -93,6 +93,7 @@ t.Errorf("prometheus didn't start in the specified timeout") return } + time.Sleep(10 * time.Second) if err := prom.Process.Kill(); err == nil { t.Errorf("prometheus didn't shutdown gracefully after sending the Interrupt signal") } else if stoppedErr != nil && stoppedErr.Error() != "signal: interrupt" { // TODO - find a better way to detect when the process didn't exit as expected! -- Shengjing Zhu
