Your message dated Fri, 12 Oct 2018 09:49:27 +0000
with message-id <e1gau4v-000isg...@fasolo.debian.org>
and subject line Bug#910340: fixed in tpm2-abrmd 1.3.1-1.1
has caused the Debian Bug report #910340,
regarding tpm2-abrmd: FTBFS with GLib 2.58.1: redundant use of AC_PATH_PROG
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
910340: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=910340
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: tpm2-abrmd
Version: 1.3.1-1
Severity: serious
Tags: patch upstream
Justification: fails to build from source
Control: block 909846 by -1
tmp2-abrmd has this pattern in configure.ac:
AC_PATH_PROG([GDBUS_CODEGEN], [`$PKG_CONFIG --variable=gdbus_codegen
gio-2.0`])
This doesn't work with recent versions of GLib, in which the pkg-config
call produces an absolute path. AC_PATH_PROG only accepts a basename for
its second argument.
There is some debate over whether the recommended way to check for tools
like these is to search the PATH:
AC_PATH_PROG([GDBUS_CODEGEN], [gdbus-codegen])
or to ask pkg-config:
PKG_CHECK_VAR([GDBUS_CODEGEN], [gio-2.0], [gdbus_codegen])
but combining AC_PATH_PROG with pkg-config certainly doesn't seem to be
what's intended. Either of those macro invocations would allow the location
to be overridden with "./configure GDBUS_CODEGEN=..." if required.
The upstream developer of tpm2-abrmd already applied a
patch to use AC_PATH_PROG([GDBUS_CODEGEN], [gdbus-codegen]):
https://github.com/tpm2-software/tpm2-abrmd/commit/b4036908dd067f8eadc9d53b1a2a39032aed109d
so I would suggest applying that (attached). I can confirm that applying
that patch fixes the build in sbuild.
smcv
From: Jonas Witschel <diabo...@gmx.de>
Date: Tue, 11 Sep 2018 13:14:36 +0200
Subject: Fix gdbus-codegen lookup for recent versions of GLib
If GLib is built using Meson, the gdbus_codegen variable contains the
whole path to the binary instead of just the binary name. This cannot be
parsed by AC_PATH_PROG and leads to an error in the configure script.
According to https://gitlab.gnome.org/GNOME/glib/issues/1521#note_313402,
the recommended way to solve this is to look up gdbus-codegen directly
without using the pkg-config variable.
Origin: upstream, 2.0.3, commit:b4036908dd067f8eadc9d53b1a2a39032aed109d
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index fe278e3..d1ea91b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -32,7 +32,7 @@ PKG_CHECK_MODULES([GLIB], [glib-2.0])
PKG_CHECK_MODULES([GOBJECT], [gobject-2.0])
PKG_CHECK_MODULES([SAPI],[sapi < 2.0.0])
AC_ARG_VAR([GDBUS_CODEGEN],[The gdbus-codegen executable.])
-AC_PATH_PROG([GDBUS_CODEGEN], [`$PKG_CONFIG --variable=gdbus_codegen gio-2.0`])
+AC_PATH_PROG([GDBUS_CODEGEN], [gdbus-codegen])
if test -z "$GDBUS_CODEGEN"; then
AC_MSG_ERROR([*** gdbus-codegen is required to build tpm2-abrmd])
fi
--- End Message ---
--- Begin Message ---
Source: tpm2-abrmd
Source-Version: 1.3.1-1.1
We believe that the bug you reported is fixed in the latest version of
tpm2-abrmd, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 910...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Simon McVittie <s...@debian.org> (supplier of updated tpm2-abrmd package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 10 Oct 2018 08:46:43 +0100
Source: tpm2-abrmd
Binary: libtcti-tabrmd0 libtcti-tabrmd-dev tpm2-abrmd
Architecture: source
Version: 1.3.1-1.1
Distribution: unstable
Urgency: medium
Maintainer: SZ Lin (林上智) <sz...@debian.org>
Changed-By: Simon McVittie <s...@debian.org>
Description:
libtcti-tabrmd-dev - TPM2 Access Broker & Resource Management - static
libraries and h
libtcti-tabrmd0 - TPM2 Access Broker & Resource Management - shared libraries
tpm2-abrmd - TPM2 Access Broker & Resource Management Daemon
Closes: 910340 910341
Changes:
tpm2-abrmd (1.3.1-1.1) unstable; urgency=medium
.
* Non-maintainer upload.
* d/p/0002-Fix-gdbus-codegen-lookup-for-recent-versions-of-GLib.patch:
Apply patch from upstream to make the build system compatible with
recent GLib versions. In older GLib versions,
`$PKG_CONFIG --variable=gdbus_codegen gio-2.0` always returned
"gdbus-codegen", but in newer versions or when GLib was built with
Meson it returns the absolute path to gdbus-codegen, which is not a
valid input to AC_PATH_PROG. (Closes: #910340)
* d/rules: Use dbus-run-session to give unit tests a temporary
session bus. This means that tss2-tcti-tabrmd_unit does not have to
be skipped. (Closes: #910341)
- d/p/0002-remove-unit-test-needs-dbus-daemon.patch:
Remove, no longer needed
Checksums-Sha1:
45dc0a1192999a5052dcecd925fea81164f4bd56 2197 tpm2-abrmd_1.3.1-1.1.dsc
3d99b02610a9961d9b4c8fe5284a31b779455797 3932
tpm2-abrmd_1.3.1-1.1.debian.tar.xz
33feb7b1d1f6dd863efa1b5fb21983ad3ecddf03 6367
tpm2-abrmd_1.3.1-1.1_source.buildinfo
Checksums-Sha256:
b6220e57edc15ef828e67abc57537f895e20f9ccef32444c299f49655fe66f49 2197
tpm2-abrmd_1.3.1-1.1.dsc
2f26f33ba1cddb8e4f868082a0515260ea3458e8af72828075c39b08b55fed09 3932
tpm2-abrmd_1.3.1-1.1.debian.tar.xz
74831c7164d9331aec08607002ca9b1ca6f3a9ea51ce7d7f77dfc8ecc6741dd1 6367
tpm2-abrmd_1.3.1-1.1_source.buildinfo
Files:
ef0ae12ba82452ccc79b6f4bf2ca4fd2 2197 net optional tpm2-abrmd_1.3.1-1.1.dsc
66aad205f140a022281706be34e6974c 3932 net optional
tpm2-abrmd_1.3.1-1.1.debian.tar.xz
a4d803913a484ef251568c4c917dcfce 6367 net optional
tpm2-abrmd_1.3.1-1.1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEENuxaZEik9e95vv6Y4FrhR4+BTE8FAlu9wOEACgkQ4FrhR4+B
TE+59g/9Fv7+bMlEgdPi6CLck72WMRXOfVx8GCkFOOA3quACdy+2I6VCPrJIwN1C
G0rDTusTwdUYYvMoMDfkecoqV3h2GkyVIsIRYDY64lEMo5eXznIURB4eJ1picOsJ
lByj2DqqVoDjFurRHF3sDfxY6gfPlKNyD/INBdHzQLGTYiAjaZVMdMcZfv2pWGpu
4ArYQGp7pXAiQlIkP42VVK8ZRv6hQX/iakmOGCCjtLug8e7hUz8COgm50itBdKJW
e9fSXNjTGG+g0Vx3z5kQjhe0VKs/u3XcNe7jXcoLPuzA4D2kDhl9+XH/bP9M9/xq
RfsXDBxbyyRdsisVWrabDAD7OT9dYDRYMecHyFo21H1ZKJ4jbABfApMac2csX6Oi
nWVW/tjXGBaKw/vifzuZtBHGWkx+J0IXN+iNgS8PlFkoz557PWKdw8s11f0wvbJ0
+GBM2JGuqpR55QBtNT7jMGpm66mPbtG8qlt0//sjZawe/+aC9SFVnQ/o0P7IZ5VP
VqPL8DTa4cwJMGU9SnziGs2qUi4wUO8WoeTcRZWinf5o16DYlia3LSezQm4y29Lh
c+XRG927E5alIHLjX7jBlMjTVEuAvZGMSVc8k9oVyfNK2CZXnU+pJZ7loTrCFGPI
Q0wcKZYFABNaxOIXH6x6THIevmzOC5GPYR8M3cLplgkALjT2G88=
=6Gns
-----END PGP SIGNATURE-----
--- End Message ---
