Your message dated Fri, 12 Oct 2018 09:49:10 +0000
with message-id <e1gau4e-000iph...@fasolo.debian.org>
and subject line Bug#910342: fixed in playerctl 0.6.1-1.1
has caused the Debian Bug report #910342,
regarding playerctl: FTBFS with GLib 2.58.1: redundant use of AC_PATH_PROG
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
910342: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=910342
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: playerctl
Version: 0.6.1-1
Severity: serious
Tags: patch upstream
Justification: fails to build from source
Control: block 909846 by -1
playerctl has this pattern in configure.ac:
AC_PATH_PROG([GDBUS_CODEGEN], [`$PKG_CONFIG --variable=gdbus_codegen
gio-2.0`])
This doesn't work with recent versions of GLib, in which the pkg-config
call produces an absolute path. AC_PATH_PROG only accepts a basename for
its second argument.
There is some debate over whether the recommended way to check for tools
like these is to search the PATH:
AC_PATH_PROG([GDBUS_CODEGEN], [gdbus-codegen])
or to ask pkg-config:
PKG_CHECK_VAR([GDBUS_CODEGEN], [gio-2.0], [gdbus_codegen])
but combining AC_PATH_PROG with pkg-config certainly doesn't seem to be
what's intended. Either of those macro invocations would allow the location
to be overridden with "./configure GDBUS_CODEGEN=..." if required.
I have confirmed that the attached patch makes playerctl build
successfully in sbuild.
smcv
From: Simon McVittie <s...@debian.org>
Date: Thu, 4 Oct 2018 21:08:27 +0100
Subject: build: Use PKG_CHECK_VAR to check for gdbus-codegen
Recent versions of GLib define $gdbus_codegen to the absolute path to
gdbus-codegen, but AC_PATH_PROG doesn't work for an absolute path as
its second argument, causing configure to fail.
There's actually no need to use AC_PATH_PROG here, because
we don't need an absolute path to gdbus-codegen: if it's just a
basename that AC_PATH_PROG could find in the PATH, then the Makefile
can also find it in the PATH.
Using PKG_CHECK_VAR (from pkg-config 0.28+) preserves the ability for
a user to specify the path to a gdbus-codegen tool as a configure
argument, defaulting to the value of $gdbus_codegen from gio-2.0.pc.
---
configure.ac | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/configure.ac b/configure.ac
index 21679fa..9a137c9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -21,10 +21,8 @@ AC_PROG_INSTALL
PKG_CHECK_MODULES([GOBJECT], [gobject-2.0 >= 2.38])
PKG_CHECK_MODULES([GIO], [gio-unix-2.0])
-AC_PATH_PROG([GDBUS_CODEGEN], [`$PKG_CONFIG --variable=gdbus_codegen gio-2.0`])
-if test -z "$GDBUS_CODEGEN"; then
- AC_MSG_ERROR([*** gdbus-codegen is required to build playerctl])
-fi
+PKG_CHECK_VAR([GDBUS_CODEGEN], [gio-2.0], [gdbus_codegen], [],
+ [AC_MSG_ERROR([*** gdbus-codegen is required to build playerctl])])
# Checks for typedefs, structures, and compiler characteristics
AC_PROG_CC_STDC
--- End Message ---
--- Begin Message ---
Source: playerctl
Source-Version: 0.6.1-1.1
We believe that the bug you reported is fixed in the latest version of
playerctl, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 910...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Simon McVittie <s...@debian.org> (supplier of updated playerctl package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 10 Oct 2018 09:09:00 +0100
Source: playerctl
Binary: playerctl libplayerctl-1.0-0 libplayerctl-dev libplayerctl-doc
gir1.2-playerctl-1.0
Architecture: source
Version: 0.6.1-1.1
Distribution: unstable
Urgency: medium
Maintainer: Nick Morrott <knowledgejun...@gmail.com>
Changed-By: Simon McVittie <s...@debian.org>
Description:
gir1.2-playerctl-1.0 - utility to control media players via MPRIS (gir
bindings)
libplayerctl-1.0-0 - utility to control media players via MPRIS (library)
libplayerctl-dev - utility to control media players via MPRIS (development
files)
libplayerctl-doc - utility to control media players via MPRIS (documentation)
playerctl - utility to control media players via MPRIS
Closes: 910342
Changes:
playerctl (0.6.1-1.1) unstable; urgency=medium
.
* Non-maintainer upload.
* d/p/build-Use-PKG_CHECK_VAR-to-check-for-gdbus-codegen.patch:
Use PKG_CHECK_VAR to check for gdbus-codegen.
This is the upstream-recommended pattern for detecting gdbus-codegen
in an Autotools build system, and it fixes failure to build from source
with recent versions of GLib, in which
`$PKG_CONFIG --variable=gdbus_codegen gio-2.0` returns an absolute
path that is not a valid input to AC_PATH_PROG. (Closes: #910342)
Checksums-Sha1:
b2bfb45483e9386af17d3b1c920256db25a052c2 2231 playerctl_0.6.1-1.1.dsc
e6727d3df3938ffd121145b3a4b7ace602f325b4 4992 playerctl_0.6.1-1.1.debian.tar.xz
afdb3aa4606aa1dfeadb2b9cdd79a9eae64129f9 8394
playerctl_0.6.1-1.1_source.buildinfo
Checksums-Sha256:
b0e238b9ef0d378e48f6c274d3de9b134433b6f4ff9555e3cce81f0111ad9d24 2231
playerctl_0.6.1-1.1.dsc
e494edf2c2a39c11d863fa56c0d7c5314eb7f5a29f8b478334c131bae0b6b5a1 4992
playerctl_0.6.1-1.1.debian.tar.xz
0bcaaf683e3506a64ec1d18a669fc88595d3d90dc0f3be8f03ad92e063797667 8394
playerctl_0.6.1-1.1_source.buildinfo
Files:
0163fa7e1f9e47820fddab5a661a5c27 2231 sound optional playerctl_0.6.1-1.1.dsc
0552343b4ac5cd28d95b58b26e5a54ab 4992 sound optional
playerctl_0.6.1-1.1.debian.tar.xz
451cf23577c516154dd3c74d6e8e0a0b 8394 sound optional
playerctl_0.6.1-1.1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEENuxaZEik9e95vv6Y4FrhR4+BTE8FAlu9v/IACgkQ4FrhR4+B
TE+GdA//WNwQs73QXtoR7b5o88fofDkcYQrjEUcz/efbwfxYBJIsfcTyoRm7YEUT
eFuF/ztPGaWK3X8iFvRhlKbxYS4xtatv30kbFt66sNLAuc4hJu6+q1QTDlpKWrvS
GA2uarVMakBewrX1+e+/nsQRGu9b2PiDzbQK7MD20sqx6DUSocMdJayAu/T1ynTF
ekHGcB/buvDSlDJuaQF0u+WHOyGL4cMvREsyM/i9yu+DxfQMySTamx1hmIaqqjAi
iXNi/vpOtj6m+vl+PHhnt0x3GLcmaENzV/Yi7mPuMYHlFctGH9zt0ZuHQ6jmT80u
KLnzoanwCixkEViYtIPq4rQf9cXZZFEvgBV0Kw+XLP52ANs8QKxSQA8iZtbm7ECC
HNNXg9WDRQyyLKdtMCaY+ySl7Lh5pcnQOzUgeDa35YSus3DjrF4TtU1ew0ZTj9pD
ViY1WZQVG2+gixTkpysp4aUuHkFPdMk69FHRL9ooILt5SAtFId7jEuZmXKoPLAEG
MLZWtatVDjI11GmxHiFFwYrZselPmJ2Vg3fdVUvY5uddgZ7K7MYYW+D8ZMoFP25C
V5F/yu7lSfTw6FphI0U+12CM+InkPv/ajoFakJi2YfM3oG3Q82ORafiapvM/npJi
4GcK1fO9HYW30+S896jWvFl23HKFodjt6x4qa4GAH3ARf6CNa8s=
=B4rA
-----END PGP SIGNATURE-----
--- End Message ---
