Control: severity -1 serious Hi!
On Mon, 2018-10-01 at 14:47:09 +0200, Vincent Lefevre wrote: > Control: reassign -1 dpkg 1.19.1 > Control: retitle -1 dpkg execs $PAGER with execvp instead of sh -c, yielding > upgrade failure > As a summary, when a pager needs to be invoked (e.g. for the > conffile difference visualizer), one gets an upgrade failure > if $PAGER contains the program name + options, as specified > by POSIX. Nice catch! Thanks for the analysis. > On 2018-10-01 14:12:20 +0200, Vincent Lefevre wrote: > > On 2018-10-01 14:08:17 +0200, Vincent Lefevre wrote: > > > A possible bug might be that $PAGER is run as a program name, > > > instead of something like system(), which allows options. > > > > Hmm... I can see in /usr/share/doc/dpkg/changelog.Debian.gz that > > there have been pager-related changes in dpkg 1.19.1 (26 Sep 2018). > > The bug might actually be there. > > Indeed, after a quick look at the code (pager_spawn in lib/dpkg/pager.c > and lib/dpkg/command.c code), this seems to be the case. I've queued a patch fixing this, which I'll be uploding around Wednesday with dpkg 1.19.2. Although this will temporarily get in the way of making the pager presence detection harder, but I'll improve that later on. Thanks, Guillem
