clone 909089 -1 notfound -1 11.4 reassign -1 src:gforth retitle -1 [src:gforth] Installs the gforth package files into the wrong directory found -1 0.7.3+dfsg-1 severity 909089 minor retitle 909089 [debhelper] Actually exposes long-standing bugs in source packages thanks
On Wed, Sep 19, 2018 at 06:15:00AM +0000, Niels Thykier wrote:
> Sven Joachim:
> > On 2018-09-18 14:09 +0300, Peter Pentchev wrote:
> >
> >> Package: debhelper
> >> Version: 11.4
> >> Severity: serious
> >>
> >> Hi,
> >>
> >> Thanks for maintaining and extending debhelper!
> >>
> >> I don't have much information right now, maybe I'll look into it in
> >> the evening (Eastern European time), but trying to build gforth in
> >> a chroot containing debhelper-11.4 results in a package where all
> >> the paths passed to the GNU configure script as "\$prefix/something"
> >> are actually defined as "/something", thus placing binaries in /bin,
> >> include files in /include, etc. Installing debhelper-11.3.5 fixes
> >> the problem.
> >
> > Bisection shows that commit a7ec05c10093f ("dh: Track which options have
> > been passed") has triggered the problem. I had a look at the gforth
> > build logs with debhelper 11.3.5 and 11.4, but could not spot an obvious
> > cause. Maybe Niels has more luck.
> >
> > Cheers,
> > Sven
Thanks a lot for taking the time to look into this! However, see below...
>
> Hi,
>
> @Sven: Thanks for bisecting it. FTR, which version of gforth did you
> test with?
[snip]
> @Peter: Could you try to add a "dh_installdirs" (or mkdir -p $(DG)/)
> before the following line?
>
> mv /<<PKGBUILDDIR>>/debian/tmp/* /<<PKGBUILDDIR>>/debian/gforth/
Of course you are right... :)
Actually the "culprit" was b4d25f15, "dh: Remove broken (and obsolete)
compat item" - the change that dropped the "create package build dirs if
a command is skipped" functionality and, well, exposed bugs in source
packages that depended on it.
My bad; I do make a point of reading the "vXX" notes in the debhelper
manual page before I bump the compat level of each of my packages and
thinking whether any of these affect the package in question, and I
guess I did not realize that this change really affects
gforth-0.7.3+dfsg-1 where I bumped the compat level to 10 *immediately
after* introducing the "install into the temp directory and then move
files to the actual package build dirs if needed so that we can properly
build both arch-indep and arch-dep packages". It really was immediately
afterwards... and I completely missed it. Of course, it didn't break
back then, but that's no excuse :)
Sorry for raising a serious bug, and thanks A LOT for taking a look at
it quickly and figuring out what the problem was! Feel free to close
this bug, since it is really not a bug in debhelper, but in any other
source packages; of course, feel free to also use it as reference if
anybody else comes screaming "debhelper 11.4 broke my package and I did
not change anything, I swear!" :)
So, yeah, thanks again to everyone who chimed in, sorry for the
confusion, and keep up the great work!
G'luck,
Peter
--
Peter Pentchev roam@{ringlet.net,debian.org,FreeBSD.org} p...@storpool.com
PGP key: http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13
signature.asc
Description: PGP signature
