On Sun, Aug 19, 2018 at 08:29:44AM +0200, Micha Lenk wrote:
> Hi Adrian,
Hi Micha,
> thank you for your feedback.
>
> Am 19.08.2018 um 01:03 schrieb Adrian Bunk:
> > On Sun, Aug 19, 2018 at 12:17:51AM +0200, Micha Lenk wrote:
> >> ...
> >> --- a/src/plugins/backends/aqhbci/plugin/Makefile.am
> >> +++ b/src/plugins/backends/aqhbci/plugin/Makefile.am
> >> @@ -77,6 +77,7 @@ testlib_LDADD = \
> >> $(aqhbci_internal_libs) \
> >> $(aqbanking_internal_libs) \
> >> $(gwenhywfar_libs)
> >> +testlib_DEPENDENCIES = libaqhbci.la
> >> ...
> >
> > A better fix would be s/$(aqhbci_internal_libs)/libaqhbci.la/
>
> I would like to learn something. Why would using libaqhbci.la directly
> be better than using the $(aqhbci_internal_libs variable)?
configure.ac:
aqhbci_internal_libs="${abs_top_builddir}/src/plugins/backends/aqhbci/plugin/libaqhbci.la"
For libtool/automake this means "link with an already built library in
another directory".
Dependencies between directories are handled through the order in SUBDIRS.
But when the library is built in the same directory, there are no
dependencies "build the library first" created. This was always a
bug waiting to explode with parallel building, but in this case
automake 1.16 seems to trigger a reshuffle of the build order.
libaqhbci.la means "link with the library that has to be built first".
> Maybe there
> are some more places where some cleanup would be appropriate.
libaqhbciplugin_la_LIBADD already uses libaqhbci.la,
so that should be fine.
> Regards,
> Micha
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
