Your message dated Thu, 26 Jul 2018 08:46:13 +0000
with message-id <e1fibux-000imu...@fasolo.debian.org>
and subject line Bug#872413: fixed in kpatch 0.6.0-0.1
has caused the Debian Bug report #872413,
regarding kpatch: Please package new upstream version
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
872413: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=872413
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: kpatch
Version: 0.3.2-3.1
Severity: normal
Tags: patch
Hello,
The version of kpatch in Sid is quite old and doesn't work with
the current kernel. Please consider updating to the latest
upstream version. However it seems that 0.4.0 (latest release) is
not recent enough, so consider using the latest Git version (e.g.
4b2f20e) which works fine me.
The attached patch performs the update to 0.4.0+git4b2f20e and
works fine here (Sid and Stretch). It also adds a few minor
changes to better suit current upstream:
- Upstream uses the kernel's LIVEPATCH per default and only falls
back to its own kpatch.ko module if LIVEPATCH is not available.
As LIVEPATCH is supported since Stretch, my patch removes the
dependency on kpatch-dkms as kpatch works fine without it and
users of older kernels can install it manully if necessary. Not
depending on dkms (and thus a compiler) is a nice feature.
- Remove patches which are no longer required:
create-diff-object-fix-WARN-_ONCE-detection-on-newer.patch
kmod-core-use-save_stack_trace_tsk-backport.patch
- Update existing patches to apply.
- Add patch to fix uname -p (which always returns unknown on my
systems); I think this should be upstreamed.
fix-uname-p.patch
- Add patch to respect CPPFLAGS. Should be upstreamed as well.
respect-cppflags.patch
- Updates post-dkms.sh which was failing for me. It builds and
installs fine, but I didn't test it thoroughly and the comment
from the other bug still applies I think. Maybe the -dkms part
should be removed completely as upstream is switching to
LIVEPATCH (and will drop kpatch.ko in the future).
Please also consider making a backport for Stretch (package can
be backported without any issues) as the kpatch version in
Stretch doesn't work with the kernel in Stretch making it rather
useless. The Git version works fine with the Stretch kernel.
Regards
Simon
--
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
diff -u -N -r kpatch-0.3.2/debian/control kpatch-0.4.0+git4b2f20e/debian/control
--- kpatch-0.3.2/debian/control 2016-06-27 21:03:09.000000000 +0200
+++ kpatch-0.4.0+git4b2f20e/debian/control 2017-08-14 12:07:25.497788719
+0200
@@ -10,8 +10,7 @@
Package: kpatch
Architecture: linux-amd64
-Depends: ${shlibs:Depends}, ${misc:Depends}, kpatch-dkms,
- linux-headers-amd64 | linux-headers-generic
+Depends: ${shlibs:Depends}, ${misc:Depends}, binutils
Description: Runtime tools for Kpatch
kpatch is a Linux dynamic kernel patching tool which allows you to patch a
running kernel without rebooting or restarting any processes. It enables
@@ -22,7 +21,8 @@
Package: kpatch-dkms
Architecture: linux-amd64
-Depends: ${shlibs:Depends}, ${misc:Depends}, dkms
+Depends: ${shlibs:Depends}, ${misc:Depends}, dkms,
+ linux-headers-amd64 | linux-headers-generic
Description: DKMS module for Kpatch
This package contains the Kpatch module built with DKMS. It installs the
source
and makefiles into the appropriate locations in order to handle various kernel
diff -u -N -r kpatch-0.3.2/debian/patches/fix-uname-p.patch
kpatch-0.4.0+git4b2f20e/debian/patches/fix-uname-p.patch
--- kpatch-0.3.2/debian/patches/fix-uname-p.patch 1970-01-01
01:00:00.000000000 +0100
+++ kpatch-0.4.0+git4b2f20e/debian/patches/fix-uname-p.patch 2017-08-12
12:43:07.884688093 +0200
@@ -0,0 +1,18 @@
+Description: detect architecture properly
+ uname -p returns unknown for unknown reasons. uname -m seems to work
+Author: Simon Ruderich <si...@ruderich.org>
+Last-Update: 2017-08-11
+
+Index: kpatch-0.4.0.g4b2f20e/Makefile.inc
+===================================================================
+--- kpatch-0.4.0.g4b2f20e.orig/Makefile.inc
++++ kpatch-0.4.0.g4b2f20e/Makefile.inc
+@@ -3,7 +3,7 @@ CC = gcc
+
+ INSTALL = /usr/bin/install
+
+-ARCH = $(shell uname -p)
++ARCH = $(shell uname -m)
+
+ PREFIX ?= /usr/local
+ LIBDIR ?= lib
diff -u -N -r kpatch-0.3.2/debian/patches/kpatch-build-adjust-dirs.patch
kpatch-0.4.0+git4b2f20e/debian/patches/kpatch-build-adjust-dirs.patch
--- kpatch-0.3.2/debian/patches/kpatch-build-adjust-dirs.patch 2016-02-18
17:46:39.000000000 +0100
+++ kpatch-0.4.0+git4b2f20e/debian/patches/kpatch-build-adjust-dirs.patch
2017-08-11 23:32:54.551552778 +0200
@@ -3,26 +3,37 @@
paths to adjust for this. In addition the debian packaging uses /usr/lib
instead of /usr/libexec for internal binaries.
Author: Chris J Arges <chris.j.ar...@canonical.com>
-Last-Update: 2016-01-08
+Last-Update: 2017-08-11
---- a/kpatch-build/kpatch-build
-+++ b/kpatch-build/kpatch-build
-@@ -99,14 +99,14 @@
+Index: kpatch-0.4.0.g4b2f20e/kpatch-build/kpatch-build
+===================================================================
+--- kpatch-0.4.0.g4b2f20e.orig/kpatch-build/kpatch-build
++++ kpatch-0.4.0.g4b2f20e/kpatch-build/kpatch-build
+@@ -121,9 +121,9 @@ find_dirs() {
+ # git repo
+ TOOLSDIR="$SCRIPTDIR"
DATADIR="$(readlink -f $SCRIPTDIR/../kmod)"
- SYMVERSFILE="$DATADIR/core/Module.symvers"
- return
- elif [[ -e "$SCRIPTDIR/../libexec/kpatch/create-diff-object" ]]; then
+ elif [[ -e "$SCRIPTDIR/../lib/kpatch/create-diff-object" ]]; then
# installation path
- TOOLSDIR="$(readlink -f $SCRIPTDIR/../libexec/kpatch)"
+ TOOLSDIR="$(readlink -f $SCRIPTDIR/../lib/kpatch)"
DATADIR="$(readlink -f $SCRIPTDIR/../share/kpatch)"
+ else
+ return 1
+@@ -135,12 +135,12 @@ find_core_symvers() {
+ if [[ -e "$SCRIPTDIR/create-diff-object" ]]; then
+ # git repo
+ SYMVERSFILE="$DATADIR/core/Module.symvers"
+- elif [[ -e "$SCRIPTDIR/../libexec/kpatch/create-diff-object" ]]; then
++ elif [[ -e "$SCRIPTDIR/../lib/kpatch/create-diff-object" ]]; then
+ # installation path
if [[ -e $SCRIPTDIR/../lib/kpatch/$ARCHVERSION/Module.symvers
]]; then
SYMVERSFILE="$(readlink -f
$SCRIPTDIR/../lib/kpatch/$ARCHVERSION/Module.symvers)"
- elif [[ -e
/lib/modules/$ARCHVERSION/extra/kpatch/Module.symvers ]]; then
- SYMVERSFILE="$(readlink -f
/lib/modules/$ARCHVERSION/extra/kpatch/Module.symvers)"
+ elif [[ -e
/lib/modules/$ARCHVERSION/updates/dkms/kpatch.Module.symvers ]]; then
+ SYMVERSFILE="$(readlink -f
/lib/modules/$ARCHVERSION/updates/dkms/kpatch.Module.symvers)"
- else
- warn "unable to find Module.symvers for kpatch core
module"
- return 1
+ fi
+ fi
+
diff -u -N -r kpatch-0.3.2/debian/patches/respect-cppflags.patch
kpatch-0.4.0+git4b2f20e/debian/patches/respect-cppflags.patch
--- kpatch-0.3.2/debian/patches/respect-cppflags.patch 1970-01-01
01:00:00.000000000 +0100
+++ kpatch-0.4.0+git4b2f20e/debian/patches/respect-cppflags.patch
2017-08-11 23:52:44.050643466 +0200
@@ -0,0 +1,26 @@
+Description: apply CPPFLAGS
+Author: Simon Ruderich <si...@ruderich.org>
+Last-Update: 2017-08-11
+
+Index: kpatch-0.4.0.g4b2f20e/kpatch-build/Makefile
+===================================================================
+--- kpatch-0.4.0.g4b2f20e.orig/kpatch-build/Makefile
++++ kpatch-0.4.0.g4b2f20e/kpatch-build/Makefile
+@@ -20,7 +20,7 @@ all: $(TARGETS)
+ -include $(SOURCES:.c=.d)
+
+ %.o : %.c
+- $(CC) -MMD -MP $(CFLAGS) -c -o $@ $<
++ $(CC) -MMD -MP $(CPPFLAGS) $(CFLAGS) -c -o $@ $<
+
+ create-diff-object: create-diff-object.o kpatch-elf.o \
+ lookup.o $(INSN)
+@@ -28,7 +28,7 @@ create-klp-module: create-klp-module.o k
+ create-kpatch-module: create-kpatch-module.o kpatch-elf.o
+
+ $(TARGETS):
+- $(CC) $(CFLAGS) $^ -o $@ $(LDFLAGS)
++ $(CC) $(CPPFLAGS) $(CFLAGS) $^ -o $@ $(LDFLAGS)
+
+ install: all
+ $(INSTALL) -d $(LIBEXECDIR)
diff -u -N -r kpatch-0.3.2/debian/patches/series
kpatch-0.4.0+git4b2f20e/debian/patches/series
--- kpatch-0.3.2/debian/patches/series 2017-04-01 21:03:23.000000000 +0200
+++ kpatch-0.4.0+git4b2f20e/debian/patches/series 2017-08-11
23:44:45.861490807 +0200
@@ -1,4 +1,3 @@
kpatch-build-adjust-dirs.patch
-kpatch-build-works-without-kpatch-kmod.patch
-create-diff-object-fix-WARN-_ONCE-detection-on-newer.patch
-kmod-core-use-save_stack_trace_tsk-backport.patch
+fix-uname-p.patch
+respect-cppflags.patch
diff -u -N -r kpatch-0.3.2/debian/post-dkms.sh
kpatch-0.4.0+git4b2f20e/debian/post-dkms.sh
--- kpatch-0.3.2/debian/post-dkms.sh 2016-02-18 17:46:39.000000000 +0100
+++ kpatch-0.4.0+git4b2f20e/debian/post-dkms.sh 2017-08-12 12:56:28.914680838
+0200
@@ -1,4 +1,5 @@
#!/bin/bash
module_version=$1
kernelver=$2
+mkdir -p /lib/modules/$kernelver/updates/dkms
cp /var/lib/dkms/kpatch/$module_version/build/kmod/core/Module.symvers
/lib/modules/$kernelver/updates/dkms/kpatch.Module.symvers
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: kpatch
Source-Version: 0.6.0-0.1
We believe that the bug you reported is fixed in the latest version of
kpatch, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 872...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Nobuhiro Iwamatsu <iwama...@debian.org> (supplier of updated kpatch package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 16 Jun 2018 07:23:46 +0900
Source: kpatch
Binary: kpatch kpatch-dkms kpatch-build
Architecture: source amd64
Version: 0.6.0-0.1
Distribution: unstable
Urgency: medium
Maintainer: Chris J Arges <chris.j.ar...@canonical.com>
Changed-By: Nobuhiro Iwamatsu <iwama...@debian.org>
Description:
kpatch - Runtime tools for Kpatch
kpatch-build - Build Tools for Kpatch and Livepatch
kpatch-dkms - DKMS module for Kpatch
Closes: 872413
Changes:
kpatch (0.6.0-0.1) unstable; urgency=medium
.
[Simon Ruderich]
* Non-maintainer upload.
* New upstream release. (Closes: #872413)
.
[Nobuhiro Iwamatsu]
* Add patches/Fix-build-err-by-Werror-maybe-uninitialized.patch.
Checksums-Sha1:
04e0f45a0776e5d7c2e67ed772b2e1e52626f94a 1982 kpatch_0.6.0-0.1.dsc
2f24d05a30148950959b30fcbae0697e96bd240f 113168 kpatch_0.6.0.orig.tar.xz
1e4ee9837e09407daab72b79506e47969104567f 7060 kpatch_0.6.0-0.1.debian.tar.xz
54204b00e6cd3496dbab6293ca313240f19ea167 127304
kpatch-build-dbgsym_0.6.0-0.1_amd64.deb
cea4e25d945ef74ac037f533a5823c117e30dc14 52868 kpatch-build_0.6.0-0.1_amd64.deb
4bc4d0c5b087b61367fe9aaa92bd9b9cda3e321d 13172 kpatch-dkms_0.6.0-0.1_amd64.deb
8e4952cfa09ec05ea2bbf524bd01900acf097a83 6443 kpatch_0.6.0-0.1_amd64.buildinfo
7b606e04ebd4a75d5f5b3c1128fd1217593cf45e 16008 kpatch_0.6.0-0.1_amd64.deb
Checksums-Sha256:
1c7262552eca1c05856a8ab02e8581da08ec35b1731b77a2808a6a40bc13dd77 1982
kpatch_0.6.0-0.1.dsc
ad11503aeb4d32e25f28884075778f688697be4e45d643cdaa743345ee1f26b7 113168
kpatch_0.6.0.orig.tar.xz
6e59545dcbb4560a17bfa531429f09271f111dcbe8724a2498229c8cf6654c7e 7060
kpatch_0.6.0-0.1.debian.tar.xz
82e421dbd5bf49429eca23f3f682557c9cd0f32d4b8d1d40accd5a26108be80d 127304
kpatch-build-dbgsym_0.6.0-0.1_amd64.deb
f9a2a3239308e8682c1cbab08fc279dd5e26b743bf5767fa89aa87ef7692cf25 52868
kpatch-build_0.6.0-0.1_amd64.deb
3fbe3bd2395ddb1f18d42183a4beb8bad28cc527126bf3e60d14782bf65a9dbb 13172
kpatch-dkms_0.6.0-0.1_amd64.deb
1369803c361d6d1b9463d4d788e96e706d9fe498b04d8d2b4d8e3d72f5ab13f4 6443
kpatch_0.6.0-0.1_amd64.buildinfo
64906cbb8a7e1b9ac5da46444d459be813f066257d086993b254bbd500df7660 16008
kpatch_0.6.0-0.1_amd64.deb
Files:
3546cf7ef9f15fd3b5486a5b5188444b 1982 kernel optional kpatch_0.6.0-0.1.dsc
36de7739c63bc5b3acf85956fe4d3d05 113168 kernel optional
kpatch_0.6.0.orig.tar.xz
2cd54c3e63e25c417c79c02c51ecb016 7060 kernel optional
kpatch_0.6.0-0.1.debian.tar.xz
96d37fb3c5037444142eab313ac5c96f 127304 debug optional
kpatch-build-dbgsym_0.6.0-0.1_amd64.deb
7356681f5c3379da77f20af2eae4fe35 52868 kernel optional
kpatch-build_0.6.0-0.1_amd64.deb
cf83b7887960f70c19c545d26cf11d56 13172 kernel optional
kpatch-dkms_0.6.0-0.1_amd64.deb
3493b92fe52ee2eb8e9208cd322df100 6443 kernel optional
kpatch_0.6.0-0.1_amd64.buildinfo
61fd5ba1ec57fbb2ff9ca44becadddd6 16008 kernel optional
kpatch_0.6.0-0.1_amd64.deb
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEXmKe5SMhlzV7hM9DMiR/u0CtH6YFAltMSYkACgkQMiR/u0Ct
H6apXA/+OhBtcVhCoBWyWjHEoKCDrQGk+FEVEpOp+usczCAxhnackvDmENngqR2X
45UFnT8xSP57XjzYkzxYks45IG3VB50W4slZQgBiDif0fiT1u5UjIQDK0oGKicEH
Lw1Ia+ikilyknEA0Vy3gM6Mfwh6IafR9rGrTYIHP+oz5Q+z3QXGGnhbYnPG1i7GG
5jEHh+kZWLoHJ/r55YtUQ1vhH/27i6RIDtebtMZkMgH2BjGMylFOhEvO3SyO3CVt
VXhML0fEVwZMvUhLJdESmafYb6j5taakTHFpkA30nqtefwdtHagznaouabAW6Kq2
M/8B9lXbMMV4Av0N5JUNxm62Yy3Tr5KY2FT3FHeXYW9GPMSHNfi1oFuJt78kF4Hr
DgM6XSwd8AfxHH9GbFgtbVpYpejw2NqBy4sxyM2Qa69AWGU3dJUZHb8kHzj0BUzj
S+o1AwljStC0w+/W7raPmZvRS7KX5wu2Ijb0ld4dIav69z2AKab8Uy743jvI+Ndt
LWINDK0Jp+PpGo3NN9jg5nhmlnqY/FBTjHUTlfQsFsZQBsKfIYGhUor+v8Phlvtj
1ffLCtgVUqy5xwbHzuYTd9DljkpOgzqYLM42GQG+zx/f/Zou1aglcwiL/UojS+Ar
ohZ54PZ7DWS6pTqCuEtzrU079h/6/e/T+5G2toAvyan6S8q8G7w=
=P/wA
-----END PGP SIGNATURE-----
--- End Message ---
