Your message dated Sun, 08 Jul 2018 13:19:28 +0000
with message-id <e1fc9b6-0005w4...@fasolo.debian.org>
and subject line Bug#903146: fixed in libgit2-glib 0.26.4-1
has caused the Debian Bug report #903146,
regarding libgit2-glib: compatibility with libgit2 0.27 in experimental
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
903146: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=903146
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: libgit2-glib
Version: 0.26.2-1
Severity: serious
Tags: patch experimental
Justification: FTBFS
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu cosmic ubuntu-patch
Dear maintainers,
libgit2-glib fails to build against libgit2 0.27, which is currently in
experimental, due to an API change:
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I.. -I. -pthread -I/usr/in
clude/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include -DGIT
_SSH=1 -Wall -Wstrict-prototypes -Wnested-externs -Werror=missing-prototypes -We
rror=implicit-function-declaration -Werror=pointer-arith -Werror=init-self -Werr
or=format-security -Werror=format=2 -Werror=missing-include-dirs -Werror=return-
type -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=
. -fstack-protector-strong -Wformat -Werror=format-security -c ggit-cred.c -fPI
C -DPIC -o .libs/ggit-cred.o
ggit-config.c: In function ‘ggit_config_add_file’:
ggit-config.c:298:36: warning: passing argument 4 of ‘git_config_add_file_ondisk
’ makes pointer from integer without a cast [-Wint-conversion]
force);
^~~~~
In file included from /usr/include/git2.h:22:0,
from ggit-config.h:26,
from ggit-config.c:21:
/usr/include/git2/config.h:208:17: note: expected ‘const git_repository * {aka c
onst struct git_repository *}’ but argument is of type ‘gboolean {aka int}’
GIT_EXTERN(int) git_config_add_file_ondisk(
^~~~~~~~~~~~~~~~~~~~~~~~~~
ggit-config.c:295:8: error: too few arguments to function ‘git_config_add_file_o
ndisk’
ret = git_config_add_file_ondisk (_ggit_native_get (config),
^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/git2.h:22:0,
from ggit-config.h:26,
from ggit-config.c:21:
/usr/include/git2/config.h:208:17: note: declared here
GIT_EXTERN(int) git_config_add_file_ondisk(
^~~~~~~~~~~~~~~~~~~~~~~~~~
/bin/bash ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I..
-I.. -I.. -I. -pthread -I/usr/include/glib-2.0
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include -DGIT_SSH=1 -Wall
-Wstrict-prototypes -Wnested-externs -Werror=missing-prototypes
-Werror=implicit-function-declaration -Werror=pointer-arith -Werror=init-self
-Werror=format-security -Werror=format=2 -Werror=missing-include-dirs
-Werror=return-type -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -c -o ggit-cred-plaintext.lo ggit-cred-plaintext.c
Makefile:780: recipe for target 'ggit-config.lo' failed
make[4]: *** [ggit-config.lo] Error 1
https://launchpad.net/ubuntu/+source/libgit2-glib/0.26.2-1build1/+build/15063247
Please find attached a one-line patch that fixes libgit2-glib for
compatibility with the new libgit2.
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -Nru libgit2-glib-0.26.2/debian/patches/libgit2-0.27-compat.patch
libgit2-glib-0.26.2/debian/patches/libgit2-0.27-compat.patch
--- libgit2-glib-0.26.2/debian/patches/libgit2-0.27-compat.patch
1969-12-31 16:00:00.000000000 -0800
+++ libgit2-glib-0.26.2/debian/patches/libgit2-0.27-compat.patch
2018-07-06 17:24:47.000000000 -0700
@@ -0,0 +1,19 @@
+Description: Compatibility with libgit2 0.27
+ git_config_add_file_ondisk() now takes an additional (optional) 'repo'
+ argument. Fix the build failure.
+Author: Steve Langasek <steve.langa...@ubuntu.com>
+Forwarded: no
+Last-Update: 2018-07-07
+
+Index: libgit2-glib-0.26.2/libgit2-glib/ggit-config.c
+===================================================================
+--- libgit2-glib-0.26.2.orig/libgit2-glib/ggit-config.c
++++ libgit2-glib-0.26.2/libgit2-glib/ggit-config.c
+@@ -295,6 +295,7 @@
+ ret = git_config_add_file_ondisk (_ggit_native_get (config),
+ path,
+ (git_config_level_t)level,
++ NULL,
+ force);
+ g_free (path);
+
diff -Nru libgit2-glib-0.26.2/debian/patches/series
libgit2-glib-0.26.2/debian/patches/series
--- libgit2-glib-0.26.2/debian/patches/series 1969-12-31 16:00:00.000000000
-0800
+++ libgit2-glib-0.26.2/debian/patches/series 2018-07-06 17:23:15.000000000
-0700
@@ -0,0 +1 @@
+libgit2-0.27-compat.patch
--- End Message ---
--- Begin Message ---
Source: libgit2-glib
Source-Version: 0.26.4-1
We believe that the bug you reported is fixed in the latest version of
libgit2-glib, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 903...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Simon McVittie <s...@debian.org> (supplier of updated libgit2-glib package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 08 Jul 2018 13:58:00 +0100
Source: libgit2-glib
Binary: libgit2-glib-1.0-0 libgit2-glib-1.0-dev libgit2-glib-1.0-doc
gir1.2-ggit-1.0
Architecture: source
Version: 0.26.4-1
Distribution: unstable
Urgency: medium
Maintainer: Debian GNOME Maintainers
<pkg-gnome-maintain...@lists.alioth.debian.org>
Changed-By: Simon McVittie <s...@debian.org>
Description:
gir1.2-ggit-1.0 - GObject introspection data for the git2-glib-1.0 library
libgit2-glib-1.0-0 - glib wrapper library around the libgit2 git access library
libgit2-glib-1.0-dev - glib wrapper library around the libgit2 git access
library - deve
libgit2-glib-1.0-doc - glib wrapper library around the libgit2 git access
library - docu
Closes: 829841 903146
Changes:
libgit2-glib (0.26.4-1) unstable; urgency=medium
.
* Team upload
.
[ Jeremy Bicha ]
* New upstream release
- No longer uses gnome-common (Closes: #829841)
* Build with meson
* Drop obsolete debian/source/options
* Bump Standards-Version to 4.1.4
.
[ Simon McVittie ]
* d/p/libgit2-0.27-compat.patch:
Add patch from Steve Langasek to adapt to libgit2 0.27's API,
modified so that we can build against either libgit2 0.26 or 0.27
and so will only need a binNMU for the transition (Closes: #903146)
Checksums-Sha1:
1a113e2dd80dcba9fdb362ff2b476422d8bcad41 2426 libgit2-glib_0.26.4-1.dsc
aa71685615af8187c1dabcbfd403532519f87141 138492 libgit2-glib_0.26.4.orig.tar.xz
0f813b58623a5739821d9ad0750c44cb63c20670 8556
libgit2-glib_0.26.4-1.debian.tar.xz
6bc3140960988d291fbad08ba94253c5c9d9528d 8756
libgit2-glib_0.26.4-1_source.buildinfo
Checksums-Sha256:
094a85a0d8eebc18cef41d202564d714f35f929f82314fad20e41e7de5e2702e 2426
libgit2-glib_0.26.4-1.dsc
97610e42427a0c86ac46b89d5020fb8decb39af47b9dc49f8d078310b4c21e5a 138492
libgit2-glib_0.26.4.orig.tar.xz
9834f21b1ce600a23fe677c749a16d945a32479466f376d1008a85496b8a6e0a 8556
libgit2-glib_0.26.4-1.debian.tar.xz
4d50965941d81062c5f7c61ddd5f808ba321730e7146343ffc3da217d42b7742 8756
libgit2-glib_0.26.4-1_source.buildinfo
Files:
5f0761617a58de75f90f071de3c89c65 2426 libs optional libgit2-glib_0.26.4-1.dsc
042bbee8f440adacd0532c1e2f389d52 138492 libs optional
libgit2-glib_0.26.4.orig.tar.xz
76b43ca9456996e98459f05b944af480 8556 libs optional
libgit2-glib_0.26.4-1.debian.tar.xz
93afc4d44b7cf9d5ae238f60f0e077ab 8756 libs optional
libgit2-glib_0.26.4-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEENuxaZEik9e95vv6Y4FrhR4+BTE8FAltCDNMACgkQ4FrhR4+B
TE8YTw/+JucMxERsdeuwZnD2zI8hpx35LfhpjHUcNt7vZPLNcgsAhrF82FqYwBd4
TCvv5a8I9QWfmqfGY/Pa+83KLsT3NL8XqCqyt/HGIJBJrTrg4lzcJ1gxwAyTIGj9
Te+nslq0Im+K7S5FaeG6lQHL746vULvB4ou29+DWHKT0pLnDgNF47RCPeUheEP+D
pQ7qa2nHVpw8/R64mT5Z/bUqfMFP9Tn7o1ekRGNCZg5yZ5/rK+MOoERcC+n40/LY
8zWekwHK/b6TY3FH5lHdVLBR0rIR674nfw0EECjJdsjg0l+n33Vl/K8MyK1oyWGw
IXbyS+6fY5bNR1O8/F2O7zpJ6ettGo3HBckEdMfd3hr5pJuGci3jOVSS/A2OUCQg
gTMn3lLylCMiSZ+9sX99Sa36EndMUES9oQnKCFzB17z83p29fUIMYBu0rCkMBDkz
Z352u6Axu6DYlHD41qrcr8nNEBX4H3rl+/QABDNXdwFTmdp5D0f2pi9WYVpjN0Z9
0q/YCNsV8x8rBB9GQx0Wm7o5Ue3mUvADAi93O44cU2i4To3frtvemhytmgpnqTis
VzykET1IAgcIVFtFXYeIp1piw+a+gEqiDsAU4d/hrRdeCn3meQcgk6YEmnUJjVjz
+PnbyhkgI/QRRMNyxkj4cKo/eA7jmNJgMHaAX1shN7ynL7+6PmQ=
=dLyQ
-----END PGP SIGNATURE-----
--- End Message ---
