Your message dated Sat, 26 May 2018 15:04:35 +0000
with message-id <e1fmakf-000css...@fasolo.debian.org>
and subject line Bug#900126: fixed in libgit2 0.27.0+dfsg.1-0.4
has caused the Debian Bug report #900126,
regarding libgit2: Testsuite failures on 32-bit targets with 64-bit file offsets
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
900126: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=900126
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: libgit2
Version: 0.23.1-1
Severity: serious
Tags: patch upstream
Justification: fails to build from source
User: debian-m...@lists.debian.org
Usertags: mips
Hi!
Thanks for merging my patch to fix the alignment issue reported
in #900059. There is, however, an additional problem with libgit2
which causes the testsuite to fail on 32-bit systems [1]:
core::buffer..........................*** stack smashing detected ***:
<unknown> terminated
3/3 Test #3: libgit2_clar-ssh .................***Exception: Child aborted
3.47 sec
Loaded 343 suites:
Started (test status codes: OK='.' FAILURE='F' SKIPPED='S')
Since this issue is not visible in the git master branch of libgit2,
I assumed that this must have been fixed in the meantime. And, in
fact there is pull request which addresses this problem [2].
The fix is trivial and I can confirm it fixes the testsuite for me
on mipsel.
Please include the attached patch in the next upload.
Adrian
> [1]
> https://buildd.debian.org/status/fetch.php?pkg=libgit2&arch=i386&ver=0.27.0%2Bdfsg.1-0.3&stamp=1527339147&raw=0
> [2] https://github.com/libgit2/libgit2/pull/4631
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaub...@debian.org
`. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
>From fac7eac451f99f722b54e7cd8761926837dd0fa5 Mon Sep 17 00:00:00 2001
From: Andreas Baumann <m...@andreasbaumann.cc>
Date: Thu, 19 Apr 2018 15:21:52 +0200
Subject: [PATCH] fixed stack smashing due to wrong size of struct stat on the
stack on 32-bit systems with 64-bit file descriptor offsets enabled (added
-D_FILE_OFFSET_BITS=64 when compiling the test suite)
---
tests/CMakeLists.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
index 775f33f2d..e73e7237c 100644
--- a/tests/CMakeLists.txt
+++ b/tests/CMakeLists.txt
@@ -9,6 +9,7 @@ SET(CLAR_FIXTURES "${CMAKE_CURRENT_SOURCE_DIR}/resources/")
SET(CLAR_PATH "${CMAKE_CURRENT_SOURCE_DIR}")
ADD_DEFINITIONS(-DCLAR_FIXTURE_PATH=\"${CLAR_FIXTURES}\")
ADD_DEFINITIONS(-DCLAR_TMPDIR=\"libgit2_tests\")
+ADD_DEFINITIONS(-D_FILE_OFFSET_BITS=64)
INCLUDE_DIRECTORIES(${CLAR_PATH} ${libgit2_BINARY_DIR}/src)
FILE(GLOB_RECURSE SRC_TEST ${CLAR_PATH}/*/*.c ${CLAR_PATH}/*/*.h)
--
2.17.0
--- End Message ---
--- Begin Message ---
Source: libgit2
Source-Version: 0.27.0+dfsg.1-0.4
We believe that the bug you reported is fixed in the latest version of
libgit2, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 900...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
John Paul Adrian Glaubitz <glaub...@physik.fu-berlin.de> (supplier of updated
libgit2 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 26 May 2018 16:27:33 +0200
Source: libgit2
Binary: libgit2-dev libgit2-27
Architecture: source
Version: 0.27.0+dfsg.1-0.4
Distribution: experimental
Urgency: medium
Maintainer: John Paul Adrian Glaubitz <glaub...@physik.fu-berlin.de>
Changed-By: John Paul Adrian Glaubitz <glaub...@physik.fu-berlin.de>
Description:
libgit2-27 - low-level Git library
libgit2-dev - low-level Git library (development files)
Closes: 900126
Changes:
libgit2 (0.27.0+dfsg.1-0.4) experimental; urgency=medium
.
* Non-maintainer upload.
* Fix stack smashing error on 32-bit targets (Closes: #900126)
Checksums-Sha1:
44163e457eed84be67d54d57a73caebcd8fef09e 2082 libgit2_0.27.0+dfsg.1-0.4.dsc
88a20e4ac829f8669a074e87469d52252371c888 21556
libgit2_0.27.0+dfsg.1-0.4.debian.tar.xz
d7ff856dc9ff90f60253be260f22ff295926333f 7407
libgit2_0.27.0+dfsg.1-0.4_i386.buildinfo
Checksums-Sha256:
766f52ca8b91416ce70717c8bb8327ae9ecb4d362b794a537a58e409885403c5 2082
libgit2_0.27.0+dfsg.1-0.4.dsc
d7870b6d6657b66bb0b508ed30444a118aeade61e0c45a4c7fb9f4eebe00596d 21556
libgit2_0.27.0+dfsg.1-0.4.debian.tar.xz
4d3460da3550ebf2fa1e52cef785ee19c70979a7b7441127e8a11e0ec80d3ba2 7407
libgit2_0.27.0+dfsg.1-0.4_i386.buildinfo
Files:
5c03ff235b2627691e4e48e864c96b1d 2082 libs optional
libgit2_0.27.0+dfsg.1-0.4.dsc
b1b6d4e1d9b3be2e4ff06b3b7490d9d7 21556 libs optional
libgit2_0.27.0+dfsg.1-0.4.debian.tar.xz
e3d2d6b9fe80a1492247df5b62dd9c52 7407 libs optional
libgit2_0.27.0+dfsg.1-0.4_i386.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEYv+KdYTgKVaVRgAGdCY7N/W1+RMFAlsJc0YACgkQdCY7N/W1
+ROOfBAAwZa2ZW/UD1jUJC8sPqlZdRlQsVTMeP1uCfP5yeiqO811R5qVPlmnDPeq
bajZcA2NZsY+G9Gf72VAQODJAeugsqzllbBp8aZ52Y/BR/MaBQemSAKPUHmuBdbO
+uE5orEObr85Y6mMimNBnsKCPwI9wuUdD0Jj3nyudUs0v+z7fwfEBMrAyivGEhgV
8LMZ7pGIUFo4TgoAUYsmud7AZgVOpGr46tWNcQKC27kxMm71KtLAp/mnK91UsUM9
goyZVwGS8Bx8rL5tZut/w3D9BHkPVrglqDJ5l74ZOmQ7jEKEqY1gb+rzfJ967TxM
msBSwYztkVboYW6mNymUESx1U+KhRuYQ8wphD6Fn2PsJba3erJCdGxpER3lbigXh
zSCtYHl0zyHOhkbb7VoFRjHkcqlpIcLSIa+2ZJIs9qdQhHTSi+QCqaeelf/52IX6
UMLTEhCvKiNAw1GwLHjlU2W1uSWeZhfg5jPb/zoePYbx4oxOlkpW7dBPjFwX27Ej
/BmFdPok4uze0sU/VwYpsZ2Tfcpdd+j6bEbFaEo2eF5fKR2St8nuKrQYPIU1a/8s
+yAYmDnkkA+/hXYHrWB7fB5143+tDtFIIsR3mBWKCTNq7EdIKs0CjydJcw3pYbUK
aNY3GVrAfh6XKoeQErH3YKvELtgYirP0EblmXyjxOVibgvrGaJ4=
=Alwk
-----END PGP SIGNATURE-----
--- End Message ---
