This looks like a bug to me. As Juhani mentioned to avoid the name space 
collisions openipmi introduced the following line selector.h

#ifdef OPENIPMI_DEFINE_SELECTOR_T

which is not defined earlier and it is not defined in openhpi.
Instead of #ifdef they need to use #ifndef so that older code will work and the 
newer code could define the variable.
If openhpi replaces "selector_t" with "struct selector_s" then the compile 
works fine. How do we go about this?


________________________________
From: Devarajulu, Mohanasundaram <mohanasundaram.devaraj...@hpe.com>
Sent: Thursday, May 24, 2018 8:41:40 AM
To: 899...@bugs.debian.org; Juhani Numminen
Cc: Helmut Grohne
Subject: Bug#899152: FTBFS: ipmi.h:85:2: error: unknown type name 'selector_t'


Adam / Juhani,


Thank you for sending this email. Looks like something changed in the compiler 
or the switches in the past one year. We have not touched the ipmi code in 
ages. Going to work on this today.


Regards

Mohan


________________________________
From: Juhani Numminen <juhaninummin...@gmail.com>
Sent: Wednesday, May 23, 2018 11:06:26 PM
To: 899...@bugs.debian.org
Cc: Helmut Grohne
Subject: Bug#899152: FTBFS: ipmi.h:85:2: error: unknown type name 'selector_t'

On Sun, 20 May 2018 00:02:58 +0200 Adam Borowski <kilob...@angband.pl> wrote:
> Source: openhpi
> Version: 3.6.1-3.1
> Severity: serious
> Justification: fails to build from source (but built successfully in the past)
>
> Hi!
> I'm afraid that during a rolling archive rebuild, your package failed.
> Tried on armhf amd64; the error was:
>
> In file included from ipmi.c:21:0:
> ipmi.h:85:2: error: unknown type name 'selector_t'

This seemed weird, because ipmi.h has #include <OpinIPMI/selector.h> which
surely defines selector_t – except there's a new #ifdef in selector.h[2].
See upstream announcement[1].

Helmut, perhaps you can make the whole (cross-)build succeed with the flag
-DOPENIPMI_DEFINE_SELECTOR_T?


Cheers,
Juhani

[1] https://sourceforge.net/p/openipmi/mailman/message/35980029/
[2] 
https://sources.debian.org/src/openipmi/2.0.25-2/include/OpenIPMI/selector.h/#L44

Reply via email to