control: reassign -1 src:acpica-unix
control: found -1 20180508-1
control: affects -1 virtualbox

On Tue, 22 May 2018 19:12:32 +0200 Emilio Pozuelo Monfort <po...@debian.org> 
wrote:
> Package: virtualbox
> Version: 5.2.12-dfsg-1
> Severity: serious
> 
> virtualbox fails to build on a clean sid chroot here:
> 
> In file included from 
> /build/virtualbox-5.2.12-dfsg/src/VBox/Devices/PC/ACPI/VBoxAcpi.cpp:45:0:
> /build/virtualbox-5.2.12-dfsg/out/obj/VBoxDD/vboxssdt-standard.hex:16:23: 
> error: expected initializer before '-' token
>  unsigned char vboxssdt-standard_aml_code[] =
>                        ^
> /build/virtualbox-5.2.12-dfsg/src/VBox/Devices/PC/ACPI/VBoxAcpi.cpp: In 
> function 'int acpiPrepareDsdt(PPDMDEVINS, void**, size_t*)':
> /build/virtualbox-5.2.12-dfsg/src/VBox/Devices/PC/ACPI/VBoxAcpi.cpp:371:32: 
> error: 'AmlCode' was not declared in this scope
>          cbAmlCodeDsdt = sizeof(AmlCode);
>                                 ^~~~~~~
> /build/virtualbox-5.2.12-dfsg/src/VBox/Devices/PC/ACPI/VBoxAcpi.cpp: In 
> function 'int acpiPrepareSsdt(PPDMDEVINS, void**, size_t*)':
> /build/virtualbox-5.2.12-dfsg/src/VBox/Devices/PC/ACPI/VBoxAcpi.cpp:423:30: 
> error: 'AmlCodeSsdtCpuHotPlug' was not declared in this scope
>              pabAmlCode     = AmlCodeSsdtCpuHotPlug;
>                               ^~~~~~~~~~~~~~~~~~~~~
> /build/virtualbox-5.2.12-dfsg/src/VBox/Devices/PC/ACPI/VBoxAcpi.cpp:428:30: 
> error: 'AmlCodeSsdtStandard' was not declared in this scope
>              pabAmlCode     = AmlCodeSsdtStandard;
>                               ^~~~~~~~~~~~~~~~~~~
> kmk: *** [/usr/share/kBuild/footer-pass2-compiling-targets.kmk:226: 
> /build/virtualbox-5.2.12-dfsg/out/obj/VBoxDD/PC/ACPI/VBoxAcpi.o] Error 1
> 
> Full log attached.
> 
> Emilio

This seems a regression in acpica-unix, I'm attaching the logs of the generated 
hex files before and after. The array is called in a different way, I'm not 
sure if this is a regression or a feature and we have to change vbox code.

before:
unsigned char AmlCode[] =
{
    0x44,0x53,0x44,0x54,0xFF,0x21,0x00,0x00,  /* 00000000    "DSDT.!.." */

after:
unsigned char vboxaml_aml_code[] =
{
    0x44,0x53,0x44,0x54,0xFF,0x21,0x00,0x00,  /* 00000000    "DSDT.!.." */


also, it seems that this new version generates non standard code

/VirtualBox-5.2.12/out/obj/VBoxDD/vboxssdt-standard.hex:16:23: error: expected 
initializer before '-' token
 unsigned char vboxssdt-standard_aml_code[] =
                       ^


can you please have a look?

thanks

Gianfranco

Attachment: acpica-tools-vbox-logs.tar.xz
Description: application/xz

Reply via email to