Your message dated Thu, 08 Mar 2018 13:36:21 +0000
with message-id <e1etvix-000gr4...@fasolo.debian.org>
and subject line Bug#891292: fixed in sisl 4.6.0-2
has caused the Debian Bug report #891292,
regarding sisl: FTBFS with glibc 2.27: error: 'MAXDOUBLE' undeclared (first use
in this function); did you mean 'DOUBLE'?
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
891292: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=891292
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: sisl
Version: 4.6.0-1
Severity: important
Tags: patch
User: debian-gl...@lists.debian.org
Usertags: 2.27
sisl 4.6.0-1 fails to build with glibc 2.27 (2.27-0experimental0 from
experimental):
| [ 3%] Building C object CMakeFiles/sisl.dir/src/mk_cv_cycl.c.o
| /usr/bin/cc -I/<<PKGBUILDDIR>>/include -g -O2
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -o
CMakeFiles/sisl.dir/src/mk_cv_cycl.c.o -c /<<PKGBUILDDIR>>/src/mk_cv_cycl.c
| In file included from /<<PKGBUILDDIR>>/src/crvcrvtang.c:49:0:
| /<<PKGBUILDDIR>>/src/crvcrvtang.c: In function 'crv_crv_tang':
| /<<PKGBUILDDIR>>/include/sislP.h:365:23: error: 'MAXDOUBLE' undeclared (first
use in this function); did you mean 'DOUBLE'?
| #define HUGE MAXDOUBLE
| ^
| /<<PKGBUILDDIR>>/src/crvcrvtang.c:171:19: note: in expansion of macro 'HUGE'
| tprev = (double)HUGE;
| ^~~~
| /<<PKGBUILDDIR>>/include/sislP.h:365:23: note: each undeclared identifier is
reported only once for each function it appears in
| #define HUGE MAXDOUBLE
| ^
| /<<PKGBUILDDIR>>/src/crvcrvtang.c:171:19: note: in expansion of macro 'HUGE'
| tprev = (double)HUGE;
| ^~~~
| CMakeFiles/sisl.dir/build.make:113: recipe for target
'CMakeFiles/sisl.dir/src/crvcrvtang.c.o' failed
| make[3]: *** [CMakeFiles/sisl.dir/src/crvcrvtang.c.o] Error 1
| make[3]: *** Waiting for unfinished jobs....
| In file included from /<<PKGBUILDDIR>>/src/crvarctang.c:49:0:
| /<<PKGBUILDDIR>>/src/crvarctang.c: In function 'crv_arc_tang':
| /<<PKGBUILDDIR>>/include/sislP.h:365:23: error: 'MAXDOUBLE' undeclared (first
use in this function); did you mean 'DOUBLE'?
| #define HUGE MAXDOUBLE
| ^
| /<<PKGBUILDDIR>>/src/crvarctang.c:174:19: note: in expansion of macro 'HUGE'
| tprev = (double)HUGE;
| ^~~~
| /<<PKGBUILDDIR>>/include/sislP.h:365:23: note: each undeclared identifier is
reported only once for each function it appears in
| #define HUGE MAXDOUBLE
| ^
| /<<PKGBUILDDIR>>/src/crvarctang.c:174:19: note: in expansion of macro 'HUGE'
| tprev = (double)HUGE;
| ^~~~
| CMakeFiles/sisl.dir/build.make:89: recipe for target
'CMakeFiles/sisl.dir/src/crvarctang.c.o' failed
| make[3]: *** [CMakeFiles/sisl.dir/src/crvarctang.c.o] Error 1
| In file included from /<<PKGBUILDDIR>>/src/intjoinper.c:51:0:
| /<<PKGBUILDDIR>>/src/intjoinper.c: In function 'int_join_per':
| /<<PKGBUILDDIR>>/include/sislP.h:365:23: error: 'MAXDOUBLE' undeclared (first
use in this function); did you mean 'DOUBLE'?
| #define HUGE MAXDOUBLE
| ^
| /<<PKGBUILDDIR>>/src/intjoinper.c:183:23: note: in expansion of macro 'HUGE'
| legal_min[kp] = -HUGE;
| ^~~~
| /<<PKGBUILDDIR>>/include/sislP.h:365:23: note: each undeclared identifier is
reported only once for each function it appears in
| #define HUGE MAXDOUBLE
| ^
| /<<PKGBUILDDIR>>/src/intjoinper.c:183:23: note: in expansion of macro 'HUGE'
| legal_min[kp] = -HUGE;
| ^~~~
| CMakeFiles/sisl.dir/build.make:281: recipe for target
'CMakeFiles/sisl.dir/src/intjoinper.c.o' failed
| make[3]: *** [CMakeFiles/sisl.dir/src/intjoinper.c.o] Error 1
| make[3]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
| CMakeFiles/Makefile2:70: recipe for target 'CMakeFiles/sisl.dir/all' failed
| make[2]: *** [CMakeFiles/sisl.dir/all] Error 2
| make[2]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
| Makefile:154: recipe for target 'all' failed
| make[1]: *** [all] Error 2
| make[1]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
| dh_auto_build: cd obj-x86_64-linux-gnu && make -j16 returned exit code 2
| debian/rules:16: recipe for target 'build-arch' failed
| make: *** [build-arch] Error 2
| dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit
status 2
A full build log is available there:
http://aws-logs.debian.net/2018/02/07/glibc-exp/sisl_4.6.0-1_unstable_glibc-exp.log
Starting with glibc 2.27, support for SVID error handling has been
removed, including the corresponding constants. This causes this package
to FTBFS. The attached patch fixes that by defining the constants if
they are not defined instead of on a fixed list of systems.
diff -Nru sisl-4.6.0/debian/patches/no-svid.patch
sisl-4.6.0/debian/patches/no-svid.patch
--- sisl-4.6.0/debian/patches/no-svid.patch 1970-01-01 01:00:00.000000000
+0100
+++ sisl-4.6.0/debian/patches/no-svid.patch 2018-02-24 02:05:09.000000000
+0100
@@ -0,0 +1,35 @@
+SVID error handling has been removed from glibc 2.27 onwards. Check for
+corresponding defines instead of hardcoding a list of systems.
+
+--- sisl-4.6.0.orig/include/sislP.h
++++ sisl-4.6.0/include/sislP.h
+@@ -81,14 +81,28 @@
+ #include <limits.h>
+
+ /* Get system spesific values */
+-#if defined(_MSC_VER) || defined(__BORLANDC__) || defined(__MINGW32__) ||
defined(__APPLE__)
++#if !defined(MAXDOUBLE)
+ # define MAXDOUBLE 1.79769313486231570e+308
++#endif
++#if !defined(MAXFLOAT)
+ # define MAXFLOAT ((float)3.40282346638528860e+38)
++#endif
++#if !defined(MINDOUBLE)
+ # define MINDOUBLE 2.22507385850720140e-308
++#endif
++#if !defined(MINFLOAT)
+ # define MINFLOAT ((float)1.17549435082228750e-38)
++#endif
++#if !defined(M_PI)
+ # define M_PI 3.14159265358979323846
++#endif
++#if !defined(M_PI_2)
+ # define M_PI_2 1.57079632679489661923
++#endif
++#if !defined(M_SQRT2)
+ # define M_SQRT2 1.41421356237309504880
++#endif
++#if !defined(M_SQRT1_2)
+ # define M_SQRT1_2 0.70710678118654752440
+ #endif
+
diff -Nru sisl-4.6.0/debian/patches/series sisl-4.6.0/debian/patches/series
--- sisl-4.6.0/debian/patches/series 1970-01-01 01:00:00.000000000 +0100
+++ sisl-4.6.0/debian/patches/series 2018-02-24 02:05:09.000000000 +0100
@@ -0,0 +1 @@
+no-svid.patch
--- End Message ---
--- Begin Message ---
Source: sisl
Source-Version: 4.6.0-2
We believe that the bug you reported is fixed in the latest version of
sisl, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 891...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Simon Richter <s...@debian.org> (supplier of updated sisl package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Tue, 06 Mar 2018 12:10:25 +0100
Source: sisl
Binary: libsisl-dev
Architecture: source amd64
Version: 4.6.0-2
Distribution: unstable
Urgency: medium
Maintainer: Simon Richter <s...@debian.org>
Changed-By: Simon Richter <s...@debian.org>
Description:
libsisl-dev - SINTEF Spline Library
Closes: 891292
Changes:
sisl (4.6.0-2) unstable; urgency=medium
.
* Use DBL_MAX instead of MAXDOUBLE (Closes: #891292)
Checksums-Sha1:
c6c43bf9db9477098d744d8a19be24521fb27373 1371 sisl_4.6.0-2.dsc
e68138711e8c05223edd01a75c783366ca01f4ba 2048 sisl_4.6.0-2.debian.tar.xz
f0dbd947a9bcd791df6d66bdb2b33f0348c47abd 504342 libsisl-dev_4.6.0-2_amd64.deb
b639ad5e102fed42f840d3cbc7d04a278e806f40 6272 sisl_4.6.0-2_amd64.buildinfo
Checksums-Sha256:
2f0b901cb017bdbb54001c6c3f573b6f16a83d12ef275581124064ddb12df1c2 1371
sisl_4.6.0-2.dsc
f140fb2888f4eca802835ef032a06923afd212a6237f6b50f3c92240882b9a81 2048
sisl_4.6.0-2.debian.tar.xz
703fa718aff774aecf901c89bd4519b824aafb07224aa266d47b57f9718b8836 504342
libsisl-dev_4.6.0-2_amd64.deb
d684157ca7601cdd49c81857c45bc3b385c34bf43f86ff30d9a5c20ff0988946 6272
sisl_4.6.0-2_amd64.buildinfo
Files:
a6aba7e2c31342df76c0a083156f9e78 1371 libs optional sisl_4.6.0-2.dsc
fc97fae09d69079a2160934749875206 2048 libs optional sisl_4.6.0-2.debian.tar.xz
e77d35f0f9e4d72bfafff5c41f0f2766 504342 libdevel optional
libsisl-dev_4.6.0-2_amd64.deb
0bb1c9c2539c32a78275d72965ecce84 6272 libs optional
sisl_4.6.0-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEEtjuqOJSXmNjSiX3Tfr04e7CZCBEFAlqhOAwACgkQfr04e7CZ
CBFiowgAj7OmsZzUpZ9lO3oNlNyztb4Oa7Yb5MriCtZBnDgEMNuZl41FtgtecZrU
G6o7vVC3d4ZCS29nYR2z+wMLmpqvFFEBYOs3rJGp6Eh8Xms5eGYyEEU7MO6rprlt
HdhTUJgi5YdtUGIvMjAF9+ZYitnMC0zq1ZZs/EWfKRVya6ABG1qADv1vflC5hyCI
X7ljjLkf7erAxTp9GEOLKTlaJsTSybeD3ZNV1Z60YUU9GmW7RnS9lrQ0KCC1nYTk
EDubvpK7PXRTgNaAcCyYe3u9p2h9C/duqRIyUYrJ0gRVM8VBTbl/phdHd0kulDbC
1Zry/DCN0c7+IqI6D/E2ZBKiFgm30Q==
=JiW2
-----END PGP SIGNATURE-----
--- End Message ---
