Control: retitle -1 ikiwiki: FTBFS with new ImageMagick Control: forwarded -1 https://ikiwiki.info/bugs/imagemagick_6.9.8_test_suite_failure/
On Tue, 27 Feb 2018 at 18:44:01 +0200, Adrian Bunk wrote: > t/img.t (Wstat: 2304 Tests: 70 Failed: 9) > Failed tests: 21, 27-28, 30-35 A more useful part of the log: # Failed test at t/img.t line 119. # got: 'no image: Exception 435: unable to open image `:t/tmp/out/imgconversions/10x-redsquare.png': No such file or directory @ error/blob.c/OpenBlob/2735' # expected: '10x10' # Failed test at t/img.t line 129. # got: 'no image: Exception 435: unable to open image `:t/tmp/out/imgconversions/12x-twopages.png': No such file or directory @ error/blob.c/OpenBlob/2735' # expected: '12x12' (etc.) The syntax we used to force ImageMagick to treat filenames as literal (and not interpret a "foo:" prefix as an instruction to use the foo decoder) is no longer supported since commit https://github.com/ImageMagick/ImageMagick/commit/4bc9b6b which unhelpfully has an empty commit message. The unit test needs to use 'png:foo.png' instead of ':foo.png'. It can't leave the decoder unspecified because some of the filenames contain colons, because they are part of a test to make sure that we handle filenames containing colons correctly. The img.module itself always uses the decoder prefix, except that if the extension is not one of the ones we recognise (which is not allowed by default because it's a security risk, but can be re-enabled) then we can't do that because we don't know which coder ImageMagick would have chosen. I'm not currently sure how to ask ImageMagick which coder it would use without being susceptible to the same bizarre behaviour that we previously disabled with the ':' prefix. tl;dr any meta-syntax that doesn't have an obvious escaping mechanism is a design flaw, but unfortunately ImageMagick has that design flaw :-( smcv
