Control: severity -1 normal

Resetting severity to normal, since we don't ship with updates enabled
at all by default.

On Tue, Jan 30, 2018 at 09:07:26AM -0700, Will Aoki wrote:
> forwarded 888837 https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7540
> thanks
> 
> We hit this bug this morning with an sa-update. I'd hazard a guess that
> it's the faulty ruleset described in upstream bug #7540 (fixed less than
> two hours ago) and will clear up soon, when upstream publishes new
> rules.

Yeah, it's been fixed upstream according to that bug report.

This does hilight a need to be a little more thorough in our cleanup of
failed updates, though. If, as Niccolo found, the system reboots or
spamd is otherwise restarted before the fix is pulled down, it won't
properly start. If you're using spamassassin directly, rather than
spamd+spamc, then it simply won't work until the upstream fix is
downloaded.

We currently detect the case where the update results in an invalid
ruleset, and in that case we skip the spamd reload. The theory is that
we'll naturally pick up the fix when it's published via the update
channel. However, that's not far enough. We need to actually roll back
to a valid ruleset. Or better yet, we need to stage the ruleset and
validate it before we ever expose it to the runtime environment.

noah

Attachment: signature.asc
Description: PGP signature

Reply via email to