Source: gnome-shell-extension-disconnect-wifi
Version: 3.22.14-1
Severity: serious
Tags: patch
User: pkg-utopia-maintain...@lists.alioth.debian.org
Usertags: libnm

Hi,

the libnm-glib/libnm-util libraries have been deprecated upstream in
favour of libnm (along with their corresponding gir bindings)

Your package uses the old Gir bindings:

disconnect-w...@kgshank.net/extension.js:const NetworkManager = 
imports.gi.NetworkManager;
disconnect-w...@kgshank.net/extension.js:const NMClient = imports.gi.NMClient;
disconnect-w...@kgshank.net/extension.js:       if (device.get_device_type() != 
NetworkManager.DeviceType.WIFI) {
disconnect-w...@kgshank.net/extension.js:       if (device.get_device_type() != 
NetworkManager.DeviceType.WIFI) {
disconnect-w...@kgshank.net/extension.js:                       = newstate > 
NetworkManager.DeviceState.DISCONNECTED;
disconnect-w...@kgshank.net/extension.js:                    = (newstate == 
NetworkManager.DeviceState.DISCONNECTED)
disconnect-w...@kgshank.net/extension.js:       if (device.get_device_type() != 
NetworkManager.DeviceType.WIFI) {

Fortunately, this has already been fixed upstream at
https://github.com/kgshank/gse-disconnect-wifi/commit/5584d98989d25a9c37810896f5e113b4c13b2bdc
https://github.com/kgshank/gse-disconnect-wifi/commit/1e15074bafdee7a20db57b78143d50d1793946f1
https://github.com/kgshank/gse-disconnect-wifi/commit/2f7fcf6a3846fc90eb1d0597415a090d3c3af1ae


Please cherry-pick those patches to make your extension compatible with
newer versions of gnome-shell.
In version 3.26.2-4, I switched gnome-shell over to libnm, which means
your extension is currently non-functional anymore in sid/buster (thus the RC
severity).

Regards,
Michael


-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.14.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8), 
LANGUAGE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Reply via email to