Your message dated Sun, 07 Jan 2018 19:19:50 +0000
with message-id <e1eygu2-0009sw...@fasolo.debian.org>
and subject line Bug#885929: fixed in git-buildpackage 0.9.6
has caused the Debian Bug report #885929,
regarding git-buildpackage: gbp pq import fails on non UTF-8 chars in patch
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
885929: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=885929
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: git-buildpackage
Version: 0.9.5
Severity: normal

Dear Maintainer,

thanks for maintaining gbp, I really enjoy it.  Now that you have
extended DEP3 support, I just gave the patch queue another try, but
fear that I found a bug in it:

I tried to import the patches of privoxy 3.0.26-4 into the patch
queue.  This fails with the following error:

$ gbp pq import
gbp:info: Trying to apply patches at 'c17f8e71000624bdcd2758a8fbe0b764b3b1c405'
Traceback (most recent call last):
  File "/usr/bin/gbp", line 149, in <module>
    sys.exit(supercommand())
  File "/usr/bin/gbp", line 145, in supercommand
    return module.main(args)
  File "/usr/lib/python3/dist-packages/gbp/scripts/pq.py", line 488, in main
    import_pq(repo, current, options)
  File "/usr/lib/python3/dist-packages/gbp/scripts/pq.py", line 374, in 
import_pq
    options.upstream_tag)
  File "/usr/lib/python3/dist-packages/gbp/scripts/pq.py", line 335, in 
import_quilt_patches
    apply_and_commit_patch(repo, patch, maintainer, patch.topic, name)
  File "/usr/lib/python3/dist-packages/gbp/scripts/common/pq.py", line 311, in 
apply_and_commit_patch
    author = {'name': patch.author,
  File "/usr/lib/python3/dist-packages/gbp/patch_series.py", line 156, in author
    return self._get_info_field('author')
  File "/usr/lib/python3/dist-packages/gbp/patch_series.py", line 303, in 
_get_info_field
    self._read_info()
  File "/usr/lib/python3/dist-packages/gbp/patch_series.py", line 173, in 
_read_info
    self._check_dep3()
  File "/usr/lib/python3/dist-packages/gbp/patch_series.py", line 240, in 
_check_dep3
    for line in file:
  File "/usr/lib/python3.5/codecs.py", line 321, in decode
    (result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe1 in position 228: 
invalid continuation byte

As far as I can see, this fails in 33_manpage_hyphen.patch (see
https://sources.debian.org/src/privoxy/3.0.26-4/debian/patches/33_manpage_hyphen.patch/
), since the body of this patch contains ISO-8859-1 chars.

Here the python UTF-8 parser fails.  I'm not sure, whether the body
part of the patch (in contrast to the DEP3 header) should be expected
to be UTF-8, since this is part of the upstream package which may use
other charsets, so it should be considered binary, shouldn't it?

-- System Information:
Debian Release: 9.3
  APT prefers stable
  APT policy: (500, 'stable'), (50, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.utf-8, LC_CTYPE=de_DE.utf-8 (charmap=UTF-8), 
LANGUAGE=de_DE:de:en_GB:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages git-buildpackage depends on:
ii  devscripts             2.17.6+deb9u1
ii  git                    1:2.11.0-3+deb9u2
ii  man-db                 2.7.6.1-2
ii  python3                3.5.3-1
ii  python3-dateutil       2.5.3-2
ii  python3-pkg-resources  33.1.1-1

Versions of packages git-buildpackage recommends:
ii  cowbuilder        0.85
ii  pbuilder          0.228.7
ii  pristine-tar      1.38
ii  python3-requests  2.12.4-1
ii  sbuild            0.73.0-4

Versions of packages git-buildpackage suggests:
ii  python3-notify2  0.3-3
ii  sudo             1.8.19p1-2.1
ii  unzip            6.0-21

-- no debconf information

Greetings

        Roland

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message ---
Source: git-buildpackage
Source-Version: 0.9.6

We believe that the bug you reported is fixed in the latest version of
git-buildpackage, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 885...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Guido Günther <a...@sigxcpu.org> (supplier of updated git-buildpackage package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 06 Jan 2018 20:43:18 +0100
Source: git-buildpackage
Binary: git-buildpackage git-buildpackage-rpm
Architecture: source
Version: 0.9.6
Distribution: unstable
Urgency: medium
Maintainer: Guido Günther <a...@sigxcpu.org>
Changed-By: Guido Günther <a...@sigxcpu.org>
Description:
 git-buildpackage - Suite to help with Debian packages in Git repositories
 git-buildpackage-rpm - Suite to help with RPM packages in Git repositories
Closes: 885929
Changes:
 git-buildpackage (0.9.6) unstable; urgency=medium
 .
   * [89495f7] patch_series: Properly chain up to parent class.
     Insted of duplicating the logic use the parent classes _read_info.
   * [28838b9] patch_series: don't read dep3 info multiple times
   * [7b0660a] patch_series: Remove duplicate functions.
     No need to repeat them in Dep3Patch since the parent class Patch already
     has them.
   * [0730a57] patch_series: Don't fail on decoding errors when looking for
     DEP3 headers
     (Closes: #885929)
   * [6979250] export-orig: fix --upstream-branch argument name in manpage
Checksums-Sha1:
 aeeab39b6ca548851dd280a930fa331d8da97b6b 2273 git-buildpackage_0.9.6.dsc
 b0b231401ec94dccb912d0200abfcff08d685242 2349456 git-buildpackage_0.9.6.tar.xz
 8ab265ea77aa5c3174188f936a70bc60ee93bf9d 11588 
git-buildpackage_0.9.6_amd64.buildinfo
Checksums-Sha256:
 11e93a02b807c442793a62c212360fd7b0b3b6ba6603dc8c5c4a07f3d9f2535f 2273 
git-buildpackage_0.9.6.dsc
 d7cd8c05640c9cc3d7d91df80c083c07897de6ff0560d43fcc74ac5b3529b23c 2349456 
git-buildpackage_0.9.6.tar.xz
 232fa13bde3e29a8972d37c7e0545ea2e363089149db6abcf178b2b7be0b35de 11588 
git-buildpackage_0.9.6_amd64.buildinfo
Files:
 2be32fc66ee934a13ada8ff3f9c5b9b9 2273 vcs optional git-buildpackage_0.9.6.dsc
 c16a208e3cc4965afd61f36cccab5cc2 2349456 vcs optional 
git-buildpackage_0.9.6.tar.xz
 f223c6d7cf3c64d637c0cb2fe9540b7c 11588 vcs optional 
git-buildpackage_0.9.6_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEvHzQcjh1660F3xzZB7i3sOqYEgsFAlpSbsAACgkQB7i3sOqY
EguCyA//QGSx1Sg1lAU1Fh5SAiGn9kBl3v0roq/7iiX8qcEZNrIQDl9E+pYFTqq4
jnHZ8zULA3mosN3D2RIJydd+SChZ56aB+GU+UGa9NBMcQc8gxtkxR3oi0ALaGlfB
Q1KQE9ZszIcsefoQXGZF6EoIwFhzFegEJNZV1hyO98u0K8JiTKaBuSEsG8Rmfv2o
ZNS529ash8hiKWUCvWRxMF7tthXfLx2oeuukCbYnbw77xnrqaD5HgSGMvpxT6Urv
0eoQxrHgk88j43MTmY6zcpHFF51xBWZHeNbOUXxbv0Imm0Tb53eOAj+i2hABxBD5
vLFqI3dZavxQaUlezq49TngMumZVeQBUoSd6jlkvuhR8tBurcNJM6zRmBaCCvM1f
OEc5VKiGMHlxNYNeFca8ngQFA2aI/AdI3IaLmcjJYfbfXreU+rH2KtCl14z+Oz6p
QCT9mJN5CyEcGEfPovm4POwtzn9NtGCK63lA/nc0Ujptd4XWimH+p/CGAvKc/Uty
8PMR2pt/vH4PG07quq9Tnnw4SjdDmBkwVN62PAwISq5G97nMrvMcSQAICJkaQHFe
MKW2MkxBjmhqTz8gR5gwbqDk2L5S3sA4uBr6ywcnwftRxHv5z3CYvWRW9rI2toXZ
EyuQdbFypbGiXH8oVcYxrZkv5Z2YK4v07Rpi+2zVC4IBw8wHWJE=
=9vww
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to