Control: tags -1 + patch
On Tue, 31 Jan 2017 09:31:56 +0000 Matthias Klose <d...@debian.org> wrote:> The
full build log can be found at:
> http://people.debian.org/~doko/logs/gcc7-20170126/gtkmathview_0.8.0-14_unstable_gcc7.log
>...
I got a different error:
gtkmathview_common.cc: In function 'gint
gtk_math_view_button_release_event(GtkWidget*, GdkEventButton*)':
gtkmathview_common.cc:912:50: error: call of overloaded 'abs(guint32)' is
ambiguous
abs(math_view->button_press_time - event->time) <= CLICK_TIME_RANGE)
...
/usr/include/stdlib.h:751:12: note: candidate: int abs(int)
extern int abs (int __x) __THROW __attribute__ ((__const__)) __wur;
...
FreeBSD have a patch for that:
https://svnweb.freebsd.org/ports/head/x11-toolkits/gtkmathview/files/patch-src_widget_gtkmathview__common.cc?view=markup
For a version that quilt understands, plus DEP3 information, see the attachment.
I tested it using cowbuilder.
Juhani
Description: Fix "call of overloaded 'abs(guint32)' is ambiguous"
Author: Dmitry Marakasov <amd...@freebsd.org>
Origin: https://svnweb.freebsd.org/ports/head/x11-toolkits/gtkmathview/files/patch-src_widget_gtkmathview__common.cc?view=markup
Bug-Debian: https://bugs.debian.org/853436
Last-Update: 2017-12-19
--- a/src/widget/gtkmathview_common.cc
+++ b/src/widget/gtkmathview_common.cc
@@ -909,7 +909,7 @@
math_view->select_state == SELECT_STATE_NO &&
fabs(math_view->button_press_x - event->x) <= CLICK_SPACE_RANGE &&
fabs(math_view->button_press_y - event->y) <= CLICK_SPACE_RANGE &&
- abs(math_view->button_press_time - event->time) <= CLICK_TIME_RANGE)
+ abs((long)math_view->button_press_time - (long)event->time) <= CLICK_TIME_RANGE)
{
// the mouse should have not moved more than one pixel in each direction
// and the time elapsed from the press event should be no more than 250ms
@@ -969,7 +969,7 @@
(math_view->select_state == SELECT_STATE_YES ||
fabs(math_view->button_press_x - x) > CLICK_SPACE_RANGE ||
fabs(math_view->button_press_y - y) > CLICK_SPACE_RANGE ||
- abs(math_view->button_press_time - event->time) > CLICK_TIME_RANGE))
+ abs((long)math_view->button_press_time - (long)event->time) > CLICK_TIME_RANGE))
{
if (math_view->select_state == SELECT_STATE_NO)
{
