Your message dated Thu, 28 Sep 2017 07:19:06 +0000 with message-id <e1dxt6a-000eip...@fasolo.debian.org> and subject line Bug#876940: fixed in boinc 7.8.2+dfsg-4 has caused the Debian Bug report #876940, regarding boinc: Depends on libwxgtk-webview3.0-0v5 which depends on webkit1 to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 876940: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=876940 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: boinc Version: 7.8.2+dfsg-3 Severity: serious Tags: sid buster patch User: pkg-webkit-maintain...@lists.alioth.debian.org Usertags: oldlibs libwebkitgtk-1.0-0 webkit1 Control: block 790222 by -1 boinc-manager depends on libwxgtk-webview3.0-0v5 which depends on libwxgtk-webview3.0-0v5 which depends on libwebkitgtk-1.0-0. libwebkitgtk-1.0-0 is the old webkitgtk library that suffers from many reported CVEs that have been fixed in libwebkit2gtk-4.0-37 (src: webkit2gtk ). The pkg-webkit maintainers do not intend to release Debian 10 "Buster" with libwebkitgtk-1.0-0. boinc-manager is the only reverse dependency of libwxgtk-webview3.0-0v5, and apparently will soon be the only package blocking removal of webkit1. I've attached a patch which changes boinc-manager to use wxHtmlWindow instead of wxWebView. I can build the package with this patch applied, but I don't know boinc well enough to usefully test its functionality. wxHtmlWindow is not a full-featured web browser, but hopefully this gives a usable application - please test it out. Cheers, Ollydiff -Nru boinc-7.8.2+dfsg/debian/changelog boinc-7.8.2+dfsg/debian/changelog --- boinc-7.8.2+dfsg/debian/changelog 2017-09-07 19:41:28.000000000 +1200 +++ boinc-7.8.2+dfsg/debian/changelog 2017-09-27 11:13:58.000000000 +1300 @@ -1,3 +1,10 @@ +boinc (7.8.2+dfsg-3exp1.1) unstable; urgency=medium + + * Non-maintainer upload. + * Switch to use wxHtmlWindow instead of wxWebView. + + -- Olly Betts <o...@survex.com> Wed, 27 Sep 2017 11:13:58 +1300 + boinc (7.8.2+dfsg-3exp1) experimental; urgency=medium * Upload to experimental again, with the boinc-server-* packages. diff -Nru boinc-7.8.2+dfsg/debian/control boinc-7.8.2+dfsg/debian/control --- boinc-7.8.2+dfsg/debian/control 2017-09-07 19:41:28.000000000 +1200 +++ boinc-7.8.2+dfsg/debian/control 2017-09-27 11:13:58.000000000 +1300 @@ -26,7 +26,6 @@ libsqlite3-dev, libssl-dev, libtool, - libwxgtk-webview3.0-dev, libwxgtk3.0-dev, libxcb-util0-dev, libxi-dev, diff -Nru boinc-7.8.2+dfsg/debian/control.in boinc-7.8.2+dfsg/debian/control.in --- boinc-7.8.2+dfsg/debian/control.in 2017-09-06 18:23:42.000000000 +1200 +++ boinc-7.8.2+dfsg/debian/control.in 2017-09-27 11:07:10.000000000 +1300 @@ -26,7 +26,6 @@ libsqlite3-dev, libssl-dev, libtool, - libwxgtk-webview3.0-dev, libwxgtk3.0-dev, libxcb-util0-dev, libxi-dev, diff -Nru boinc-7.8.2+dfsg/debian/patches/series boinc-7.8.2+dfsg/debian/patches/series --- boinc-7.8.2+dfsg/debian/patches/series 2017-09-07 19:36:02.000000000 +1200 +++ boinc-7.8.2+dfsg/debian/patches/series 2017-09-27 11:13:58.000000000 +1300 @@ -30,3 +30,4 @@ fix-underlinking.patch static_scientific_apps.patch 0001-Fix-build-with-new-glibc-2.26.patch +use-wxhtmlwindow-instead-of-wxwebview.patch diff -Nru boinc-7.8.2+dfsg/debian/patches/use-wxhtmlwindow-instead-of-wxwebview.patch boinc-7.8.2+dfsg/debian/patches/use-wxhtmlwindow-instead-of-wxwebview.patch --- boinc-7.8.2+dfsg/debian/patches/use-wxhtmlwindow-instead-of-wxwebview.patch 1970-01-01 12:00:00.000000000 +1200 +++ boinc-7.8.2+dfsg/debian/patches/use-wxhtmlwindow-instead-of-wxwebview.patch 2017-09-27 11:13:58.000000000 +1300 @@ -0,0 +1,104 @@ +Description: Use wxHtmlWindow instead of wxWebView +Author: Olly Betts <o...@survex.com> +Forwarded: no +Last-Update: 2017-09-26 + +--- a/clientgui/NoticeListCtrl.cpp ++++ b/clientgui/NoticeListCtrl.cpp +@@ -50,8 +50,8 @@ + BEGIN_EVENT_TABLE( CNoticeListCtrl, wxWindow ) + + ////@begin CNoticeListCtrl event table entries +- EVT_WEBVIEW_NAVIGATING(ID_LIST_NOTIFICATIONSVIEW, CNoticeListCtrl::OnLinkClicked) +- EVT_WEBVIEW_ERROR(ID_LIST_NOTIFICATIONSVIEW, CNoticeListCtrl::OnWebViewError) ++ EVT_HTML_LINK_CLICKED(ID_LIST_NOTIFICATIONSVIEW, CNoticeListCtrl::OnLinkClicked) ++// EVT_WEBVIEW_ERROR(ID_LIST_NOTIFICATIONSVIEW, CNoticeListCtrl::OnWebViewError) + ////@end CNoticeListCtrl event table entries + + END_EVENT_TABLE() +@@ -84,7 +84,7 @@ + wxWindow::Create( parent, ID_LIST_NOTIFICATIONSVIEW, wxDefaultPosition, wxDefaultSize, + wxSUNKEN_BORDER | wxTAB_TRAVERSAL ); + +- m_browser = wxWebView::New( this, ID_LIST_NOTIFICATIONSVIEW ); ++ m_browser = new wxHtmlWindow( this, ID_LIST_NOTIFICATIONSVIEW ); + ////@end CNoticeListCtrl creation + + wxBoxSizer *topsizer; +@@ -238,7 +238,7 @@ + m_noticesBody += wxT("</font></body></html>"); + // baseURL is not needed here (see comments above) and it + // must be an empty string for this to work under OS 10.12.4 +- m_browser->SetPage(m_noticesBody, wxEmptyString); ++ m_browser->SetPage(m_noticesBody); + } + + +@@ -248,22 +248,27 @@ + } + + +-void CNoticeListCtrl::OnLinkClicked( wxWebViewEvent& event ) { +- if (event.GetURL().StartsWith(wxT("http://";)) || event.GetURL().StartsWith(wxT("https://";))) { +- event.Veto(); // Tell wxWebView not to follow link +- wxLaunchDefaultBrowser(event.GetURL()); ++void CNoticeListCtrl::OnLinkClicked( wxHtmlLinkEvent& event ) { ++ wxString url = event.GetLinkInfo().GetHref(); ++ if (url.StartsWith(wxT("http://";)) || url.StartsWith(wxT("https://";))) { ++ // wxHtmlLinkEvent doesn't have Veto(), but only loads the page if you ++ // call Skip(). ++ // event.Veto(); // Tell wxWebView not to follow link ++ wxLaunchDefaultBrowser(url); + } else { + event.Skip(); + } + } + + ++#if 0 + void CNoticeListCtrl::OnWebViewError( wxWebViewEvent& event ) { + fprintf(stderr, "wxWebView error: target=%s, URL=%s\n", + (event.GetTarget().ToStdString()).c_str(), (event.GetURL().ToStdString()).c_str()); + + event.Skip(); + } ++#endif + + + /*! +--- a/clientgui/NoticeListCtrl.h ++++ b/clientgui/NoticeListCtrl.h +@@ -45,8 +45,8 @@ + + ////@begin CNoticeListCtrl event handler declarations + +- void OnLinkClicked( wxWebViewEvent& event ); +- void OnWebViewError( wxWebViewEvent& event ); ++ void OnLinkClicked( wxHtmlLinkEvent& event ); ++// void OnWebViewError( wxWebViewEvent& event ); + + ////@end CNoticeListCtrl event handler declarations + +@@ -56,7 +56,7 @@ + bool m_bDisplayFetchingNotices; + bool m_bDisplayEmptyNotice; + private: +- wxWebView* m_browser; ++ wxHtmlWindow* m_browser; + bool m_bNeedsReloading; + int m_itemCount; + wxString m_noticesBody; +--- a/clientgui/stdwx.h ++++ b/clientgui/stdwx.h +@@ -117,8 +117,11 @@ + #include <wx/mstream.h> + #include <wx/hash.h> + #include <wx/selstore.h> ++#if 0 + #include <wx/webview.h> + #include <wx/webviewfshandler.h> ++#endif ++#include <wx/html/htmlwin.h> + #include <wx/snglinst.h> + #include <wx/bmpcbox.h> + #include <wx/evtloop.h>
--- End Message ---
--- Begin Message ---Source: boinc Source-Version: 7.8.2+dfsg-4 We believe that the bug you reported is fixed in the latest version of boinc, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 876...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Gianfranco Costamagna <locutusofb...@debian.org> (supplier of updated boinc package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Thu, 28 Sep 2017 08:52:47 +0200 Source: boinc Binary: boinc boinc-client-nvidia-cuda boinc-client-opencl boinc-client boinc-screensaver boinc-manager boinc-dev libboinc-app-dev libboinc-app7 libboinc7 Architecture: source Version: 7.8.2+dfsg-4 Distribution: unstable Urgency: medium Maintainer: Debian BOINC Maintainers <pkg-boinc-de...@lists.alioth.debian.org> Changed-By: Gianfranco Costamagna <locutusofb...@debian.org> Description: boinc - metapackage for the BOINC client and the manager boinc-client - core client for the BOINC distributed computing infrastructure boinc-client-nvidia-cuda - metapackage for CUDA-savvy BOINC client and manager boinc-client-opencl - metapackage for AMD/ATI OpenCL-savvy BOINC client and manager boinc-dev - development files to build applications for BOINC projects (trans boinc-manager - GUI to control and monitor the BOINC core client boinc-screensaver - screen saver auto-controlling volunteer computing libboinc-app-dev - development files to build applications for BOINC projects libboinc-app7 - libraries for BOINC's scientific applications libboinc7 - libraries of BOINC the client depends on Closes: 876940 Changes: boinc (7.8.2+dfsg-4) unstable; urgency=medium . * Upload to unstable * Ack NMU from Olly Betts, with a *great* thanks * Fix build failure for hurd . [ Olly Betts ] * Switch to use wxHtmlWindow instead of wxWebView (Closes: #876940). Checksums-Sha1: 481dc394f3fcbc943524064c27c5b721edb5bf4b 3013 boinc_7.8.2+dfsg-4.dsc 172b3fcffacbecbdab1a743494c27126e9611f8e 452724 boinc_7.8.2+dfsg-4.debian.tar.xz Checksums-Sha256: 4c7b210b9e0054ec53e3c1b6d57255095691454f6c512c7cdeee7f694bdd3fe1 3013 boinc_7.8.2+dfsg-4.dsc 9d034a12eebf27ef42d34b1f31303a59d847fa65cff73d91fe38aca34ad9b4e4 452724 boinc_7.8.2+dfsg-4.debian.tar.xz Files: 7d90628b8f05c6583d4a8c7a3f56213c 3013 net optional boinc_7.8.2+dfsg-4.dsc 3f6ba4fc786364166c15eeb6f87a51cb 452724 net optional boinc_7.8.2+dfsg-4.debian.tar.xz -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJZzJ5uAAoJEPNPCXROn13ZUwkP/ixQVjER5Bm7ly3nKTAqh5gy tCpZ5Y95nxqYJjiZybV3hHqbRvB++EjkE0W69OAqJ05AaCXFGllN+2Wv3m+AFw4y zRysodXHjbMiol1SFJAuxbqo9dnewE+9ub67pbkcU4PhJqbedj1bnpRFARs/JhPo Evfeejl3+Sote1bS3b5fIUCcVrrLbr+PYD9nwjaDedTwNckZCJnTnb37XIPTxORZ Fim9Z5/zxkmAkRRaQd6HFHy15RsiJdVucktcJJUJjVi1DlBpwzAOt6CW/adR8EyI m6o+FAKlcHAs3SPmLZjssZCwSnynD+U8dm4rFkrJC95mP2f1bma1dwS0WHhE0Kri sa2+4SyiIgsd2h9JDcMU4LQJ9WOp4AydQ1TZyV/TlIl386Ncw1mh/8qc6o1SFjVQ VZJP5JURzhSrLQhVoMZVMR32rcYFXr1ninnX4Xv9n3meBphytLqwiCYk406VVz/L M4ZZCHrkaAU1cmhLzrVvoFoAx8Tpz0xEJQzfGBZA2cU8fWdXhcwO738rNYYqes9r Q5uxuij3nbOg9AbTCA2Toisu+Wj+3+w6jZcB2O+jtpCIRO3idOumZbE8iQunpsyM rq8tY/YgE9VuuIfg0lZUJC95TmtOGeFkmz/4TBYaZkl5icSs8hXDDikBOKuTT6EM dvj3G6Wocl96nwjQFywK =0ABE -----END PGP SIGNATURE-----
--- End Message ---
