On Fri, Aug 25, 2017 at 06:47:10PM +0200, Christoph Biedl wrote: > This has been fixed upstream. Please cherry-pick > https://github.com/miloyip/rapidjson/commit/fe19b7b6016d446722621fb407738209d1a911e8 > If you want to be nice to private backporters, please cherry-pick > the follow-up commit > https://github.com/miloyip/rapidjson/commit/cba45fe9de6923b858edb0780e257b7257aa4f7b > as well so the fix will not break builds when using older gcc versions.
While these upstream commits work, imho they are only a bit correct. A correct fix would be to disable -Werror alltogether. That "fix" above is just "do not emit a warning for this" anyway. That would also help for future changes... :) Regards, Rene