Source: emacs25
Version: 25.2+1-2
Severity: serious
Justification: builds without testsuite
Hi!
I'm not 100% sure whether this bug warrents the severity serious, but
since running the testsuites is normally mandatory on all release
architectures, I figured the priority should be high. Feel free to
downgrade the severity if necessary.
The debian/rules of emacs25 has:
ifneq (,$(filter nocheck, $(DEB_BUILD_OPTIONS)))
$(MAKE) -C debian/build-lucid check
$(MAKE) -C debian/build-nox check
$(MAKE) -C debian/build-x check
endif
This reads as "if DEB_BUILD_OPTIONS contains 'nocheck' don't run the
testsuite". This is, of course, wrong. It should be the other way
around, i.e. the testsuite should be run by default and be disabled
if "nocheck" is found in DEB_BUILD_OPTIONS. The fix is trivial:
Just replace the "ifneq" with "ifeq".
On a sidenote: I did that and noticed that the testsuite actually
fails. If that is the original reason for this bug, I would like
to ask to either temporarily comment out the section above or
disable the individual tests which are failing.
Either way, passing "nocheck" should never run the testsuite.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaub...@debian.org
`. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
