Control: tags -1 patch
On Wed, 12 Jul 2017 08:13:16 +0200 Christian Marillat
<maril...@debian.org> wrote:
> Package: dh-strip-nondeterminism
> Version: 0.037-1
> Severity: grave
>
> Dear Maintainer,
>
> When trying to build vlc :
>
> dh_strip_nondeterminism -O--parallel
> dh_strip_nondeterminism:
> debian/vlc-data/usr/share/vlc/lua/http/images/buttons.png: Undefined
> subroutine &Archive::Zip::computeCRC32 called at
> /usr/share/perl5/File/StripNondeterminism/handlers/png.pm line 33.
>
> Christian
>
> [...]
Hi,
Please find attached patch to solve this and also add some missing
File::StripNondeterminism imports (e.g. used for
$File::StripNondeterminism::canonical_time references).
Thanks,
~Niels
>From f98e14b42cc4c1b2670abb8ae5b4dcb646fa2aca Mon Sep 17 00:00:00 2001
From: Niels Thykier <ni...@thykier.net>
Date: Wed, 12 Jul 2017 06:26:30 +0000
Subject: [PATCH] Add missing use statements in handler modules
Signed-off-by: Niels Thykier <ni...@thykier.net>
---
lib/File/StripNondeterminism/handlers/ar.pm | 2 ++
lib/File/StripNondeterminism/handlers/cpio.pm | 2 ++
lib/File/StripNondeterminism/handlers/gettext.pm | 2 ++
lib/File/StripNondeterminism/handlers/gzip.pm | 1 +
lib/File/StripNondeterminism/handlers/jar.pm | 1 +
lib/File/StripNondeterminism/handlers/javadoc.pm | 1 +
lib/File/StripNondeterminism/handlers/pearregistry.pm | 1 +
lib/File/StripNondeterminism/handlers/png.pm | 2 ++
lib/File/StripNondeterminism/handlers/zip.pm | 1 +
9 files changed, 13 insertions(+)
diff --git a/lib/File/StripNondeterminism/handlers/ar.pm b/lib/File/StripNondeterminism/handlers/ar.pm
index 08a1925..94b38dc 100644
--- a/lib/File/StripNondeterminism/handlers/ar.pm
+++ b/lib/File/StripNondeterminism/handlers/ar.pm
@@ -25,6 +25,8 @@ use warnings;
use Fcntl q/SEEK_SET/;
+use File::StripNondeterminism;
+
sub normalize {
my ($file) = @_;
diff --git a/lib/File/StripNondeterminism/handlers/cpio.pm b/lib/File/StripNondeterminism/handlers/cpio.pm
index c733731..ac63489 100644
--- a/lib/File/StripNondeterminism/handlers/cpio.pm
+++ b/lib/File/StripNondeterminism/handlers/cpio.pm
@@ -19,6 +19,8 @@ package File::StripNondeterminism::handlers::cpio;
use strict;
use warnings;
+use File::StripNondeterminism;
+
sub normalize {
my ($file) = @_;
# if we cannot load the Cpio module, we just leave the file alone
diff --git a/lib/File/StripNondeterminism/handlers/gettext.pm b/lib/File/StripNondeterminism/handlers/gettext.pm
index 1d9b2b9..a63686f 100644
--- a/lib/File/StripNondeterminism/handlers/gettext.pm
+++ b/lib/File/StripNondeterminism/handlers/gettext.pm
@@ -24,6 +24,8 @@ use POSIX qw(strftime);
use strict;
use warnings;
+use File::StripNondeterminism;
+
sub read_file($) {
my $filename = shift;
diff --git a/lib/File/StripNondeterminism/handlers/gzip.pm b/lib/File/StripNondeterminism/handlers/gzip.pm
index 3afa62f..591abe4 100644
--- a/lib/File/StripNondeterminism/handlers/gzip.pm
+++ b/lib/File/StripNondeterminism/handlers/gzip.pm
@@ -21,6 +21,7 @@ package File::StripNondeterminism::handlers::gzip;
use strict;
use warnings;
+use File::StripNondeterminism;
use File::StripNondeterminism::Common qw(copy_data);
use File::Temp;
use File::Basename;
diff --git a/lib/File/StripNondeterminism/handlers/jar.pm b/lib/File/StripNondeterminism/handlers/jar.pm
index 2a58fb6..1162c03 100644
--- a/lib/File/StripNondeterminism/handlers/jar.pm
+++ b/lib/File/StripNondeterminism/handlers/jar.pm
@@ -21,6 +21,7 @@ package File::StripNondeterminism::handlers::jar;
use strict;
use warnings;
+use File::StripNondeterminism;
use File::StripNondeterminism::Common qw(copy_data);
use Archive::Zip;
use File::Basename;
diff --git a/lib/File/StripNondeterminism/handlers/javadoc.pm b/lib/File/StripNondeterminism/handlers/javadoc.pm
index 4f789f5..5d98242 100644
--- a/lib/File/StripNondeterminism/handlers/javadoc.pm
+++ b/lib/File/StripNondeterminism/handlers/javadoc.pm
@@ -22,6 +22,7 @@ package File::StripNondeterminism::handlers::javadoc;
use strict;
use warnings;
+use File::StripNondeterminism;
use File::StripNondeterminism::Common qw(copy_data);
use File::Temp;
use File::Basename;
diff --git a/lib/File/StripNondeterminism/handlers/pearregistry.pm b/lib/File/StripNondeterminism/handlers/pearregistry.pm
index c5a0363..a181f67 100644
--- a/lib/File/StripNondeterminism/handlers/pearregistry.pm
+++ b/lib/File/StripNondeterminism/handlers/pearregistry.pm
@@ -21,6 +21,7 @@ package File::StripNondeterminism::handlers::pearregistry;
use strict;
use warnings;
+use File::StripNondeterminism;
use File::StripNondeterminism::Common qw(copy_data);
use File::Temp;
use File::Basename;
diff --git a/lib/File/StripNondeterminism/handlers/png.pm b/lib/File/StripNondeterminism/handlers/png.pm
index 861add3..fc2e827 100644
--- a/lib/File/StripNondeterminism/handlers/png.pm
+++ b/lib/File/StripNondeterminism/handlers/png.pm
@@ -22,7 +22,9 @@ package File::StripNondeterminism::handlers::png;
use strict;
use warnings;
+use Archive::Zip ();
use File::Temp;
+use File::StripNondeterminism;
use File::StripNondeterminism::Common qw(copy_data);
use File::Basename qw/dirname/;
use POSIX qw/strftime/;
diff --git a/lib/File/StripNondeterminism/handlers/zip.pm b/lib/File/StripNondeterminism/handlers/zip.pm
index de1516b..626569f 100644
--- a/lib/File/StripNondeterminism/handlers/zip.pm
+++ b/lib/File/StripNondeterminism/handlers/zip.pm
@@ -22,6 +22,7 @@ use strict;
use warnings;
use File::Temp;
+use File::StripNondeterminism;
use Archive::Zip qw/:CONSTANTS :ERROR_CODES/;
# A magic number from Archive::Zip for the earliest timestamp that
--
2.13.2
