Jonathan Nieder writes ("Re: dgit clone dies with "setup_git_env called without
repository""):
> Please cc g...@packages.debian.org the next time you do this. Otherwise
> the message doesn't show up in mail.
Sorry about that.
> > Hi. We have tripped over an accidental and incompatible change in the
> > behaviour of git config --local:
> >
> > $ pwd
> > /home/ian
> > $ dpkg -s git | grep '^Version'
> > Version: 1:2.13.1-1
> > $ git config --local --get-regexp '.*'
> > fatal: BUG: setup_git_env called without repository
> > $ echo $?
> > 128
>
> Thanks for reporting. This is fixed by v2.13.2~26^2~1:
Thanks for digging out that message.
> > Please would you consider returning to the previous behaviour, for
> > compatibility with other existing callers of git.
>
> I don't think that that is the right thing to do. The old behavior
> was accidental and broken.
That's a shame, since it was documented and I was relying on it. It
seemed sensible to me. (NB I'm not saying git should read .git/config
willy-nilly, just that when there is no local tree it should consider
--local to be empty, instead of bombing out.)
> If you simply omit the --local option then
> I think that will give you the behavior you are looking for (if I
> understand what you are looking for correctly).
dgit needs to slurp the whole of the three config sources in so that
it can do defaulting in the right order (and avoid very poor
performance, too).
I will change dgit know to avoid trying to think about the --local
config when it's doing dgit clone (which is the one operation which
doesn't take place in a working tree).
> That said, I am happy to add a 'Breaks' to ensure smooth upgrades.
> Let me know what version to add a Breaks against and I'll add it.
Please add
Breaks: dgit (<< 3.11~)
I haven't made 3.11 yet but I will do so as soon as I don't have
another more imminent crisis. I will try to get it into stable and
appropriate backports.
> Also, if you have ideas for clarifying the documentation then that
> would also be welcome.
I'll think about this. I guess you would like a new bug for that ?
Regards,
Ian.
