Your message dated Sun, 25 Jun 2017 17:04:16 +0000
with message-id <e1dpaxm-0004eg...@fasolo.debian.org>
and subject line Bug#863961: fixed in debhelper 10.5
has caused the Debian Bug report #863961,
regarding Optimisation to avoid calling Getopt makes some CDBS packages (and
CDBS itself) FTBFS
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
863961: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=863961
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: debhelper
Version: 10.4
Severity: serious
Tags: patch
Hi,
tl;dr this is caused by 91b064a0baea0ef37937bce56e5b080ac5a52595.
When building cdbs from sid with 10.4:
14: build hdparm FAILED (hdparm.at:18)
This package has a "common-install-prehook-arch::" rule. That rule is no
longer being called. I had a look and here's what I think is happening:
Dh_Getopt has code like this:
if (! defined $dh{DOPACKAGES} || ! @{$dh{DOPACKAGES}}) {
if ($dh{DOINDEP} || $dh{DOARCH}) {
# User specified that all arch (in)dep package be
# built, and there are none of that type.
if (! $dh{BLOCK_NOOP_WARNINGS}) {
warning("You asked that all arch in(dep) packages be built, but there
are none of that type.");
}
exit(0);
}
push @{$dh{DOPACKAGES}},getpackages("both");
}
to exit if there's no arch/indep packages but you've given -a/-i. This
wasn't being done in the optimised loop introduced by that commit. So we
were continuing to run commands even when there was nothing for them to
act on. Somehow(! don't know exactly why) that confused CDBS.
We can copy that short circuit into the optimised loop and then things
seem good. Here's a patch.
Cheers,
--
Iain Lane [ i...@orangesquash.org.uk ]
Debian Developer [ la...@debian.org ]
Ubuntu Developer [ la...@ubuntu.com ]
>From ce55f9c5888dbc7e3ab2403e41fdc43675d4996b Mon Sep 17 00:00:00 2001
From: Iain Lane <la...@debian.org>
Date: Fri, 2 Jun 2017 11:40:47 +0100
Subject: [PATCH] Dh_Lib: When passing -a/-i only, and there are no arch/indep
packages, exit
This was accidentally removed when optimising a common case.
---
Debian/Debhelper/Dh_Lib.pm | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Debian/Debhelper/Dh_Lib.pm b/Debian/Debhelper/Dh_Lib.pm
index fb5752d7..1f6d6e8c 100644
--- a/Debian/Debhelper/Dh_Lib.pm
+++ b/Debian/Debhelper/Dh_Lib.pm
@@ -73,6 +73,13 @@ sub init {
push(@{$dh{DOPACKAGES}}, getpackages('arch'));
$dh{DOARCH} = 1;
}
+
+ if (! @{$dh{DOPACKAGES}}) {
+ if (! $dh{BLOCK_NOOP_WARNINGS}) {
+ warning("You asked that all arch in(dep)
packages be built, but there are none of that type.");
+ }
+ exit(0);
+ }
# Clear @ARGV so we do not hit the expensive case below
@ARGV = ();
}
--
2.11.0
--- End Message ---
--- Begin Message ---
Source: debhelper
Source-Version: 10.5
We believe that the bug you reported is fixed in the latest version of
debhelper, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 863...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Niels Thykier <ni...@thykier.net> (supplier of updated debhelper package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 25 Jun 2017 17:00:00 +0000
Source: debhelper
Binary: debhelper dh-systemd
Architecture: source
Version: 10.5
Distribution: unstable
Urgency: medium
Maintainer: Debhelper Maintainers <debhelper-de...@lists.alioth.debian.org>
Changed-By: Niels Thykier <ni...@thykier.net>
Description:
debhelper - helper programs for debian/rules
dh-systemd - debhelper add-on to handle systemd unit files - transitional pack
Closes: 761024 858467 861852 862844 863447 863887 863961 865363 865708
Changes:
debhelper (10.5) unstable; urgency=medium
.
* Upload to unstable. (Closes: #865363)
.
[ Niels Thykier ]
* dh_installman: Remove unncessary "chown" call that made things a
lot slower. Thanks to Kurt Roeckx for reporting it.
* dh_installman: Fix wrong permission of man pages (set 0755 instead
of 0644). Regression introduced in 10.2.2.
* dh_installman: Batch chmod calls to reduce the overhead for
packages with many manpages.
* dh: Undo an unsafe optimisation that caused "-indep" and "-arch"
override targets to be ignored. Thanks to Gianfranco Costamagna
for reporting it and Iain Lane for tracing it to the commit
that introduced the issue. (Closes: #863887)
* dh_clean, dh_prep: Bulk delete most files and directories, which
gives a noticeable speed up for source packages building many
binary packages.
* dh_shlibdeps: Avoid creating debian/<pkg>/DEBIAN directory if it
is not needed.
* Dh_Lib.pm: Fix typo in error message.
* Dh_Lib.pm: Rewrite install_* to use File::Copy to avoid the
overhead of a fork+exec per file. For simplicity, the verbose
output still claim debhelper uses "install -p -m <mode>" for this.
* Dh_Lib.pm: Replace most of the fork+exec calls to mv for simple
file renames.
* Dh_Lib.pm: Add sub to make common dh_* tools do their thing in
parallel with very little coding effort. This parallel support
accounts for DEB_BUILD_OPTIONS to set the upper limit.
* dh_fixperms: Run package updates in parallel if DEB_BUILD_OPTIONS
permits it.
* dh_installchangelogs: Ditto.
* dh_compress: Ditto.
* dh_installman: Ditto.
* dh_genchanges: Ditto.
* dh_shlibdeps: Ditto.
* dh_md5sums: Ditto.
* dh_builddeb: Rewrite the hand-written parallel code to use the new
simpler way of doing it.
* dh_shlibdeps: Avoid calling file(1) on debug symbols.
* SUPPORT-POLICY: Include new document that describes the current
support policy of debhelper compat levels.
* Dh_Lib.pm: Pass ":unix" layer when using the ":gzip" layer due to
PerlIO-gzip bug RT#114557.
* Dh_Lib.pm: Ignore empty dpkg-architecture variables.
(Closes: #862844)
* dh_installchangelogs: Avoid trying to install a directory by default
as a changelog file. Thanks to Markus Koschany for reporting the
issue. (Closes: #861852)
* dh_installwm.1: Correct documentation to reflect the behaviour in
compat 10. Thanks to Robert Luberda for reporting the issue.
(Closes: #865708)
* dh_installcatalogs: Use explicit await triggers to avoid trigger
a lintian warning.
* dh_installman: In compat 11, attempt to detect the language of the
manpage based on the directory (/man/<LANG>/manX/) before using the
extension. This is more reliably for packages using dh_installman
to install manpages from the temporary install dir.
(Closes: #761024)
* dh_installcatalogs: Check the return code of close when generating
a catalog for sgml-base.
* Dh_Lib.pm: Emulate "install -d" with File::Path to avoid a fork+exec
for creating directories. For simplicity, the verbose output still
claim debhelper uses "install -d" for this.
* dh_auto_install: In compat 11, do noot create package build
directories (except if one of them happens to be the default
"destdir" for dh_auto_install).
.
[ Iain Lane ]
* Dh_Lib: Re-add warning + exit 0 for the -i/-a shortcut that was
added in 10.3. (Closes: #863961)
* dh_install: Pass --exclude/-X to dh_missing. (Closes: #863447)
.
[ Michael Stapelberg ]
* Dh_Getopt: Provide a more detailed error message when there are
no buildable packages caused by architecture restrictions.
(Closes: #858467)
* Dh_Lib: Split package_arch($package) into three distinct functions.
Checksums-Sha1:
07141fe9b0b28542d4591953788ab0d909f16d10 1725 debhelper_10.5.dsc
f83393626fad615a647fe04957c8bd4594b16f82 402388 debhelper_10.5.tar.xz
074f49f0995b86cafd65b2ada4daf6284f1405da 4561 debhelper_10.5_source.buildinfo
Checksums-Sha256:
feda090a3ecfa049fbb0f3701a03274c77a4eb12d0c7ac9148d6c659997070c6 1725
debhelper_10.5.dsc
9f551ddef6d8a3fdd87b9bda7bc1c6c9bc1d9d33e9fb906ca5429071ce85cd3e 402388
debhelper_10.5.tar.xz
bbd246e4cc6d7b6ea43dff1e6986069b66d5721b602f77518b9a82e6bf44bdbe 4561
debhelper_10.5_source.buildinfo
Files:
e83f0415bfc368d41c3babf5166aedb2 1725 devel optional debhelper_10.5.dsc
599c99263cc45149d428cdcc8489c143 402388 devel optional debhelper_10.5.tar.xz
21de809692a1041b548c01839a40d102 4561 devel optional
debhelper_10.5_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEsxMaRR2/33ygW0GXBUu7n32AZEIFAllP63UACgkQBUu7n32A
ZEKkUw//X/EA/94cEznTnhxpgFmGNHgi8+V/t1LfkjgYU+iJzxOB2VuBfh3D0i86
wtXjbzZhMq/DvjNV031R53ZZkO1zuilkxsr6sUeQqVSiKA2LiQsySl1oSgtfaBKp
hHLLjSvrRY64iFdABLZKGCfRz98xyOVNLvUr1tbMBGu+VX10p3weYTmJoels7qbj
x3OHR6y8bxTtBp25sylu+Tx7mep8ATPyfhP0D3B/DJ59gBhnKvPqtlcK8H5idXU+
EQBv9cOlEAIRbd34N5xV42SSEHZMwbtAODZUWJ406NMMvCuEhtS/6Iel0D7906Ze
36afpB9QO85jvCeChGo9LR7r5v8q48NVjsNEII/305rK9Nsf/xsMF79d2IIc0BqL
LqMjVzs7FIeGhOH6yksa1e64ZejpJUuG/69XKpMzXkiTMBZ9iE/eadVXGjeNcz+n
Ztm8pBPxUvcjSob3IHE5fXtGZBgiOiOPQxiQ6PCKqF3cKbT6pyZStA2gh74JVWfh
+ceGSHrPHRTD7dlVXnCLnaA0GS+Z6B3rjlZeUrBUbn+UVI8El1J7zOSbVmy0EqJ4
IM8GsPIq6O6nZmClG2tJ52XUnIagG1EY+lifsO3BPLf4ebDACbWwy6655x0g2qcf
nYAWi/kVF6XrYt8ho2jcItZhBW/RtqtqOfot3vDuYY7DBL8XFcg=
=xboq
-----END PGP SIGNATURE-----
--- End Message ---
