On Friday, June 23, 2017 08:18:44 PM Gianfranco Costamagna wrote: > Hello Scott! > > >I'm not the maintainer, just an interest maintainer of a reverse > >dependency. > thanks for your caring (help and feedbacks are appreciated a lot!) :) > > >First, all the home page changes are inappropriate for an NMU. I would > >recommend you file a separate, normal priority, bug about those issues. > > well, since I spent almost a day trying to understand where upstream did > take the patches (because haskell builds with the embedded haskell-yaml > package), I prefer to make sure nobody else looses his time :) > (I also bothered upstream to change the repo location from the wiki BTW)
I understand it's inconvenient, but it's not RC. As long as you file another bug, it won't get lost. > >Second, have you checked if this breaks anything else? > > right now, reverse-deps testsuites are not affected by this upload ... > >I'm particularly concerned you don't break pyyaml (since I maintain that > >one). Before NMUing, I think you should make sure you aren't trading one > >broken package for another. > > actually the fix has been originally intended to unbreak the python binding > of yaml (some of them has a testsuite broken, maybe not pyyaml, or maybe not > right now, but some python binding should be broken without this patch, > aswell as the haskell one) > > > I did a test rebuild in a ppa (most of the versions are in sync with > Debian), and I didn't get any build failures. > https://launchpad.net/~costamagnagianfranco/+archive/ubuntu/costamagnagianfr > anco-ppa/+packages > > so, I can say that we should be good with this one, at least if > reverse-dependencies testsuites are good enough :p Not so fast. Apparently all you looked at were autopkgtests. Pyyaml runs the test suite during build (although failures are non-fatal - I should probably change that). Looking at the i386 build logs (common architecture with logs available for both your PPA[1] and Debian[2]), I see zero test failures in Debian and four in your PPA. I don't think we're good on reverse-dependencies. I think this needs more investigation before you go ahead. Scott K [1] https://launchpadlibrarian.net/325269141/buildlog_ubuntu-artful-i386.pyyaml_3.12-1build2_BUILDING.txt.gz [2] https://buildd.debian.org/status/fetch.php?pkg=pyyaml&arch=i386&ver=3.12-1&stamp=1472969660&raw=0
