Control: tags -1 patch Hi all,
On Sun, 30 Apr 2017 12:38:33 +0200 Lukas <h...@zwergenfeste.ch> wrote: > Hi > > Got the same problem on stretch. > > Changing the systemd service type to simple solves the problem for me: > > echo "Type=simple" >> /lib/systemd/system/slim.service > systemctl daemon-reload > > So, i guess the dbus name can't be acquired... > > BR > > Lukas So, to recap, this is due to the fix for #860465, which is part of 1.3.6-5. It appears that in order to fix plymouth handling, the service file was modified to include a number of things slim currently does *not* support: - BusName=org.freedesktop.DisplayManager which was added to the unit file silently converts the unit to Type=dbus and instructs systemd to expect slim to bind the org.freedesktop.DisplayManager endpoint on the system bus before it marks the service as running. However, grepping the source indicates that slim is completely unaware of dbus. Thus this directive causes systemd to endlessly restart slim every TimeoutStartSec seconds. - Moreover, slim seems to not be able to stop plymouth by itself, contrary to what is stated in the service file. This is also reflected by the manual handling of plymouth in the upstart and initscript files. The attached debdiff resolves the restart loop, while ensuring that slim plays nice with plymouth. If nobody responds, I intend to NMU the package tomorrow. Regards, Apollon
diff -Nru slim-1.3.6/debian/changelog slim-1.3.6/debian/changelog --- slim-1.3.6/debian/changelog 2017-04-23 19:14:21.000000000 +0300 +++ slim-1.3.6/debian/changelog 2017-05-02 16:48:36.000000000 +0300 @@ -1,3 +1,11 @@ +slim (1.3.6-5.1) unstable; urgency=medium + + * Non-maintainer upload. + * slim.service: drop BusName and Conflicts/OnFailure=plymouth-quit.service + (Closes: #861474) + + -- Apollon Oikonomopoulos <apoi...@debian.org> Tue, 02 May 2017 16:48:36 +0300 + slim (1.3.6-5) unstable; urgency=medium * Fix bugged Debian-Lines theme. (Closes: #776693) diff -Nru slim-1.3.6/debian/patches/fix-missing-plymouth-handling.patch slim-1.3.6/debian/patches/fix-missing-plymouth-handling.patch --- slim-1.3.6/debian/patches/fix-missing-plymouth-handling.patch 2017-04-23 18:38:28.000000000 +0300 +++ slim-1.3.6/debian/patches/fix-missing-plymouth-handling.patch 2017-05-02 16:46:20.000000000 +0300 @@ -5,20 +5,11 @@ --- a/slim.service +++ b/slim.service -@@ -2,7 +2,16 @@ +@@ -1,6 +1,6 @@ + [Unit] Description=SLiM Simple Login Manager - After=systemd-user-sessions.service +-After=systemd-user-sessions.service ++After=systemd-user-sessions.service plymouth-quit.service -+# replaces plymouth-quit since slim quits plymouth on its own -+Conflicts=plymouth-quit.service -+After=plymouth-quit.service -+ -+# slim takes responsibility for stopping plymouth, so if it fails -+# for any reason, make sure plymouth still stops -+OnFailure=plymouth-quit.service -+ [Service] ExecStartPre=/bin/sh -c '[ "$(cat /etc/X11/default-display-manager 2>/dev/null)" = "/usr/bin/slim" ]' - ExecStart=/usr/bin/slim -nodaemon - Restart=always -+BusName=org.freedesktop.DisplayManager
