Control: reassign -1 src:dask 0.12.0-1 Control: severity -1 important Control: tags -1 +patch
Hi, On Sun, Apr 30, 2017 at 07:31:26PM +0000, Gianfranco Costamagna wrote: > Hello, I'm not sure if this is a problem in sphinx or not, > I noticed this failure on src:dask in Ubuntu, and it is > reproducible with 1.5.3 and 1.5.5 in Ubuntu artful and Debian experimental. > > For some reasons the _static directory is not copied correctly during doc > generation, > and the build fails because of a missing symlink > > dh_installdocs -O--buildsystem=pybuild > dh_sphinxdoc -O--buildsystem=pybuild > dh_sphinxdoc: > debian/python-dask-doc/usr/share/doc/python-dask-doc/html/_static/mathjax/MathJax.js > is missing > debian/rules:5: recipe for target 'binary' failed > > Can you please have a look and reassing back in case? The documentation says that files and directories are copied; it does not say anything about the symlinks. So it looks to me that dask was using undocumented behavior here. Also, it seems that mathjax is not actually used, so I am attaching a debdiff to get rid of it (also uploaded to Ubuntu and forwarded). -- Dmitry Shachnev
--- dask-0.12.0/debian/control 2016-12-07 21:54:28.000000000 +0300
+++ dask-0.12.0/debian/control 2017-05-01 20:53:17.000000000 +0300
@@ -4,7 +4,6 @@
Priority: optional
Build-Depends: debhelper (>= 9),
dh-python,
- libjs-mathjax,
python3-all,
python3-cloudpickle (>= 0.2.1),
python3-numpy,
--- dask-0.12.0/debian/patches/no-mathjax-extension.patch 1970-01-01 03:00:00.000000000 +0300
+++ dask-0.12.0/debian/patches/no-mathjax-extension.patch 2017-05-01 20:53:17.000000000 +0300
@@ -0,0 +1,16 @@
+Description: drop sphinx.ext.mathjax extension, it is unused
+Author: Dmitry Shachnev <mity...@debian.org>
+Forwarded: https://github.com/dask/dask/pull/2280
+Last-Update: 2017-05-01
+
+--- a/docs/source/conf.py
++++ b/docs/source/conf.py
+@@ -25,7 +25,7 @@
+
+ # Add any Sphinx extension module names here, as strings. They can be extensions
+ # coming with Sphinx (named 'sphinx.ext.*') or your custom ones.
+-extensions = ['sphinx.ext.autodoc', 'sphinx.ext.mathjax',
++extensions = ['sphinx.ext.autodoc',
+ 'sphinx.ext.autosummary', 'sphinx.ext.extlinks', 'numpydoc']
+
+ numpydoc_show_class_members = False
--- dask-0.12.0/debian/patches/series 2016-12-07 21:54:28.000000000 +0300
+++ dask-0.12.0/debian/patches/series 2017-05-01 20:53:17.000000000 +0300
@@ -1 +1 @@
-use-mathjax-package.patch
+no-mathjax-extension.patch
--- dask-0.12.0/debian/patches/use-mathjax-package.patch 2016-12-07 21:54:28.000000000 +0300
+++ dask-0.12.0/debian/patches/use-mathjax-package.patch 1970-01-01 03:00:00.000000000 +0300
@@ -1,14 +0,0 @@
-Author: Diane Trout <di...@ghic.org>
-Description: Use locally installed MathJax
-
---- a/docs/source/conf.py
-+++ b/docs/source/conf.py
-@@ -28,6 +28,8 @@
- extensions = ['sphinx.ext.autodoc', 'sphinx.ext.mathjax',
- 'sphinx.ext.autosummary', 'sphinx.ext.extlinks', 'numpydoc']
-
-+mathjax_path = 'mathjax/MathJax.js?config=TeX-AMS-MML_HTMLorMML'
-+
- numpydoc_show_class_members = False
-
- # Add any paths that contain templates here, relative to this directory.
--- dask-0.12.0/debian/rules 2016-12-07 21:54:28.000000000 +0300
+++ dask-0.12.0/debian/rules 2017-05-01 20:51:58.000000000 +0300
@@ -8,12 +8,10 @@
override_dh_auto_build: export https_proxy=127.0.0.1:9
override_dh_auto_build:
dh_auto_build
- ln -s /usr/share/javascript/mathjax docs/source/_static
PYTHONPATH=. sphinx-build -N -bhtml docs/source build/html # HTML generator
override_dh_auto_clean:
dh_auto_clean
- -rm docs/source/_static/mathjax
# Test needs: skimage, scipy, s3fs, cachey, distributed, graphviz
# dask is a build-dep for distributed... so we can't run tests at build
signature.asc
Description: PGP signature
